From: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>
To: qemu-devel@nongnu.org, aleksandar.qemu.devel@gmail.com,
alex.bennee@linaro.org, eblake@redhat.com, rth@twiddle.net,
ldoktor@redhat.com, ehabkost@redhat.com, crosa@redhat.com
Cc: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>
Subject: [PATCH v2 0/3] Add Scripts for Finding Top 25 Executed Functions
Date: Fri, 19 Jun 2020 17:36:29 +0200 [thread overview]
Message-ID: <20200619153632.1365-1-ahmedkhaledkaraman@gmail.com> (raw)
Greetings,
This series implements the improvements and changes requested to be
added to the two scripts.
Thanks to Mr. Aleksandar Markovic, Mr. Alex Bennée, and Mr. Eric Blake
for their valuable feedback.
First version of the series:
https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg04868.html
Best regards,
Ahmed Karaman
v1->v2:
- Add an empty line at the end of the MAINTAINERS file.
- Move MAINTAINERS patch to be the last in the series.
- Allow custom number of top functions to be specified.
- Check for vallgrind and perf before executing the scripts.
- Ensure sufficient permissions when running the topN_perf script.
- Use subprocess instead of os.system
- Use os.unlink() for deleting intermediate files.
- Spread out the data extraction steps.
- Enable execution permission for the scripts.
- Add script example output in the commit message.
Ahmed Karaman (3):
scripts/performance: Add topN_perf.py script
scripts/performance: Add topN_callgrind.py script
MAINTAINERS: Add 'Performance Tools and Tests' subsection
MAINTAINERS | 7 ++
scripts/performance/topN_callgrind.py | 131 ++++++++++++++++++++++++++
scripts/performance/topN_perf.py | 115 ++++++++++++++++++++++
3 files changed, 253 insertions(+)
create mode 100755 scripts/performance/topN_callgrind.py
create mode 100755 scripts/performance/topN_perf.py
--
2.17.1
next reply other threads:[~2020-06-19 15:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 15:36 Ahmed Karaman [this message]
2020-06-19 15:36 ` [PATCH v2 1/3] scripts/performance: Add topN_perf.py script Ahmed Karaman
2020-06-20 9:59 ` Aleksandar Markovic
2020-06-20 10:01 ` Aleksandar Markovic
2020-06-19 15:36 ` [PATCH v2 2/3] scripts/performance: Add topN_callgrind.py script Ahmed Karaman
2020-06-20 10:03 ` Aleksandar Markovic
2020-06-19 15:36 ` [PATCH v2 3/3] MAINTAINERS: Add 'Performance Tools and Tests' subsection Ahmed Karaman
2020-06-19 16:04 ` [PATCH v2 0/3] Add Scripts for Finding Top 25 Executed Functions no-reply
2020-06-20 9:14 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619153632.1365-1-ahmedkhaledkaraman@gmail.com \
--to=ahmedkhaledkaraman@gmail.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=ldoktor@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).