From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com,
qemu-block@nongnu.org, armbru@redhat.com, mreitz@redhat.com,
pkrempa@redhat.com, jsnow@redhat.com
Subject: [PATCH v3 0/6] block: add block-dirty-bitmap-populate job
Date: Fri, 19 Jun 2020 14:56:15 -0500 [thread overview]
Message-ID: <20200619195621.58740-1-eblake@redhat.com> (raw)
[From John's original cover letter:]
This is a new (very small) block job that writes a pattern into a
bitmap. The only pattern implemented is the top allocation information.
This can be used to "recover" an incremental bitmap chain if an external
snapshot was taken without creating a new bitmap first: any writes made
to the image will be reflected by the allocation status and can be
written back into a bitmap.
This is useful for e.g. libvirt managing backup chains if a user creates
an external snapshot outside of libvirt.
v3:
- Addressed a bit more feedback
- Make it easier to decide if we want an x- prefix if we think there
are more tweaks to be made to the interface
- Drop dependency on John's JobRunner iotest series
- Renumber the new iotest
I know there was a lot of discussion about whether there are
optimizations to be made with populating directly into the target
bitmap rather than into a temporary that then gets merged in at the
completion of the job, but the QMP aspect seems fairly stable. Even
so, we may still want to consider using an x- prefix until we know for
sure whether libvirt can make decent use of the interface.
Eric Blake (1):
bitmaps: Use x- prefix for block-dirty-bitmap-popluate
John Snow (5):
block: add bitmap-populate job
blockdev: combine DriveBackupState and BlockdevBackupState
qmp: expose block-dirty-bitmap-populate
iotests: move bitmap helpers into their own file
iotests: add 298 for block-dirty-bitmap-populate
qapi/block-core.json | 66 +
qapi/job.json | 6 +-
qapi/transaction.json | 2 +
include/block/block_int.h | 21 +
block/bitmap-populate.c | 207 ++
blockdev.c | 104 +-
blockjob.c | 3 +-
MAINTAINERS | 1 +
block/Makefile.objs | 1 +
tests/qemu-iotests/257 | 110 +-
tests/qemu-iotests/298 | 232 ++
tests/qemu-iotests/298.out | 4544 +++++++++++++++++++++++++++++++++
tests/qemu-iotests/bitmaps.py | 131 +
tests/qemu-iotests/group | 1 +
14 files changed, 5300 insertions(+), 129 deletions(-)
create mode 100644 block/bitmap-populate.c
create mode 100755 tests/qemu-iotests/298
create mode 100644 tests/qemu-iotests/298.out
create mode 100644 tests/qemu-iotests/bitmaps.py
--
2.27.0
next reply other threads:[~2020-06-19 19:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 19:56 Eric Blake [this message]
2020-06-19 19:56 ` [PATCH v3 1/6] block: add bitmap-populate job Eric Blake
2020-06-20 4:16 ` Vladimir Sementsov-Ogievskiy
2020-06-22 21:44 ` Eric Blake
2020-06-23 7:01 ` Vladimir Sementsov-Ogievskiy
2020-09-02 15:58 ` Eric Blake
2020-06-23 11:50 ` Kevin Wolf
2020-06-19 19:56 ` [PATCH v3 2/6] blockdev: combine DriveBackupState and BlockdevBackupState Eric Blake
2020-06-22 5:12 ` Vladimir Sementsov-Ogievskiy
2020-06-22 21:45 ` Eric Blake
2020-06-19 19:56 ` [PATCH v3 3/6] qmp: expose block-dirty-bitmap-populate Eric Blake
2020-06-19 19:56 ` [PATCH v3 4/6] iotests: move bitmap helpers into their own file Eric Blake
2020-06-22 5:26 ` Vladimir Sementsov-Ogievskiy
2020-06-19 19:56 ` [PATCH v3 5/6] iotests: add 298 for block-dirty-bitmap-populate Eric Blake
2020-06-19 19:56 ` [PATCH v3 6/6] bitmaps: Use x- prefix for block-dirty-bitmap-popluate Eric Blake
2020-06-23 11:45 ` Kevin Wolf
2020-06-23 11:47 ` [PATCH v3 0/6] block: add block-dirty-bitmap-populate job Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619195621.58740-1-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).