* [PATCH] .travis.yml: Build acceptance tests with -O2 compiler optimization
@ 2020-06-20 23:29 Philippe Mathieu-Daudé
2020-06-21 12:08 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-06-20 23:29 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Alex Bennée, Philippe Mathieu-Daudé,
Philippe Mathieu-Daudé
As we just want the tests to succeed, build them with compiler
optimizations enabled to run the tests faster.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index 74158f741b..61b247db9f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -293,7 +293,7 @@ jobs:
- name: "GCC check-acceptance"
dist: bionic
env:
- - CONFIG="--enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu"
+ - CONFIG="--extra-cflags=-O2 --enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu"
- TEST_CMD="make check-acceptance"
- CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-acceptance"
after_script:
--
2.21.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] .travis.yml: Build acceptance tests with -O2 compiler optimization
2020-06-20 23:29 [PATCH] .travis.yml: Build acceptance tests with -O2 compiler optimization Philippe Mathieu-Daudé
@ 2020-06-21 12:08 ` Philippe Mathieu-Daudé
2020-06-21 12:47 ` Alex Bennée
0 siblings, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-06-21 12:08 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Fam Zheng, Alex Bennée
On 6/21/20 1:29 AM, Philippe Mathieu-Daudé wrote:
> As we just want the tests to succeed, build them with compiler
> optimizations enabled to run the tests faster.
Maybe it is a good opportunity to test -O3 instead...
Since this configuration is not covered.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> .travis.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 74158f741b..61b247db9f 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -293,7 +293,7 @@ jobs:
> - name: "GCC check-acceptance"
> dist: bionic
> env:
> - - CONFIG="--enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu"
> + - CONFIG="--extra-cflags=-O2 --enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu"
> - TEST_CMD="make check-acceptance"
> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-acceptance"
> after_script:
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] .travis.yml: Build acceptance tests with -O2 compiler optimization
2020-06-21 12:08 ` Philippe Mathieu-Daudé
@ 2020-06-21 12:47 ` Alex Bennée
2020-06-21 18:05 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 5+ messages in thread
From: Alex Bennée @ 2020-06-21 12:47 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: Fam Zheng, qemu-devel
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> On 6/21/20 1:29 AM, Philippe Mathieu-Daudé wrote:
>> As we just want the tests to succeed, build them with compiler
>> optimizations enabled to run the tests faster.
>
> Maybe it is a good opportunity to test -O3 instead...
> Since this configuration is not covered.
Don't know if -O3 is worth it - even Gentoo developers warn against
cranking it up too much.
In fact I'm surprised we don't build -O2 by default.
>
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> .travis.yml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index 74158f741b..61b247db9f 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -293,7 +293,7 @@ jobs:
>> - name: "GCC check-acceptance"
>> dist: bionic
>> env:
>> - - CONFIG="--enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu"
>> + - CONFIG="--extra-cflags=-O2 --enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu"
>> - TEST_CMD="make check-acceptance"
>> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-acceptance"
>> after_script:
>>
--
Alex Bennée
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] .travis.yml: Build acceptance tests with -O2 compiler optimization
2020-06-21 12:47 ` Alex Bennée
@ 2020-06-21 18:05 ` Philippe Mathieu-Daudé
2020-06-22 8:21 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-06-21 18:05 UTC (permalink / raw)
To: Alex Bennée; +Cc: Fam Zheng, qemu-devel
On 6/21/20 2:47 PM, Alex Bennée wrote:
>
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
>
>> On 6/21/20 1:29 AM, Philippe Mathieu-Daudé wrote:
>>> As we just want the tests to succeed, build them with compiler
>>> optimizations enabled to run the tests faster.
>>
>> Maybe it is a good opportunity to test -O3 instead...
>> Since this configuration is not covered.
>
> Don't know if -O3 is worth it - even Gentoo developers warn against
> cranking it up too much.
>
> In fact I'm surprised we don't build -O2 by default.
Do you mean in Travis or directly in ./configure?
>
>>
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> .travis.yml | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/.travis.yml b/.travis.yml
>>> index 74158f741b..61b247db9f 100644
>>> --- a/.travis.yml
>>> +++ b/.travis.yml
>>> @@ -293,7 +293,7 @@ jobs:
>>> - name: "GCC check-acceptance"
>>> dist: bionic
>>> env:
>>> - - CONFIG="--enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu"
>>> + - CONFIG="--extra-cflags=-O2 --enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu"
>>> - TEST_CMD="make check-acceptance"
>>> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-acceptance"
>>> after_script:
>>>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] .travis.yml: Build acceptance tests with -O2 compiler optimization
2020-06-21 18:05 ` Philippe Mathieu-Daudé
@ 2020-06-22 8:21 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-06-22 8:21 UTC (permalink / raw)
To: Alex Bennée; +Cc: Fam Zheng, qemu-devel
On 6/21/20 8:05 PM, Philippe Mathieu-Daudé wrote:
> On 6/21/20 2:47 PM, Alex Bennée wrote:
>>
>> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
>>
>>> On 6/21/20 1:29 AM, Philippe Mathieu-Daudé wrote:
>>>> As we just want the tests to succeed, build them with compiler
>>>> optimizations enabled to run the tests faster.
>>>
>>> Maybe it is a good opportunity to test -O3 instead...
>>> Since this configuration is not covered.
>>
>> Don't know if -O3 is worth it - even Gentoo developers warn against
>> cranking it up too much.
>>
>> In fact I'm surprised we don't build -O2 by default.
>
> Do you mean in Travis or directly in ./configure?
Indeed ./configure uses -O2 is by default since 2005 :)
(commits c326e0afec0 / 6f30fa853b7 / ce278618b08).
>
>>
>>>
>>>>
>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> ---
>>>> .travis.yml | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/.travis.yml b/.travis.yml
>>>> index 74158f741b..61b247db9f 100644
>>>> --- a/.travis.yml
>>>> +++ b/.travis.yml
>>>> @@ -293,7 +293,7 @@ jobs:
>>>> - name: "GCC check-acceptance"
>>>> dist: bionic
>>>> env:
>>>> - - CONFIG="--enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu"
>>>> + - CONFIG="--extra-cflags=-O2 --enable-tools --target-list=aarch64-softmmu,alpha-softmmu,arm-softmmu,m68k-softmmu,microblaze-softmmu,mips-softmmu,mips64el-softmmu,nios2-softmmu,or1k-softmmu,ppc-softmmu,ppc64-softmmu,s390x-softmmu,sh4-softmmu,sparc-softmmu,x86_64-softmmu,xtensa-softmmu"
>>>> - TEST_CMD="make check-acceptance"
>>>> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-acceptance"
>>>> after_script:
>>>>
>>
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-22 8:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-20 23:29 [PATCH] .travis.yml: Build acceptance tests with -O2 compiler optimization Philippe Mathieu-Daudé
2020-06-21 12:08 ` Philippe Mathieu-Daudé
2020-06-21 12:47 ` Alex Bennée
2020-06-21 18:05 ` Philippe Mathieu-Daudé
2020-06-22 8:21 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).