* [PATCH] target/s390x: Fix SQXBR
@ 2020-06-20 4:21 Richard Henderson
2020-06-22 7:17 ` David Hildenbrand
2020-06-22 11:21 ` Cornelia Huck
0 siblings, 2 replies; 3+ messages in thread
From: Richard Henderson @ 2020-06-20 4:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-s390x, cohuck, david
The output is 128-bit, and thus requires a pair of 64-bit temps.
Buglink: https://bugs.launchpad.net/bugs/1883984
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/s390x/insn-data.def | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def
index 91ddaedd84..d79ae9e3f1 100644
--- a/target/s390x/insn-data.def
+++ b/target/s390x/insn-data.def
@@ -798,7 +798,7 @@
/* SQUARE ROOT */
F(0xb314, SQEBR, RRE, Z, 0, e2, new, e1, sqeb, 0, IF_BFP)
F(0xb315, SQDBR, RRE, Z, 0, f2, new, f1, sqdb, 0, IF_BFP)
- F(0xb316, SQXBR, RRE, Z, x2h, x2l, new, x1, sqxb, 0, IF_BFP)
+ F(0xb316, SQXBR, RRE, Z, x2h, x2l, new_P, x1, sqxb, 0, IF_BFP)
F(0xed14, SQEB, RXE, Z, 0, m2_32u, new, e1, sqeb, 0, IF_BFP)
F(0xed15, SQDB, RXE, Z, 0, m2_64, new, f1, sqdb, 0, IF_BFP)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] target/s390x: Fix SQXBR
2020-06-20 4:21 [PATCH] target/s390x: Fix SQXBR Richard Henderson
@ 2020-06-22 7:17 ` David Hildenbrand
2020-06-22 11:21 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2020-06-22 7:17 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: qemu-s390x, cohuck
On 20.06.20 06:21, Richard Henderson wrote:
> The output is 128-bit, and thus requires a pair of 64-bit temps.
>
> Buglink: https://bugs.launchpad.net/bugs/1883984
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/s390x/insn-data.def | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def
> index 91ddaedd84..d79ae9e3f1 100644
> --- a/target/s390x/insn-data.def
> +++ b/target/s390x/insn-data.def
> @@ -798,7 +798,7 @@
> /* SQUARE ROOT */
> F(0xb314, SQEBR, RRE, Z, 0, e2, new, e1, sqeb, 0, IF_BFP)
> F(0xb315, SQDBR, RRE, Z, 0, f2, new, f1, sqdb, 0, IF_BFP)
> - F(0xb316, SQXBR, RRE, Z, x2h, x2l, new, x1, sqxb, 0, IF_BFP)
> + F(0xb316, SQXBR, RRE, Z, x2h, x2l, new_P, x1, sqxb, 0, IF_BFP)
> F(0xed14, SQEB, RXE, Z, 0, m2_32u, new, e1, sqeb, 0, IF_BFP)
> F(0xed15, SQDB, RXE, Z, 0, m2_64, new, f1, sqdb, 0, IF_BFP)
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target/s390x: Fix SQXBR
2020-06-20 4:21 [PATCH] target/s390x: Fix SQXBR Richard Henderson
2020-06-22 7:17 ` David Hildenbrand
@ 2020-06-22 11:21 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2020-06-22 11:21 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-s390x, qemu-devel, david
On Fri, 19 Jun 2020 21:21:40 -0700
Richard Henderson <richard.henderson@linaro.org> wrote:
> The output is 128-bit, and thus requires a pair of 64-bit temps.
>
> Buglink: https://bugs.launchpad.net/bugs/1883984
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/s390x/insn-data.def | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def
> index 91ddaedd84..d79ae9e3f1 100644
> --- a/target/s390x/insn-data.def
> +++ b/target/s390x/insn-data.def
> @@ -798,7 +798,7 @@
> /* SQUARE ROOT */
> F(0xb314, SQEBR, RRE, Z, 0, e2, new, e1, sqeb, 0, IF_BFP)
> F(0xb315, SQDBR, RRE, Z, 0, f2, new, f1, sqdb, 0, IF_BFP)
> - F(0xb316, SQXBR, RRE, Z, x2h, x2l, new, x1, sqxb, 0, IF_BFP)
> + F(0xb316, SQXBR, RRE, Z, x2h, x2l, new_P, x1, sqxb, 0, IF_BFP)
> F(0xed14, SQEB, RXE, Z, 0, m2_32u, new, e1, sqeb, 0, IF_BFP)
> F(0xed15, SQDB, RXE, Z, 0, m2_64, new, f1, sqdb, 0, IF_BFP)
>
Thanks, applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-22 11:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-20 4:21 [PATCH] target/s390x: Fix SQXBR Richard Henderson
2020-06-22 7:17 ` David Hildenbrand
2020-06-22 11:21 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).