qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: dinechin@redhat.com, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>
Subject: [PATCH v4 2/7] build: fix device module builds
Date: Mon, 22 Jun 2020 15:55:56 +0200	[thread overview]
Message-ID: <20200622135601.12433-3-kraxel@redhat.com> (raw)
In-Reply-To: <20200622135601.12433-1-kraxel@redhat.com>

See comment.  Feels quite hackish.  Better ideas anyone?

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 Makefile.target | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Makefile.target b/Makefile.target
index 8ed1eba95b9c..c70325df5796 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -179,6 +179,13 @@ endif # CONFIG_SOFTMMU
 dummy := $(call unnest-vars,,obj-y)
 all-obj-y := $(obj-y)
 
+#
+# common-obj-m has some crap here, probably as side effect from
+# filling obj-y.  Clear it.  Fixes suspious dependency errors when
+# building devices as modules.
+#
+common-obj-m :=
+
 include $(SRC_PATH)/Makefile.objs
 dummy := $(call unnest-vars,.., \
                authz-obj-y \
-- 
2.18.4



  parent reply	other threads:[~2020-06-22 13:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-22 13:55 [PATCH v4 0/7] build some devices as modules Gerd Hoffmann
2020-06-22 13:55 ` [PATCH v4 1/7] qdev: add support for device module loading Gerd Hoffmann
2020-06-26 18:46   ` Richard Henderson
2020-06-22 13:55 ` Gerd Hoffmann [this message]
2020-06-22 13:55 ` [PATCH v4 3/7] ccid: build smartcard as module Gerd Hoffmann
2020-06-23 15:28   ` Philippe Mathieu-Daudé
2020-06-23 17:12     ` Gerd Hoffmann
2020-06-30  9:44       ` Philippe Mathieu-Daudé
2020-06-30 16:07         ` Gerd Hoffmann
2020-06-30 16:24           ` Daniel P. Berrangé
2020-06-22 13:55 ` [PATCH v4 4/7] usb: build usb-redir " Gerd Hoffmann
2020-06-22 13:55 ` [PATCH v4 5/7] vga: build qxl " Gerd Hoffmann
2020-06-22 13:56 ` [PATCH v4 6/7] vga: build virtio-gpu only once Gerd Hoffmann
2020-06-22 13:56 ` [PATCH v4 7/7] vga: build virtio-gpu as module Gerd Hoffmann
2020-06-23 15:04 ` [PATCH v4 0/7] build some devices as modules Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200622135601.12433-3-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dinechin@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).