From: Igor Mammedov <imammedo@redhat.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: kraxel@redhat.com, QEMU Developers <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] hw/acpi: specify 64-bit acpi table
Date: Mon, 22 Jun 2020 14:18:38 +0200 [thread overview]
Message-ID: <20200622141838.2c858274@redhat.com> (raw)
In-Reply-To: <CAHmME9ruo0ZihXbtGdygAm48NBaXR0botmLyMxa+_YYPpHwghA@mail.gmail.com>
On Tue, 16 Jun 2020 13:20:17 -0600
"Jason A. Donenfeld" <Jason@zx2c4.com> wrote:
> > > increment the revision to '2' so that these larger addresses are
> > > addressable. This matters because the DSDT revision represents the
> > > maximum capability of all other SSDTs. This is also what arm does.
> > it was keept at 1 for compat reasons with WindowsXP.
> > by now it is long time EOL, so it might be fine to bump version,
> > but it would be nice to know if this change breaks XP or not?
>
> I just installed Windows XP twice, once without the patch and once
> with the patch. The command line I used for this was:
>
> qemu-system-x86_64 -m 3G -cpu host -enable-kvm -M pc-1.0 -drive file=disk.qcow
> 2 -cdrom en_windows_xp_professional_with_service_pack_3_x86_cd_vl_x14-73974.iso
>
> Aside from the nostalgia being completely overwhelming, both installs
> were successful, and I was greeted with the terrific bliss.bmp
> background.
I'm not sure runnig test with pc-1.0 is valid, since ACPI tables generated by QEMU
happend around 1.7 time.
Can you retest with latest machine version "-M pc", please?
prev parent reply other threads:[~2020-06-22 12:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 0:36 [PATCH] hw/acpi: specify 64-bit acpi table Jason A. Donenfeld
2020-06-16 0:59 ` no-reply
2020-06-16 1:25 ` no-reply
2020-06-16 8:16 ` Igor Mammedov
2020-06-16 18:50 ` Jason A. Donenfeld
2020-06-16 19:20 ` Jason A. Donenfeld
2020-06-22 12:18 ` Igor Mammedov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622141838.2c858274@redhat.com \
--to=imammedo@redhat.com \
--cc=Jason@zx2c4.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).