From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B317BC433E0 for ; Mon, 22 Jun 2020 14:54:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89C1520732 for ; Mon, 22 Jun 2020 14:54:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89C1520732 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnNqc-0006vr-Qj for qemu-devel@archiver.kernel.org; Mon, 22 Jun 2020 10:54:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45028) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnNpv-00065C-9K for qemu-devel@nongnu.org; Mon, 22 Jun 2020 10:54:15 -0400 Received: from 1.mo6.mail-out.ovh.net ([46.105.56.136]:51656) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnNps-0001Sk-2E for qemu-devel@nongnu.org; Mon, 22 Jun 2020 10:54:14 -0400 Received: from player158.ha.ovh.net (unknown [10.108.42.192]) by mo6.mail-out.ovh.net (Postfix) with ESMTP id 13E6A21480B for ; Mon, 22 Jun 2020 16:54:08 +0200 (CEST) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player158.ha.ovh.net (Postfix) with ESMTPSA id 634D71398B37F; Mon, 22 Jun 2020 14:54:05 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-106R00641aeacb7-4aae-4c72-b910-6a87638bc6f2,6D3CA472F13BA58F0C95800BF735BE34A93B107C) smtp.auth=groug@kaod.org Date: Mon, 22 Jun 2020 16:54:04 +0200 From: Greg Kurz To: Markus Armbruster Subject: Re: [PATCH 07/22] spapr: Plug minor memory leak in spapr_machine_init() Message-ID: <20200622165404.2548e71c@bahia.lan> In-Reply-To: <20200622104250.1404835-8-armbru@redhat.com> References: <20200622104250.1404835-1-armbru@redhat.com> <20200622104250.1404835-8-armbru@redhat.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 14271907221257689486 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduhedrudekvddgkeefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfesthejredtredtvdenucfhrhhomhepifhrvghgucfmuhhriicuoehgrhhouhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepheekhfdtheegheehjeeludefkefhvdelfedvieehhfekhfdufffhueeuvdfftdfhnecukfhppedtrddtrddtrddtpdekvddrvdehfedrvddtkedrvdegkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrhduheekrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepghhrohhugheskhgrohgurdhorhhgpdhrtghpthhtohepqhgvmhhuqdguvghvvghlsehnohhnghhnuhdrohhrgh Received-SPF: pass client-ip=46.105.56.136; envelope-from=groug@kaod.org; helo=1.mo6.mail-out.ovh.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/22 10:54:09 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Gibson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 22 Jun 2020 12:42:35 +0200 Markus Armbruster wrote: > spapr_machine_init() leaks an Error object when > kvmppc_check_papr_resize_hpt() fails and spapr->resize_hpt is > SPAPR_RESIZE_HPT_DISABLED, i.e. when the host doesn't support hash > page table resizing, and the user didn't ask for it. As harmless as > memory leaks can possibly be. Plug it. > > Fixes: 30f4b05bd090564181554d0890605eb2c143e4ea > Cc: David Gibson > Cc: qemu-ppc@nongnu.org > Signed-off-by: Markus Armbruster > --- Reviewed-by: Greg Kurz > hw/ppc/spapr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index bd9345cdac..9bd2183ead 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -2731,6 +2731,7 @@ static void spapr_machine_init(MachineState *machine) > error_report_err(resize_hpt_err); > exit(1); > } > + error_free(resize_hpt_err); > > spapr->rma_size = spapr_rma_size(spapr, &error_fatal); >