qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Juan Quintela <quintela@redhat.com>
Subject: [PATCH] Revert "tests/migration: Reduce autoconverge initial bandwidth"
Date: Tue, 23 Jun 2020 10:56:59 -0400	[thread overview]
Message-ID: <20200623145506.439100-1-mst@redhat.com> (raw)

This reverts commit 6d1da867e65f ("tests/migration: Reduce autoconverge initial bandwidth")
since that change makes unit tests much slower for all developers, while it's not
a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth without slowing
things down for everyone.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

---
 tests/qtest/migration-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index dc3490c9fa..21ea5ba1d2 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)
      * without throttling.
      */
     migrate_set_parameter_int(from, "downtime-limit", 1);
-    migrate_set_parameter_int(from, "max-bandwidth", 1000000); /* ~1Mb/s */
+    migrate_set_parameter_int(from, "max-bandwidth", 100000000); /* ~100Mb/s */
 
     /* To check remaining size after precopy */
     migrate_set_capability(from, "pause-before-switchover", true);
-- 
MST



             reply	other threads:[~2020-06-23 15:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23 14:56 Michael S. Tsirkin [this message]
2020-06-23 15:39 ` [PATCH] Revert "tests/migration: Reduce autoconverge initial bandwidth" Philippe Mathieu-Daudé
2020-06-23 17:07   ` Thomas Huth
2020-06-23 17:35     ` Philippe Mathieu-Daudé
2020-06-23 20:59       ` Michael S. Tsirkin
2020-06-24  5:04       ` Thomas Huth
2020-06-24 10:21         ` Philippe Mathieu-Daudé
2020-06-24 16:26           ` Philippe Mathieu-Daudé
2020-06-25  5:35             ` Thomas Huth
2020-06-23 20:58   ` Michael S. Tsirkin
2020-06-24 15:53 ` Dr. David Alan Gilbert
2020-06-30 13:07 ` Michael S. Tsirkin
2020-06-30 13:20   ` Thomas Huth
2020-06-30 14:43     ` Michael S. Tsirkin
2020-06-30 14:44       ` Thomas Huth
2020-06-30 13:59   ` Dr. David Alan Gilbert
2020-06-30 14:43     ` Michael S. Tsirkin
2020-06-30 14:54       ` Dr. David Alan Gilbert
2020-06-30 14:55 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200623145506.439100-1-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).