From: Janosch Frank <frankja@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, thuth@redhat.com, cohuck@redhat.com,
david@redhat.com
Subject: [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1
Date: Wed, 24 Jun 2020 03:52:14 -0400 [thread overview]
Message-ID: <20200624075226.92728-1-frankja@linux.ibm.com> (raw)
The bios is in dire need for a cleanup as there are still a lot of
magic constants being used throughout as well as duplicated code.
In the first part of this series we consolidate constants and
functions, as well as doing some minor cleanups and fixes.
The patches are available here:
https://github.com/frankjaa/qemu/pull/new/cleanup_bios
v5:
* Fixed whitespace damage
* Removed reset PSW mask changes in dasd-ipl.c
* Added jump2ipl.c cleanup patches
v4:
* Renamed time.h to s390-time.h
* Fixed function names in sleep()
* Changed order of sense_id_ccw initialization
* Added missing include before sleep()
v3:
* Dropped 0x00 to 0x0/0 patch
* Moved some timing functions into helper.h instead of time.h
* Fixed IPL psw manipulation in dasd-ipl.c
* Minor cosmetic fixes found by review
v2:
* Included cio fixup to get rid of compile errors...
* Minor cosmetic fixes found by review
Janosch Frank (12):
pc-bios: s390x: cio.c cleanup and compile fix
pc-bios: s390x: Consolidate timing functions into time.h
pc-bios: s390x: Move sleep and yield to helper.h
pc-bios: s390x: Get rid of magic offsets into the lowcore
pc-bios: s390x: Remove unneeded dasd-ipl.c reset psw mask changes
pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64
pc-bios: s390x: Use PSW masks where possible and introduce
PSW_MASK_SHORT_ADDR
pc-bios: s390x: Move panic() into header and add infinite loop
pc-bios: s390x: Use ebcdic2ascii table
pc-bios: s390x: Make u32 ptr check explicit
pc-bios: s390x: Fix bootmap.c passing PSWs as addresses
pc-bios: s390x: Cleanup jump to ipl code
pc-bios/s390-ccw/bootmap.c | 9 ++++----
pc-bios/s390-ccw/bootmap.h | 2 +-
pc-bios/s390-ccw/cio.c | 40 +++++++++++++++++++---------------
pc-bios/s390-ccw/cio.h | 17 ++++++++++-----
pc-bios/s390-ccw/dasd-ipl.c | 3 ---
pc-bios/s390-ccw/helper.h | 19 +++++++++++++++-
pc-bios/s390-ccw/jump2ipl.c | 35 ++++++++++++-----------------
pc-bios/s390-ccw/main.c | 15 +++----------
pc-bios/s390-ccw/menu.c | 1 +
pc-bios/s390-ccw/netmain.c | 23 +++----------------
pc-bios/s390-ccw/s390-arch.h | 4 +++-
pc-bios/s390-ccw/s390-ccw.h | 27 ++++++-----------------
pc-bios/s390-ccw/s390-time.h | 23 +++++++++++++++++++
pc-bios/s390-ccw/start.S | 5 +++--
pc-bios/s390-ccw/virtio-net.c | 2 ++
pc-bios/s390-ccw/virtio-scsi.c | 2 ++
pc-bios/s390-ccw/virtio.c | 18 +++------------
17 files changed, 120 insertions(+), 125 deletions(-)
create mode 100644 pc-bios/s390-ccw/s390-time.h
--
2.25.1
next reply other threads:[~2020-06-24 7:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 7:52 Janosch Frank [this message]
2020-06-24 7:52 ` [PATCH v5 01/12] pc-bios: s390x: cio.c cleanup and compile fix Janosch Frank
2020-06-29 15:50 ` Cornelia Huck
2020-06-24 7:52 ` [PATCH v5 02/12] pc-bios: s390x: Consolidate timing functions into time.h Janosch Frank
2020-06-24 14:13 ` David Hildenbrand
2020-06-24 7:52 ` [PATCH v5 03/12] pc-bios: s390x: Move sleep and yield to helper.h Janosch Frank
2020-06-24 7:52 ` [PATCH v5 04/12] pc-bios: s390x: Get rid of magic offsets into the lowcore Janosch Frank
2020-06-25 10:26 ` Thomas Huth
2020-06-29 15:52 ` Cornelia Huck
2020-06-24 7:52 ` [PATCH v5 05/12] pc-bios: s390x: Remove unneeded dasd-ipl.c reset psw mask changes Janosch Frank
2020-06-25 10:57 ` Thomas Huth
2020-06-25 11:09 ` Thomas Huth
2020-06-24 7:52 ` [PATCH v5 06/12] pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64 Janosch Frank
2020-06-25 11:05 ` Thomas Huth
2020-06-24 7:52 ` [PATCH v5 07/12] pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR Janosch Frank
2020-06-25 11:39 ` Thomas Huth
2020-06-24 7:52 ` [PATCH v5 08/12] pc-bios: s390x: Move panic() into header and add infinite loop Janosch Frank
2020-06-24 7:52 ` [PATCH v5 09/12] pc-bios: s390x: Use ebcdic2ascii table Janosch Frank
2020-06-24 7:52 ` [PATCH v5 10/12] pc-bios: s390x: Make u32 ptr check explicit Janosch Frank
2020-06-24 7:52 ` [PATCH v5 11/12] pc-bios: s390x: Fix bootmap.c passing PSWs as addresses Janosch Frank
2020-06-25 12:46 ` Thomas Huth
2020-06-26 8:02 ` Janosch Frank
2020-06-24 7:52 ` [RFC v5 12/12] pc-bios: s390x: Cleanup jump to ipl code Janosch Frank
2020-06-25 12:58 ` Thomas Huth
2020-06-26 8:04 ` Janosch Frank
2020-06-24 8:06 ` [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1 no-reply
2020-06-24 10:44 ` Cornelia Huck
2020-06-24 10:46 ` Thomas Huth
2020-06-24 10:57 ` Janosch Frank
2020-06-30 8:48 ` Thomas Huth
2020-06-24 11:08 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624075226.92728-1-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).