qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, thuth@redhat.com, cohuck@redhat.com,
	david@redhat.com
Subject: [PATCH v5 11/12] pc-bios: s390x: Fix bootmap.c passing PSWs as addresses
Date: Wed, 24 Jun 2020 03:52:25 -0400	[thread overview]
Message-ID: <20200624075226.92728-12-frankja@linux.ibm.com> (raw)
In-Reply-To: <20200624075226.92728-1-frankja@linux.ibm.com>

The component entries written by zipl contain short PSWs, not
addresses. Let's mask them and only pass the address part to
jump_to_IPL_code(uint64_t address) because it expects an address as
visible by the name of the argument.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
 pc-bios/s390-ccw/bootmap.c | 5 +++--
 pc-bios/s390-ccw/bootmap.h | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootmap.c
index 97205674e5..8547a140df 100644
--- a/pc-bios/s390-ccw/bootmap.c
+++ b/pc-bios/s390-ccw/bootmap.c
@@ -10,6 +10,7 @@
 
 #include "libc.h"
 #include "s390-ccw.h"
+#include "s390-arch.h"
 #include "bootmap.h"
 #include "virtio.h"
 #include "bswap.h"
@@ -436,7 +437,7 @@ static void zipl_load_segment(ComponentEntry *entry)
     char *blk_no = &err_msg[30]; /* where to print blockno in (those ZZs) */
 
     blockno = entry->data.blockno;
-    address = entry->load_address;
+    address = entry->psw & PSW_MASK_SHORT_ADDR;
 
     debug_print_int("loading segment at block", blockno);
     debug_print_int("addr", address);
@@ -514,7 +515,7 @@ static void zipl_run(ScsiBlockPtr *pte)
     IPL_assert(entry->component_type == ZIPL_COMP_ENTRY_EXEC, "No EXEC entry");
 
     /* should not return */
-    jump_to_IPL_code(entry->load_address);
+    jump_to_IPL_code(entry->psw & PSW_MASK_SHORT_ADDR);
 }
 
 static void ipl_scsi(void)
diff --git a/pc-bios/s390-ccw/bootmap.h b/pc-bios/s390-ccw/bootmap.h
index 12a0166aae..e07f87e690 100644
--- a/pc-bios/s390-ccw/bootmap.h
+++ b/pc-bios/s390-ccw/bootmap.h
@@ -68,7 +68,7 @@ typedef struct ComponentEntry {
     ScsiBlockPtr data;
     uint8_t pad[7];
     uint8_t component_type;
-    uint64_t load_address;
+    uint64_t psw;
 } __attribute((packed)) ComponentEntry;
 
 typedef struct ComponentHeader {
-- 
2.25.1



  parent reply	other threads:[~2020-06-24  7:54 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-24  7:52 [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1 Janosch Frank
2020-06-24  7:52 ` [PATCH v5 01/12] pc-bios: s390x: cio.c cleanup and compile fix Janosch Frank
2020-06-29 15:50   ` Cornelia Huck
2020-06-24  7:52 ` [PATCH v5 02/12] pc-bios: s390x: Consolidate timing functions into time.h Janosch Frank
2020-06-24 14:13   ` David Hildenbrand
2020-06-24  7:52 ` [PATCH v5 03/12] pc-bios: s390x: Move sleep and yield to helper.h Janosch Frank
2020-06-24  7:52 ` [PATCH v5 04/12] pc-bios: s390x: Get rid of magic offsets into the lowcore Janosch Frank
2020-06-25 10:26   ` Thomas Huth
2020-06-29 15:52   ` Cornelia Huck
2020-06-24  7:52 ` [PATCH v5 05/12] pc-bios: s390x: Remove unneeded dasd-ipl.c reset psw mask changes Janosch Frank
2020-06-25 10:57   ` Thomas Huth
2020-06-25 11:09     ` Thomas Huth
2020-06-24  7:52 ` [PATCH v5 06/12] pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64 Janosch Frank
2020-06-25 11:05   ` Thomas Huth
2020-06-24  7:52 ` [PATCH v5 07/12] pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR Janosch Frank
2020-06-25 11:39   ` Thomas Huth
2020-06-24  7:52 ` [PATCH v5 08/12] pc-bios: s390x: Move panic() into header and add infinite loop Janosch Frank
2020-06-24  7:52 ` [PATCH v5 09/12] pc-bios: s390x: Use ebcdic2ascii table Janosch Frank
2020-06-24  7:52 ` [PATCH v5 10/12] pc-bios: s390x: Make u32 ptr check explicit Janosch Frank
2020-06-24  7:52 ` Janosch Frank [this message]
2020-06-25 12:46   ` [PATCH v5 11/12] pc-bios: s390x: Fix bootmap.c passing PSWs as addresses Thomas Huth
2020-06-26  8:02     ` Janosch Frank
2020-06-24  7:52 ` [RFC v5 12/12] pc-bios: s390x: Cleanup jump to ipl code Janosch Frank
2020-06-25 12:58   ` Thomas Huth
2020-06-26  8:04     ` Janosch Frank
2020-06-24  8:06 ` [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1 no-reply
2020-06-24 10:44 ` Cornelia Huck
2020-06-24 10:46   ` Thomas Huth
2020-06-24 10:57     ` Janosch Frank
2020-06-30  8:48       ` Thomas Huth
2020-06-24 11:08     ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200624075226.92728-12-frankja@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).