From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [PATCH v2 00/25] Error handling fixes & cleanups
Date: Wed, 24 Jun 2020 10:37:12 +0200 [thread overview]
Message-ID: <20200624083737.3086768-1-armbru@redhat.com> (raw)
This series addresses a number of error handling issues I found while
working on error handling improvements. It's based on my "[PULL
00/16] Qdev patches for 2020-06-23" merged into current master.
Based-on: <20200623142326.2349416-1-armbru@redhat.com>
v2:
* PATCH 04: Two more instances, in tests/check-qom-proplist
* PATCH 12: Dropped; PATCH 04 takes care of it
* PATCH 17: One more instance due to rebase; R-by kept
* PATCH 22-25: New
Markus Armbruster (25):
net/virtio: Fix failover_replug_primary() return value regression
pci: Delete useless error_propagate()
Clean up some calls to ignore Error objects the right way
tests: Use &error_abort where appropriate
tests: Use error_free_or_abort() where appropriate
usb/dev-mtp: Fix Error double free after inotify failure
spapr: Plug minor memory leak in spapr_machine_init()
qga: Plug unlikely memory leak in guest-set-memory-blocks
sd/milkymist-memcard: Plug minor memory leak in realize
test-util-filemonitor: Plug unlikely memory leak
vnc: Plug minor memory leak in vnc_display_open()
aspeed: Clean up roundabout error propagation
qdev: Drop qbus_set_bus_hotplug_handler() parameter @errp
qdev: Drop qbus_set_hotplug_handler() parameter @errp
hw: Fix error API violation around object_property_set_link()
hw/arm: Drop useless object_property_set_link() error handling
riscv/sifive_u: Fix sifive_u_soc_realize() error API violations
riscv_hart: Fix riscv_harts_realize() error API violations
mips/cps: Fix mips_cps_realize() error API violations
x86: Fix x86_cpu_new() error API violations
amd_iommu: Fix amdvi_realize() error API violation
arm/stm32f205 arm/stm32f405: Fix realize error API violation
aspeed: Fix realize error API violation
hw/arm/armsse: Fix armsse_realize() error API violation
arm/{bcm2835,fsl-imx25,fsl-imx6}: Fix realize error API violations
include/hw/qdev-core.h | 5 +-
chardev/char-socket.c | 6 +-
hw/9pfs/9p.c | 6 +-
hw/acpi/pcihp.c | 3 +-
hw/acpi/piix4.c | 2 +-
hw/arm/armsse.c | 61 +++++-----------
hw/arm/armv7m.c | 7 +-
hw/arm/aspeed_ast2600.c | 35 ++++-----
hw/arm/aspeed_soc.c | 29 +++-----
hw/arm/bcm2835_peripherals.c | 12 ++--
hw/arm/fsl-imx25.c | 12 ++--
hw/arm/fsl-imx6.c | 12 ++--
hw/arm/nrf51_soc.c | 6 +-
hw/arm/stm32f205_soc.c | 2 +-
hw/arm/stm32f405_soc.c | 2 +-
hw/arm/virt.c | 4 +-
hw/char/virtio-serial-bus.c | 4 +-
hw/core/bus.c | 8 +--
hw/display/virtio-gpu-pci.c | 2 +-
hw/display/virtio-vga.c | 2 +-
hw/dma/sparc32_dma.c | 6 +-
hw/dma/xilinx_axidma.c | 12 +---
hw/i386/amd_iommu.c | 6 +-
hw/i386/x86.c | 12 +---
hw/mips/cps.c | 35 +++++----
hw/misc/macio/macio.c | 3 +-
hw/net/virtio-net.c | 2 +-
hw/net/xilinx_axienet.c | 12 +---
hw/pci/pci.c | 3 -
hw/pci/pcie.c | 2 +-
hw/pci/shpc.c | 2 +-
hw/ppc/spapr.c | 4 +-
hw/ppc/spapr_drc.c | 4 +-
hw/ppc/spapr_pci.c | 4 +-
hw/riscv/riscv_hart.c | 14 ++--
hw/riscv/sifive_u.c | 12 +++-
hw/s390x/ap-bridge.c | 2 +-
hw/s390x/css-bridge.c | 2 +-
hw/s390x/s390-pci-bus.c | 14 +---
hw/scsi/scsi-bus.c | 2 +-
hw/scsi/virtio-scsi.c | 4 +-
hw/scsi/vmw_pvscsi.c | 2 +-
hw/sd/milkymist-memcard.c | 5 +-
hw/usb/bus.c | 2 +-
hw/usb/dev-mtp.c | 2 -
hw/usb/dev-smartcard-reader.c | 2 +-
hw/virtio/virtio-iommu-pci.c | 2 +-
hw/xen/xen-bus.c | 2 +-
hw/xen/xen-legacy-backend.c | 2 +-
qga/commands-posix.c | 1 +
tests/check-block-qdict.c | 24 ++-----
tests/check-qobject.c | 5 +-
tests/check-qom-proplist.c | 14 ++--
tests/test-base64.c | 3 +-
tests/test-bdrv-graph-mod.c | 4 +-
tests/test-block-iothread.c | 3 +-
tests/test-crypto-cipher.c | 8 +--
tests/test-io-task.c | 4 +-
tests/test-logging.c | 12 +---
tests/test-qemu-opts.c | 22 ++----
tests/test-replication.c | 109 +++++++++--------------------
tests/test-string-input-visitor.c | 33 +++------
tests/test-string-output-visitor.c | 16 ++---
tests/test-util-filemonitor.c | 1 +
ui/vnc.c | 6 +-
65 files changed, 229 insertions(+), 432 deletions(-)
--
2.26.2
next reply other threads:[~2020-06-24 8:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 8:37 Markus Armbruster [this message]
2020-06-24 8:37 ` [PATCH v2 01/25] net/virtio: Fix failover_replug_primary() return value regression Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 02/25] pci: Delete useless error_propagate() Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 03/25] Clean up some calls to ignore Error objects the right way Markus Armbruster
2020-06-24 9:02 ` Greg Kurz
2020-06-25 6:42 ` Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 04/25] tests: Use &error_abort where appropriate Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 05/25] tests: Use error_free_or_abort() " Markus Armbruster
2020-06-24 14:42 ` Eric Blake
2020-06-24 8:37 ` [PATCH v2 06/25] usb/dev-mtp: Fix Error double free after inotify failure Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 07/25] spapr: Plug minor memory leak in spapr_machine_init() Markus Armbruster
2020-06-24 9:04 ` Greg Kurz
2020-06-25 3:52 ` David Gibson
2020-06-24 8:37 ` [PATCH v2 08/25] qga: Plug unlikely memory leak in guest-set-memory-blocks Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 09/25] sd/milkymist-memcard: Plug minor memory leak in realize Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 10/25] test-util-filemonitor: Plug unlikely memory leak Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 11/25] vnc: Plug minor memory leak in vnc_display_open() Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 12/25] aspeed: Clean up roundabout error propagation Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 13/25] qdev: Drop qbus_set_bus_hotplug_handler() parameter @errp Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 14/25] qdev: Drop qbus_set_hotplug_handler() " Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 15/25] hw: Fix error API violation around object_property_set_link() Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 16/25] hw/arm: Drop useless object_property_set_link() error handling Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 17/25] riscv/sifive_u: Fix sifive_u_soc_realize() error API violations Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 18/25] riscv_hart: Fix riscv_harts_realize() " Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 19/25] mips/cps: Fix mips_cps_realize() " Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 20/25] x86: Fix x86_cpu_new() " Markus Armbruster
2020-06-24 14:17 ` Igor Mammedov
2020-06-24 14:20 ` Paolo Bonzini
2020-06-25 6:44 ` Markus Armbruster
2020-06-25 19:29 ` Igor Mammedov
2020-06-26 12:54 ` Markus Armbruster
2020-07-13 15:50 ` Igor Mammedov
2020-07-14 9:49 ` Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 21/25] amd_iommu: Fix amdvi_realize() error API violation Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 22/25] arm/stm32f205 arm/stm32f405: Fix realize " Markus Armbruster
2020-06-24 19:17 ` Alistair Francis
2020-06-24 8:37 ` [PATCH v2 23/25] aspeed: " Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 24/25] hw/arm/armsse: Fix armsse_realize() " Markus Armbruster
2020-06-24 8:37 ` [PATCH v2 25/25] arm/{bcm2835, fsl-imx25, fsl-imx6}: Fix realize error API violations Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624083737.3086768-1-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).