From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
libvir-list@redhat.com, "Hervé Poussineau" <hpoussin@reactos.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v4 12/20] pc_basic_device_init: drop has_pit arg
Date: Wed, 24 Jun 2020 13:30:18 +0200 [thread overview]
Message-ID: <20200624113026.13343-13-kraxel@redhat.com> (raw)
In-Reply-To: <20200624113026.13343-1-kraxel@redhat.com>
Now that we pass pcms anyway, we don't need the has_pit arg any more.
No functional change.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
include/hw/i386/pc.h | 1 -
hw/i386/pc.c | 3 +--
hw/i386/pc_piix.c | 2 +-
hw/i386/pc_q35.c | 2 +-
4 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 9b94926410c0..3512dcfd3d27 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -165,7 +165,6 @@ void pc_basic_device_init(struct PCMachineState *pcms,
ISADevice **rtc_state,
bool create_fdctrl,
bool no_vmport,
- bool has_pit,
uint32_t hpet_irqs);
void pc_init_ne2k_isa(ISABus *bus, NICInfo *nd);
void pc_cmos_init(PCMachineState *pcms,
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 9afb003dfc21..dfe8ba07e982 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1181,7 +1181,6 @@ void pc_basic_device_init(struct PCMachineState *pcms,
ISADevice **rtc_state,
bool create_fdctrl,
bool no_vmport,
- bool has_pit,
uint32_t hpet_irqs)
{
int i;
@@ -1232,7 +1231,7 @@ void pc_basic_device_init(struct PCMachineState *pcms,
qemu_register_boot_set(pc_boot_set, *rtc_state);
- if (!xen_enabled() && has_pit) {
+ if (!xen_enabled() && pcms->pit_enabled) {
if (kvm_pit_in_kernel()) {
pit = kvm_pit_init(isa_bus, 0x40);
} else {
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 605252fe7936..1242ed811804 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -236,7 +236,7 @@ static void pc_init1(MachineState *machine,
/* init basic PC hardware */
pc_basic_device_init(pcms, isa_bus, x86ms->gsi, &rtc_state, true,
- (pcms->vmport != ON_OFF_AUTO_ON), pcms->pit_enabled,
+ (pcms->vmport != ON_OFF_AUTO_ON),
0x4);
pc_nic_init(pcmc, isa_bus, pci_bus);
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index e4b15f27227a..25dc40896673 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -276,7 +276,7 @@ static void pc_q35_init(MachineState *machine)
/* init basic PC hardware */
pc_basic_device_init(pcms, isa_bus, x86ms->gsi, &rtc_state, !mc->no_floppy,
- (pcms->vmport != ON_OFF_AUTO_ON), pcms->pit_enabled,
+ (pcms->vmport != ON_OFF_AUTO_ON),
0xff0104);
/* connect pm stuff to lpc */
--
2.18.4
next prev parent reply other threads:[~2020-06-24 11:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 11:30 [PATCH v4 00/20] audio: deprecate -soundhw Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 01/20] stubs: add isa_create_simple Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 02/20] stubs: add pci_create_simple Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 03/20] audio: add deprecated_register_soundhw Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 04/20] audio: deprecate -soundhw ac97 Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 05/20] audio: deprecate -soundhw es1370 Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 06/20] audio: deprecate -soundhw adlib Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 07/20] audio: deprecate -soundhw cs4231a Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 08/20] audio: deprecate -soundhw gus Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 09/20] audio: deprecate -soundhw sb16 Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 10/20] audio: deprecate -soundhw hda Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 11/20] pc_basic_device_init: pass PCMachineState Gerd Hoffmann
2020-06-24 11:30 ` Gerd Hoffmann [this message]
2020-06-24 11:30 ` [PATCH v4 13/20] pc_basic_device_init: drop no_vmport arg Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 14/20] softmmu: initialize spice and audio earlier Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 15/20] audio: rework pcspk_init() Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 16/20] audio: create pcspk device early Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 17/20] audio: deprecate -soundhw pcspk Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 18/20] audio: add soundhw deprecation notice Gerd Hoffmann
2020-06-24 12:24 ` Eric Blake
2020-06-24 11:30 ` [PATCH v4 19/20] pcspk: update docs/system/target-i386-desc.rst.inc Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 20/20] audio: set default value for pcspk.iobase property Gerd Hoffmann
2020-06-24 12:26 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624113026.13343-13-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=hpoussin@reactos.org \
--cc=libvir-list@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).