qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	qemu-block@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [PULL 05/19] floppy: move cmos_get_fd_drive_type() from pc
Date: Wed, 24 Jun 2020 19:06:41 -0400	[thread overview]
Message-ID: <20200624230609.703104-6-mst@redhat.com> (raw)
In-Reply-To: <20200624230609.703104-1-mst@redhat.com>

From: Gerd Hoffmann <kraxel@redhat.com>

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: John Snow <jsnow@redhat.com>
Message-Id: <20200619091905.21676-6-kraxel@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/hw/block/fdc.h |  1 +
 include/hw/i386/pc.h   |  1 -
 hw/block/fdc.c         | 26 +++++++++++++++++++++++++-
 hw/i386/pc.c           | 25 -------------------------
 4 files changed, 26 insertions(+), 27 deletions(-)

diff --git a/include/hw/block/fdc.h b/include/hw/block/fdc.h
index 5d71cf9722..479cebc0a3 100644
--- a/include/hw/block/fdc.h
+++ b/include/hw/block/fdc.h
@@ -16,5 +16,6 @@ void sun4m_fdctrl_init(qemu_irq irq, hwaddr io_base,
                        DriveInfo **fds, qemu_irq *fdc_tc);
 
 FloppyDriveType isa_fdc_get_drive_type(ISADevice *fdc, int i);
+int cmos_get_fd_drive_type(FloppyDriveType fd0);
 
 #endif
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index e6135c34d6..dce1273c7d 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -178,7 +178,6 @@ typedef void (*cpu_set_smm_t)(int smm, void *arg);
 void pc_i8259_create(ISABus *isa_bus, qemu_irq *i8259_irqs);
 
 ISADevice *pc_find_fdc0(void);
-int cmos_get_fd_drive_type(FloppyDriveType fd0);
 
 /* port92.c */
 #define PORT92_A20_LINE "a20"
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index f1da83f08e..4f0921298b 100644
--- a/hw/block/fdc.c
+++ b/hw/block/fdc.c
@@ -32,7 +32,6 @@
 #include "qapi/error.h"
 #include "qemu/error-report.h"
 #include "qemu/timer.h"
-#include "hw/i386/pc.h"
 #include "hw/acpi/aml-build.h"
 #include "hw/irq.h"
 #include "hw/isa/isa.h"
@@ -2812,6 +2811,31 @@ static Aml *build_fdinfo_aml(int idx, FloppyDriveType type)
     return dev;
 }
 
+int cmos_get_fd_drive_type(FloppyDriveType fd0)
+{
+    int val;
+
+    switch (fd0) {
+    case FLOPPY_DRIVE_TYPE_144:
+        /* 1.44 Mb 3"5 drive */
+        val = 4;
+        break;
+    case FLOPPY_DRIVE_TYPE_288:
+        /* 2.88 Mb 3"5 drive */
+        val = 5;
+        break;
+    case FLOPPY_DRIVE_TYPE_120:
+        /* 1.2 Mb 5"5 drive */
+        val = 2;
+        break;
+    case FLOPPY_DRIVE_TYPE_NONE:
+    default:
+        val = 0;
+        break;
+    }
+    return val;
+}
+
 static void fdc_isa_build_aml(ISADevice *isadev, Aml *scope)
 {
     Aml *dev;
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index d103b8c0ab..e78e32b41b 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -386,31 +386,6 @@ static uint64_t ioportF0_read(void *opaque, hwaddr addr, unsigned size)
 
 #define REG_EQUIPMENT_BYTE          0x14
 
-int cmos_get_fd_drive_type(FloppyDriveType fd0)
-{
-    int val;
-
-    switch (fd0) {
-    case FLOPPY_DRIVE_TYPE_144:
-        /* 1.44 Mb 3"5 drive */
-        val = 4;
-        break;
-    case FLOPPY_DRIVE_TYPE_288:
-        /* 2.88 Mb 3"5 drive */
-        val = 5;
-        break;
-    case FLOPPY_DRIVE_TYPE_120:
-        /* 1.2 Mb 5"5 drive */
-        val = 2;
-        break;
-    case FLOPPY_DRIVE_TYPE_NONE:
-    default:
-        val = 0;
-        break;
-    }
-    return val;
-}
-
 static void cmos_init_hd(ISADevice *s, int type_ofs, int info_ofs,
                          int16_t cylinders, int8_t heads, int8_t sectors)
 {
-- 
MST



  parent reply	other threads:[~2020-06-24 23:11 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-24 23:06 [PULL 00/19] virtio,acpi,pci: fixes, cleanups, tools Michael S. Tsirkin
2020-06-24 23:06 ` [PULL 01/19] qtest: allow DSDT acpi table changes Michael S. Tsirkin
2020-06-24 23:06 ` [PULL 02/19] acpi: bios-tables-test: show more context on asl diffs Michael S. Tsirkin
2020-06-24 23:06 ` [PULL 03/19] acpi: move aml builder code for floppy device Michael S. Tsirkin
2020-06-24 23:06 ` [PULL 04/19] floppy: make isa_fdc_get_drive_max_chs static Michael S. Tsirkin
2020-06-24 23:06 ` Michael S. Tsirkin [this message]
2020-06-24 23:06 ` [PULL 06/19] acpi: move aml builder code for i8042 (kbd+mouse) device Michael S. Tsirkin
2020-06-24 23:06 ` [PULL 07/19] acpi: factor out fw_cfg_add_acpi_dsdt() Michael S. Tsirkin
2020-06-24 23:06 ` [PULL 08/19] acpi: simplify build_isa_devices_aml() Michael S. Tsirkin
2020-06-24 23:06 ` [PULL 09/19] acpi: drop serial/parallel enable bits from dsdt Michael S. Tsirkin
2020-06-24 23:06 ` [PULL 10/19] acpi: drop build_piix4_pm() Michael S. Tsirkin
2020-06-24 23:06 ` [PULL 11/19] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion Michael S. Tsirkin
2020-06-24 23:07 ` [PULL 12/19] tests/acpi: update expected data files Michael S. Tsirkin
2020-06-24 23:07 ` [PULL 13/19] acpi: Some build_tpm2() code reshape Michael S. Tsirkin
2020-06-24 23:07 ` [PULL 14/19] arm/acpi: Add the TPM2.0 device under the DSDT Michael S. Tsirkin
2020-06-24 23:07 ` [PULL 15/19] docs/specs/tpm: ACPI boot now supported for TPM/ARM Michael S. Tsirkin
2020-06-24 23:07 ` [PULL 16/19] Stop vhost-user sending uninitialized mmap_offsets Michael S. Tsirkin
2020-06-24 23:07 ` [PULL 17/19] Rename use_acpi_pci_hotplug to more appropriate use_acpi_hotplug_bridge Michael S. Tsirkin
2020-06-24 23:07 ` [PULL 18/19] tests/qtest/bios-tables: Only run the TPM test with CONFIG_TPM enabled Michael S. Tsirkin
2020-06-24 23:07 ` [PULL 19/19] tests: disassemble-asm.sh: generate AML in readable format Michael S. Tsirkin
2020-06-25  5:47 ` [PULL 00/19] virtio,acpi,pci: fixes, cleanups, tools Thomas Huth
2020-06-25  6:49   ` Michael S. Tsirkin
2020-06-25 20:20 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200624230609.703104-6-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).