From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1358C433E0 for ; Thu, 25 Jun 2020 14:57:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B79A20768 for ; Thu, 25 Jun 2020 14:57:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HXfasXBW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B79A20768 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joTJH-0005sO-RJ for qemu-devel@archiver.kernel.org; Thu, 25 Jun 2020 10:57:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joTId-0005R0-6O for qemu-devel@nongnu.org; Thu, 25 Jun 2020 10:56:23 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:46097 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1joTIa-0005sc-8v for qemu-devel@nongnu.org; Thu, 25 Jun 2020 10:56:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593096978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NpVYsVp54IYPL7Q5cgwDThdfoB5aAUfapVAenaI2aGM=; b=HXfasXBWTB1vtw5NZ4IwAdLNuSjxNFWBV0ZTa5Dd9vij6ZiOW6jYHYbdXSP9EU0NQGRuvj VjlK6+Z0UB09kfvoCkptzfeoOVdomk1LVmwpZcOYRV+ZFKMVqwpuXLAZKqSSnXatZFZmYl fzZNh1LnZ/2/ZCbFzWzUC7nJyVPxH9k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-102-3md7RiSXMYqVJ3JEwc0VgQ-1; Thu, 25 Jun 2020 10:56:13 -0400 X-MC-Unique: 3md7RiSXMYqVJ3JEwc0VgQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3B6A2804001; Thu, 25 Jun 2020 14:56:11 +0000 (UTC) Received: from w520.home (ovpn-112-156.phx2.redhat.com [10.3.112.156]) by smtp.corp.redhat.com (Postfix) with ESMTP id 977325DAA0; Thu, 25 Jun 2020 14:56:00 +0000 (UTC) Date: Thu, 25 Jun 2020 08:56:00 -0600 From: Alex Williamson To: Kirti Wankhede Subject: Re: [PATCH QEMU v25 11/17] vfio: Get migration capability flags for container Message-ID: <20200625085600.2ae8981b@w520.home> In-Reply-To: <7d45d104-4cea-ff5f-d0c1-f4db9ec05486@nvidia.com> References: <1592684486-18511-1-git-send-email-kwankhede@nvidia.com> <1592684486-18511-12-git-send-email-kwankhede@nvidia.com> <20200624125508.5222135e@x1.home> <7d45d104-4cea-ff5f-d0c1-f4db9ec05486@nvidia.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=alex.williamson@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=alex.williamson@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/25 00:45:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cohuck@redhat.com, cjia@nvidia.com, aik@ozlabs.ru, Zhengxiao.zx@Alibaba-inc.com, shuangtai.tst@alibaba-inc.com, qemu-devel@nongnu.org, peterx@redhat.com, eauger@redhat.com, yi.l.liu@intel.com, quintela@redhat.com, ziye.yang@intel.com, armbru@redhat.com, mlevitsk@redhat.com, pasic@linux.ibm.com, felipe@nutanix.com, zhi.a.wang@intel.com, kevin.tian@intel.com, yan.y.zhao@intel.com, dgilbert@redhat.com, Eric Auger , changpeng.liu@intel.com, eskultet@redhat.com, Shameer Kolothum , Ken.Xue@amd.com, jonathan.davies@nutanix.com, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 25 Jun 2020 19:39:08 +0530 Kirti Wankhede wrote: > On 6/25/2020 12:25 AM, Alex Williamson wrote: > > On Sun, 21 Jun 2020 01:51:20 +0530 > > Kirti Wankhede wrote: > > > >> Added helper functions to get IOMMU info capability chain. > >> Added function to get migration capability information from that > >> capability chain for IOMMU container. > >> > >> Similar change was proposed earlier: > >> https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg03759.html > >> > >> Signed-off-by: Kirti Wankhede > >> Cc: Shameer Kolothum > >> Cc: Eric Auger > >> --- > >> hw/vfio/common.c | 91 +++++++++++++++++++++++++++++++++++++++---- > >> include/hw/vfio/vfio-common.h | 3 ++ > >> 2 files changed, 86 insertions(+), 8 deletions(-) > >> > >> diff --git a/hw/vfio/common.c b/hw/vfio/common.c > >> index 90e9a854d82c..e0d3d4585a65 100644 > >> --- a/hw/vfio/common.c > >> +++ b/hw/vfio/common.c > >> @@ -1229,6 +1229,75 @@ static int vfio_init_container(VFIOContainer *container, int group_fd, > >> return 0; > >> } > >> > >> +static int vfio_get_iommu_info(VFIOContainer *container, > >> + struct vfio_iommu_type1_info **info) > >> +{ > >> + > >> + size_t argsz = sizeof(struct vfio_iommu_type1_info); > >> + > >> + *info = g_new0(struct vfio_iommu_type1_info, 1); > >> +again: > >> + (*info)->argsz = argsz; > >> + > >> + if (ioctl(container->fd, VFIO_IOMMU_GET_INFO, *info)) { > >> + g_free(*info); > >> + *info = NULL; > >> + return -errno; > >> + } > >> + > >> + if (((*info)->argsz > argsz)) { > >> + argsz = (*info)->argsz; > >> + *info = g_realloc(*info, argsz); > >> + goto again; > >> + } > >> + > >> + return 0; > >> +} > >> + > >> +static struct vfio_info_cap_header * > >> +vfio_get_iommu_info_cap(struct vfio_iommu_type1_info *info, uint16_t id) > >> +{ > >> + struct vfio_info_cap_header *hdr; > >> + void *ptr = info; > >> + > >> + if (!(info->flags & VFIO_IOMMU_INFO_CAPS)) { > >> + return NULL; > >> + } > >> + > >> + for (hdr = ptr + info->cap_offset; hdr != ptr; hdr = ptr + hdr->next) { > >> + if (hdr->id == id) { > >> + return hdr; > >> + } > >> + } > >> + > >> + return NULL; > >> +} > >> + > >> +static void vfio_get_iommu_info_migration(VFIOContainer *container, > >> + struct vfio_iommu_type1_info *info) > >> +{ > >> + struct vfio_info_cap_header *hdr; > >> + struct vfio_iommu_type1_info_cap_migration *cap_mig; > >> + > >> + hdr = vfio_get_iommu_info_cap(info, VFIO_IOMMU_TYPE1_INFO_CAP_MIGRATION); > >> + if (!hdr) { > >> + return; > >> + } > >> + > >> + cap_mig = container_of(hdr, struct vfio_iommu_type1_info_cap_migration, > >> + header); > >> + > >> + container->dirty_pages_supported = true; > >> + container->max_dirty_bitmap_size = cap_mig->max_dirty_bitmap_size; > >> + container->dirty_pgsizes = cap_mig->pgsize_bitmap; > >> + > >> + /* > >> + * cpu_physical_memory_set_dirty_lebitmap() expects pages in bitmap of > >> + * TARGET_PAGE_SIZE to mark those dirty. > >> + */ > >> + assert(container->dirty_pgsizes & TARGET_PAGE_SIZE); > > > > Why assert versus simply not support dirty page tracking and therefore > > migration of contained devices? > > > > Ok, that can be done. > > >> +} > >> + > >> static int vfio_connect_container(VFIOGroup *group, AddressSpace *as, > >> Error **errp) > >> { > >> @@ -1293,6 +1362,7 @@ static int vfio_connect_container(VFIOGroup *group, AddressSpace *as, > >> container->space = space; > >> container->fd = fd; > >> container->error = NULL; > >> + container->dirty_pages_supported = false; > >> QLIST_INIT(&container->giommu_list); > >> QLIST_INIT(&container->hostwin_list); > >> > >> @@ -1305,7 +1375,7 @@ static int vfio_connect_container(VFIOGroup *group, AddressSpace *as, > >> case VFIO_TYPE1v2_IOMMU: > >> case VFIO_TYPE1_IOMMU: > >> { > >> - struct vfio_iommu_type1_info info; > >> + struct vfio_iommu_type1_info *info; > >> > >> /* > >> * FIXME: This assumes that a Type1 IOMMU can map any 64-bit > >> @@ -1314,15 +1384,20 @@ static int vfio_connect_container(VFIOGroup *group, AddressSpace *as, > >> * existing Type1 IOMMUs generally support any IOVA we're > >> * going to actually try in practice. > >> */ > >> - info.argsz = sizeof(info); > >> - ret = ioctl(fd, VFIO_IOMMU_GET_INFO, &info); > >> - /* Ignore errors */ > >> - if (ret || !(info.flags & VFIO_IOMMU_INFO_PGSIZES)) { > >> + ret = vfio_get_iommu_info(container, &info); > >> + if (ret) { > >> + goto free_container_exit; > > > > This was previously not fatal, why is it now? Thanks, > > > > Cornelia asked same question. > Then what should be the action if ioctl fails? Disable migration? Yes, new features shouldn't impose constraints not previously present. Thanks, Alex > >> + } > >> + > >> + if (!(info->flags & VFIO_IOMMU_INFO_PGSIZES)) { > >> /* Assume 4k IOVA page size */ > >> - info.iova_pgsizes = 4096; > >> + info->iova_pgsizes = 4096; > >> } > >> - vfio_host_win_add(container, 0, (hwaddr)-1, info.iova_pgsizes); > >> - container->pgsizes = info.iova_pgsizes; > >> + vfio_host_win_add(container, 0, (hwaddr)-1, info->iova_pgsizes); > >> + container->pgsizes = info->iova_pgsizes; > >> + > >> + vfio_get_iommu_info_migration(container, info); > >> + g_free(info); > >> break; > >> } > >> case VFIO_SPAPR_TCE_v2_IOMMU: > >> diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h > >> index c78033e4149d..5a57a78ec517 100644 > >> --- a/include/hw/vfio/vfio-common.h > >> +++ b/include/hw/vfio/vfio-common.h > >> @@ -79,6 +79,9 @@ typedef struct VFIOContainer { > >> unsigned iommu_type; > >> Error *error; > >> bool initialized; > >> + bool dirty_pages_supported; > >> + uint64_t dirty_pgsizes; > >> + uint64_t max_dirty_bitmap_size; > >> unsigned long pgsizes; > >> QLIST_HEAD(, VFIOGuestIOMMU) giommu_list; > >> QLIST_HEAD(, VFIOHostDMAWindow) hostwin_list; > > >