From: Marc Hartmayer <mhartmay@linux.ibm.com>
To: <qemu-devel@nongnu.org>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [RFC 2/4] libvhost-user: print invalid address on vu_panic
Date: Thu, 25 Jun 2020 12:04:28 +0200 [thread overview]
Message-ID: <20200625100430.22407-3-mhartmay@linux.ibm.com> (raw)
In-Reply-To: <20200625100430.22407-1-mhartmay@linux.ibm.com>
This can be helpful for debugging.
Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
---
contrib/libvhost-user/libvhost-user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c
index d315db139606..9e8750a9dabc 100644
--- a/contrib/libvhost-user/libvhost-user.c
+++ b/contrib/libvhost-user/libvhost-user.c
@@ -2432,7 +2432,7 @@ virtqueue_map_desc(VuDev *dev,
iov[num_sg].iov_base = vu_gpa_to_va(dev, &len, pa);
if (iov[num_sg].iov_base == NULL) {
- vu_panic(dev, "virtio: invalid address for buffers");
+ vu_panic(dev, "virtio: invalid address 0x%lx for buffers", pa);
return;
}
iov[num_sg].iov_len = len;
--
2.25.4
next prev parent reply other threads:[~2020-06-25 10:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 10:04 [RFC 0/4] Enable virtio-fs on s390x Marc Hartmayer
2020-06-25 10:04 ` [RFC 1/4] virtio: add vhost-user-fs-ccw device Marc Hartmayer
2020-06-25 10:50 ` Cornelia Huck
2020-06-25 10:04 ` Marc Hartmayer [this message]
2020-06-25 10:04 ` [RFC 3/4] libvhost-user: handle endianness as mandated by the spec Marc Hartmayer
2020-06-25 10:04 ` [RFC 4/4] HACK: Hard-code the libvhost-user.o-cflags for s390x Marc Hartmayer
2020-06-25 10:13 ` [RFC 0/4] Enable virtio-fs on s390x no-reply
2020-06-25 10:16 ` no-reply
2020-06-25 10:17 ` Cornelia Huck
2020-06-25 12:13 ` Halil Pasic
2020-06-25 10:19 ` Daniel P. Berrangé
2020-06-25 10:31 ` Cornelia Huck
2020-06-25 10:39 ` Daniel P. Berrangé
2020-06-25 10:46 ` Cornelia Huck
2020-06-25 11:07 ` Dr. David Alan Gilbert
2020-06-25 12:21 ` Halil Pasic
2020-06-29 12:53 ` Stefan Hajnoczi
2020-06-29 13:07 ` Daniel P. Berrangé
2020-06-30 9:04 ` Stefan Hajnoczi
2020-06-30 9:39 ` Cornelia Huck
2020-07-02 10:01 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625100430.22407-3-mhartmay@linux.ibm.com \
--to=mhartmay@linux.ibm.com \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).