From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Marc Hartmayer <mhartmay@linux.ibm.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
qemu-devel@nongnu.org, "Halil Pasic" <pasic@linux.ibm.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [RFC 0/4] Enable virtio-fs on s390x
Date: Thu, 25 Jun 2020 11:19:35 +0100 [thread overview]
Message-ID: <20200625101935.GF1009994@redhat.com> (raw)
In-Reply-To: <20200625100430.22407-1-mhartmay@linux.ibm.com>
On Thu, Jun 25, 2020 at 12:04:26PM +0200, Marc Hartmayer wrote:
> This RFC is about enabling virtio-fs on s390x. For that we need
> + some shim code (first patch), and we need
> + libvhost-user to deal with virtio endiannes as mandated by the spec.
>
> The second part is trickier, because unlike QEMU we are not certain
> about the guest's native endianness, which is needed to handle the
> legacy-interface appropriately. In fact, this is the reason why just
> RFC.
>
> One of the open questions is whether to build separate versions, one
> for guest little endian and one for guest big endian, or do we want
> something like a command line option? (Digression on the libvirt
> modeling)
When you talk about big vs little endian, are you referring to TCG
scenarios with mixed host/guest arch, or arches which can support
either endianess, or both ? i guess it doesn't matter actually, as
I think the latter forces a specific answer.
Considering that some architectures allow the guest OS to flip between
big & little endian as they boot, libvirt cannot know what endianess
the guest is using when it launches virtiofsd. It thus cannot pick
between two different endianness builds of virtiofsd automatically.
This would force the user to tell libvirt what arch the guest is using
at the time they define the guest. This is an undesirable restriction
for use cases where the admin of the guest OS has no direct control
over the host config.
IOW, I think the only practical answer is to have a single binary that
automagically does the right thing at runtime according to guest
endianess that currently is in use.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-06-25 10:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 10:04 [RFC 0/4] Enable virtio-fs on s390x Marc Hartmayer
2020-06-25 10:04 ` [RFC 1/4] virtio: add vhost-user-fs-ccw device Marc Hartmayer
2020-06-25 10:50 ` Cornelia Huck
2020-06-25 10:04 ` [RFC 2/4] libvhost-user: print invalid address on vu_panic Marc Hartmayer
2020-06-25 10:04 ` [RFC 3/4] libvhost-user: handle endianness as mandated by the spec Marc Hartmayer
2020-06-25 10:04 ` [RFC 4/4] HACK: Hard-code the libvhost-user.o-cflags for s390x Marc Hartmayer
2020-06-25 10:13 ` [RFC 0/4] Enable virtio-fs on s390x no-reply
2020-06-25 10:16 ` no-reply
2020-06-25 10:17 ` Cornelia Huck
2020-06-25 12:13 ` Halil Pasic
2020-06-25 10:19 ` Daniel P. Berrangé [this message]
2020-06-25 10:31 ` Cornelia Huck
2020-06-25 10:39 ` Daniel P. Berrangé
2020-06-25 10:46 ` Cornelia Huck
2020-06-25 11:07 ` Dr. David Alan Gilbert
2020-06-25 12:21 ` Halil Pasic
2020-06-29 12:53 ` Stefan Hajnoczi
2020-06-29 13:07 ` Daniel P. Berrangé
2020-06-30 9:04 ` Stefan Hajnoczi
2020-06-30 9:39 ` Cornelia Huck
2020-07-02 10:01 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625101935.GF1009994@redhat.com \
--to=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mhartmay@linux.ibm.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).