From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF6E3C433DF for ; Thu, 25 Jun 2020 11:27:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B35A20781 for ; Thu, 25 Jun 2020 11:27:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e4Wl0jKF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B35A20781 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joQ2s-0005RU-QT for qemu-devel@archiver.kernel.org; Thu, 25 Jun 2020 07:27:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joQ26-0004y1-RI for qemu-devel@nongnu.org; Thu, 25 Jun 2020 07:27:06 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:46668 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1joQ25-000410-1d for qemu-devel@nongnu.org; Thu, 25 Jun 2020 07:27:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593084424; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+8FPfBpZcvROy/vkFXTuu6KL9mEHY28xczEPjBxO61M=; b=e4Wl0jKF0tirlwII0BTSb9WmZdk90GAbo6RDHMvU4dGyG6nn58eJ19QhwPLO5Nr2Iqr6vm q4R6XW4BM3o9u9xStyQv1dg2mKj0l0Q/e3Yz7OWuEFYk+HDsRGYBDO5XDM679sSnYiNQ1V whIOxpyPxMg7gxtGtxHqX79K6l9mHsk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-203-lWY--I1QNkaFIO0Jn16PDw-1; Thu, 25 Jun 2020 07:27:02 -0400 X-MC-Unique: lWY--I1QNkaFIO0Jn16PDw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3D18E87951A; Thu, 25 Jun 2020 11:27:01 +0000 (UTC) Received: from redhat.com (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3F73C7FE8B; Thu, 25 Jun 2020 11:26:56 +0000 (UTC) Date: Thu, 25 Jun 2020 12:26:53 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Subject: Re: [PATCH RFC 0/3] gitlab: build containers to use in build jobs Message-ID: <20200625112653.GA1014704@redhat.com> References: <20200622153318.751107-1-berrange@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.14.0 (2020-05-02) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.120; envelope-from=berrange@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/25 01:47:53 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Alex =?utf-8?Q?Benn=C3=A9e?= , Laszlo Ersek , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jun 25, 2020 at 01:15:52PM +0200, Thomas Huth wrote: > On 22/06/2020 17.33, Daniel P. Berrangé wrote: > > The current gitlab CI jobs are quite inefficient because they > > use the generic distro images and then apt-get/dnf install > > extra packages every time. > > > > The other downside is that the container environment used is > > only defined in thte .gitlab-ci.yml file, so it tedious to > > reproduce locally. > > > > We already have containers defined in tests/docker for use by > > developers building locally. We can use these for CI systems > > too if we just had a way to build them.... > > > > ...GitLab CI offers such a way. We can use docker-in-docker > > to build the images at the start of the CI cycle, and use > > the built images in later jobs. > > > > These later jobs are now faster because they're not having > > to install any software. > > Did you see any speed-up? I had a look at some pipelines, and it seems to me > that they rather got slower now? For example, this is the system1 pipeline > before your change: > > https://gitlab.com/huth/qemu/-/jobs/610924897 > > and after your change: > > https://gitlab.com/huth/qemu/-/jobs/611069374 > > Duration went up from 35 minutes to 42 minutes. > > Seems also to happen in your builds, before the change: > > https://gitlab.com/berrange/qemu/-/jobs/582995084 > > and after the change: > > https://gitlab.com/berrange/qemu/-/jobs/606175927 > > ... went from 36 minutes up to 42 minutes. > > Could be a coincidence due to the load on the shared runners, but it looks > at least a little bit suspicious... I think the difference is because we're building more features now. The dockerfiles have provided more build pre-requisites that the old gitlab recipe did. If you compare the configure summary, I see the new build now covers SDL, curses, curl, pulseaudio, virtiofs, SASL, libjpeg, xen, docs and a few more. So we've saved time by not intsallling many packages each time, but consumed a greater amount of time by compiling more features. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|