From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29B1BC433E0 for ; Fri, 26 Jun 2020 17:21:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA9E720707 for ; Fri, 26 Jun 2020 17:21:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hLUUDbyL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA9E720707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jos2p-00060G-5S for qemu-devel@archiver.kernel.org; Fri, 26 Jun 2020 13:21:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jos1z-0005La-5b for qemu-devel@nongnu.org; Fri, 26 Jun 2020 13:20:51 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:50188 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jos1t-00057f-JA for qemu-devel@nongnu.org; Fri, 26 Jun 2020 13:20:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593192044; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=QuqGjggvsmfPwxe68Fb1bistREg++TFgtdlbLZ6NECg=; b=hLUUDbyLpOqMxGmsD/e3EKZ6PDZwLx3l7DbBTtceWenepjCeE5h1P0PozgoUyUJIMQ6WbV QUyU7KldLkGta7IIzTKipSph+qnUrQViYymYEw2r9sePCTsyBOgyttOlcVnXSorteIaeHe r3qCV30mZetYMUDfoQkZ+zXkwG3YeUc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-473-XBahe6BZMlCH9FP3yV4cwA-1; Fri, 26 Jun 2020 13:20:23 -0400 X-MC-Unique: XBahe6BZMlCH9FP3yV4cwA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 48695804003; Fri, 26 Jun 2020 17:20:22 +0000 (UTC) Received: from redhat.com (unknown [10.36.110.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D193517D68; Fri, 26 Jun 2020 17:20:06 +0000 (UTC) Date: Fri, 26 Jun 2020 18:20:03 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Christophe de Dinechin Subject: Re: [PATCH 04/10] spice: Move all the spice-related code in spice-app.so Message-ID: <20200626172003.GL1028934@redhat.com> References: <20200626164307.3327380-1-dinechin@redhat.com> <20200626164307.3327380-5-dinechin@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200626164307.3327380-5-dinechin@redhat.com> User-Agent: Mutt/1.14.0 (2020-05-02) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/26 03:23:21 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Eduardo Habkost , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, Michael Tokarev , qemu-devel@nongnu.org, Laurent Vivier , Paolo Bonzini , Gerd Hoffmann , Cleber Rosa , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , "Dr. David Alan Gilbert" , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jun 26, 2020 at 06:43:01PM +0200, Christophe de Dinechin wrote: > If we want to build spice as a separately loadable module, we need to > put all the spice code in one loadable module, because the build > system does not know how to deal with dependencies yet. > > Signed-off-by: Christophe de Dinechin > --- > audio/Makefile.objs | 2 +- > chardev/Makefile.objs | 3 +-- > ui/Makefile.objs | 8 ++++---- > 3 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/audio/Makefile.objs b/audio/Makefile.objs > index b4a4c11f31..298c895ff5 100644 > --- a/audio/Makefile.objs > +++ b/audio/Makefile.objs > @@ -1,5 +1,5 @@ > common-obj-y = audio.o audio_legacy.o noaudio.o wavaudio.o mixeng.o > -common-obj-$(CONFIG_SPICE) += spiceaudio.o > +spice-app.mo-objs += ../audio/spiceaudio.o Explicitly showing paths in the variables doesn't look right. The make recipes are supposed to automatically expand bare file names to add the right path. This is usually dealt with by a call to the "unnest-vars" function. > common-obj-$(CONFIG_AUDIO_COREAUDIO) += coreaudio.o > common-obj-$(CONFIG_AUDIO_DSOUND) += dsoundaudio.o > common-obj-$(CONFIG_AUDIO_WIN_INT) += audio_win_int.o > diff --git a/chardev/Makefile.objs b/chardev/Makefile.objs > index fc9910d4f2..955fac0cf9 100644 > --- a/chardev/Makefile.objs > +++ b/chardev/Makefile.objs > @@ -22,5 +22,4 @@ common-obj-$(CONFIG_BRLAPI) += baum.o > baum.o-cflags := $(SDL_CFLAGS) > baum.o-libs := $(BRLAPI_LIBS) > > -common-obj-$(CONFIG_SPICE) += spice.mo > -spice.mo-objs := spice.o > +spice-app.mo-objs += ../chardev/spice.o > diff --git a/ui/Makefile.objs b/ui/Makefile.objs > index 504b196479..1ab515e23d 100644 > --- a/ui/Makefile.objs > +++ b/ui/Makefile.objs > @@ -11,7 +11,6 @@ common-obj-y += keymaps.o console.o cursor.o qemu-pixman.o > common-obj-y += input.o input-keymap.o input-legacy.o kbd-state.o > common-obj-y += input-barrier.o > common-obj-$(CONFIG_LINUX) += input-linux.o > -common-obj-$(CONFIG_SPICE) += spice-core.o spice-input.o spice-display.o > common-obj-$(CONFIG_COCOA) += cocoa.o > common-obj-$(CONFIG_VNC) += $(vnc-obj-y) > common-obj-$(call lnot,$(CONFIG_VNC)) += vnc-stubs.o > @@ -53,10 +52,11 @@ curses.mo-objs := curses.o > curses.mo-cflags := $(CURSES_CFLAGS) $(ICONV_CFLAGS) > curses.mo-libs := $(CURSES_LIBS) $(ICONV_LIBS) > > -ifeq ($(CONFIG_GIO)$(CONFIG_SPICE),yy) > -common-obj-$(if $(CONFIG_MODULES),m,y) += spice-app.mo > +common-obj-$(CONFIG_SPICE) += spice-app.mo > +spice-app.mo-objs += spice-core.o spice-input.o spice-display.o > +ifeq ($(CONFIG_GIO)$(CONFIG_SPICE),ym) > +spice-app.mo-objs += spice-app.o > endif > -spice-app.mo-objs := spice-app.o > spice-app.mo-cflags := $(GIO_CFLAGS) > spice-app.mo-libs := $(GIO_LIBS) > > -- > 2.26.2 > > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|