From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE43BC433E0 for ; Mon, 29 Jun 2020 15:52:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 761F92545F for ; Mon, 29 Jun 2020 15:52:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GEJz0SVB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 761F92545F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpw4o-0005kt-No for qemu-devel@archiver.kernel.org; Mon, 29 Jun 2020 11:52:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpw3G-0004pr-QV for qemu-devel@nongnu.org; Mon, 29 Jun 2020 11:50:34 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:23675 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jpw3E-0006Jt-AE for qemu-devel@nongnu.org; Mon, 29 Jun 2020 11:50:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593445828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iQiE0LBbdQHcJ1gvvzOSnQtkHcAzYg8JytzJioj7lrw=; b=GEJz0SVBZgyOWwkykYyGGcFYI3wrvA2la4WqtjOB5G0rWSfXpWwVW5ltrZl6i0lCUw3JOa OwJOOkn+ZduuZNEY7WcN3IspQovyCsgKFNvDuSHek+DepyZHkMbC/0Rl/M7RvzFgiYPaBe K2bKMUPtlBajDPDY9PPP2wHiL2dsQdc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-113-bYJle3j2Oo-8lcJpExvkaQ-1; Mon, 29 Jun 2020 11:50:27 -0400 X-MC-Unique: bYJle3j2Oo-8lcJpExvkaQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D0F7E800C60; Mon, 29 Jun 2020 15:50:25 +0000 (UTC) Received: from gondolin (ovpn-113-61.ams2.redhat.com [10.36.113.61]) by smtp.corp.redhat.com (Postfix) with ESMTP id C871B60BF3; Mon, 29 Jun 2020 15:50:21 +0000 (UTC) Date: Mon, 29 Jun 2020 17:50:19 +0200 From: Cornelia Huck To: Janosch Frank Subject: Re: [PATCH v5 01/12] pc-bios: s390x: cio.c cleanup and compile fix Message-ID: <20200629175019.66d5d6e7.cohuck@redhat.com> In-Reply-To: <20200624075226.92728-2-frankja@linux.ibm.com> References: <20200624075226.92728-1-frankja@linux.ibm.com> <20200624075226.92728-2-frankja@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/29 01:03:51 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: borntraeger@de.ibm.com, thuth@redhat.com, qemu-devel@nongnu.org, david@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 24 Jun 2020 03:52:15 -0400 Janosch Frank wrote: > Let's initialize the structs at the beginning to ease reading and also > zeroing all other fields. This also makes the compiler stop > complaining about sense_id_ccw.flags being ored into when it's not > initialized. > > Signed-off-by: Janosch Frank > Reviewed-by: Pierre Morel > Reviewed-by: Thomas Huth > Reviewed-by: David Hildenbrand > Reviewed-by: Christian Borntraeger > --- > pc-bios/s390-ccw/cio.c | 40 ++++++++++++++++++++++------------------ > 1 file changed, 22 insertions(+), 18 deletions(-) Reviewed-by: Cornelia Huck