From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
qemu-block@nongnu.org, "Klaus Jensen" <k.jensen@samsung.com>,
"Maxim Levitsky" <mlevitsk@redhat.com>,
"Klaus Jensen" <its@irrelevant.dk>,
"Andrzej Jakowski" <andrzej.jakowski@linux.intel.com>,
"Keith Busch" <kbusch@kernel.org>,
"Max Reitz" <mreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v2 3/4] hw/block/nvme: Fix pmrmsc register size
Date: Tue, 30 Jun 2020 12:37:38 +0200 [thread overview]
Message-ID: <20200630103739.9715-4-philmd@redhat.com> (raw)
In-Reply-To: <20200630103739.9715-1-philmd@redhat.com>
The Persistent Memory Region Controller Memory Space Control
register is 64-bit wide. See 'Figure 68: Register Definition'
of the 'NVM Express Base Specification Revision 1.4'.
Fixes: 6cf9413229 ("introduce PMR support from NVMe 1.4 spec")
Reported-by: Klaus Jensen <its@irrelevant.dk>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Andrzej Jakowski <andrzej.jakowski@linux.intel.com>
Cc: Keith Busch <kbusch@kernel.org>
---
include/block/nvme.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/block/nvme.h b/include/block/nvme.h
index 71c5681912..82c384614a 100644
--- a/include/block/nvme.h
+++ b/include/block/nvme.h
@@ -21,7 +21,7 @@ typedef struct QEMU_PACKED NvmeBar {
uint32_t pmrsts;
uint32_t pmrebs;
uint32_t pmrswtp;
- uint32_t pmrmsc;
+ uint64_t pmrmsc;
} NvmeBar;
enum NvmeCapShift {
--
2.21.3
next prev parent reply other threads:[~2020-06-30 10:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 10:37 [PATCH v2 0/4] hw/block/nvme: Fix I/O BAR structure Philippe Mathieu-Daudé
2020-06-30 10:37 ` [PATCH v2 1/4] hw/block/nvme: Update specification URL Philippe Mathieu-Daudé
2020-06-30 10:47 ` Klaus Jensen
2020-06-30 10:37 ` [PATCH v2 2/4] hw/block/nvme: Use QEMU_PACKED on hardware/packet structures Philippe Mathieu-Daudé
2020-06-30 10:53 ` Klaus Jensen
2020-06-30 10:37 ` Philippe Mathieu-Daudé [this message]
2020-06-30 10:51 ` [PATCH v2 3/4] hw/block/nvme: Fix pmrmsc register size Klaus Jensen
2020-06-30 10:37 ` [PATCH v2 4/4] hw/block/nvme: Align I/O BAR to 4 KiB Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630103739.9715-4-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=andrzej.jakowski@linux.intel.com \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).