qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: P J P <ppandit@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Prasad J Pandit" <pjp@fedoraproject.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Li Qiang" <liq3ea@gmail.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Lei Sun" <slei.casper@gmail.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"David Gibson" <david@gibson.dropbear.id.au>
Subject: [PATCH v3 2/9] pci-host: add pcie-msi read method
Date: Tue, 30 Jun 2020 17:57:03 +0530	[thread overview]
Message-ID: <20200630122710.1119158-3-ppandit@redhat.com> (raw)
In-Reply-To: <20200630122710.1119158-1-ppandit@redhat.com>

From: Prasad J Pandit <pjp@fedoraproject.org>

Add pcie-msi mmio read method to avoid NULL pointer dereference
issue.

Reported-by: Lei Sun <slei.casper@gmail.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
 hw/pci-host/designware.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Update v3: Add Reviewed-by: ...
  -> https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg09400.html

diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c
index 8492c18991..82262bdfdf 100644
--- a/hw/pci-host/designware.c
+++ b/hw/pci-host/designware.c
@@ -21,6 +21,7 @@
 #include "qemu/osdep.h"
 #include "qapi/error.h"
 #include "qemu/module.h"
+#include "qemu/log.h"
 #include "hw/pci/msi.h"
 #include "hw/pci/pci_bridge.h"
 #include "hw/pci/pci_host.h"
@@ -63,6 +64,13 @@ designware_pcie_root_to_host(DesignwarePCIERoot *root)
     return DESIGNWARE_PCIE_HOST(bus->parent);
 }
 
+static uint64_t designware_pcie_root_msi_read(void *opaque, hwaddr addr,
+                                              unsigned size)
+{
+    qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__);
+    return 0;
+}
+
 static void designware_pcie_root_msi_write(void *opaque, hwaddr addr,
                                            uint64_t val, unsigned len)
 {
@@ -77,6 +85,7 @@ static void designware_pcie_root_msi_write(void *opaque, hwaddr addr,
 }
 
 static const MemoryRegionOps designware_pci_host_msi_ops = {
+    .read = designware_pcie_root_msi_read,
     .write = designware_pcie_root_msi_write,
     .endianness = DEVICE_LITTLE_ENDIAN,
     .valid = {
-- 
2.26.2



  parent reply	other threads:[~2020-06-30 12:31 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30 12:27 [PATCH v3 0/9] memory: assert and define MemoryRegionOps callbacks P J P
2020-06-30 12:27 ` [PATCH v3 1/9] hw/pci-host: add pci-intack write method P J P
2020-07-16 17:34   ` Peter Maydell
2020-06-30 12:27 ` P J P [this message]
2020-07-16 16:54   ` [PATCH v3 2/9] pci-host: add pcie-msi read method Peter Maydell
2020-06-30 12:27 ` [PATCH v3 3/9] vfio: add quirk device write method P J P
2020-07-16 17:46   ` Peter Maydell
2020-07-17 15:53     ` Alex Williamson
2020-07-17 15:57       ` Peter Maydell
2020-07-17 16:23         ` Alex Williamson
2020-06-30 12:27 ` [PATCH v3 4/9] prep: add ppc-parity " P J P
2020-06-30 12:27 ` [PATCH v3 5/9] nvram: add nrf51_soc flash read method P J P
2020-07-16 16:29   ` Peter Maydell
2020-06-30 12:27 ` [PATCH v3 6/9] spapr_pci: add spapr msi " P J P
2020-07-16 16:38   ` Peter Maydell
2020-06-30 12:27 ` [PATCH v3 7/9] tz-ppc: add dummy read/write methods P J P
2020-06-30 12:34   ` Philippe Mathieu-Daudé
2020-07-01  1:23   ` Li Qiang
2020-07-16 16:09   ` Peter Maydell
2020-06-30 12:27 ` [PATCH v3 8/9] imx7-ccm: add digprog mmio write method P J P
2020-07-16 16:21   ` Peter Maydell
2020-07-16 16:55     ` P J P
2020-07-16 16:56       ` Peter Maydell
2020-06-30 12:27 ` [PATCH v3 9/9] memory: assert MemoryRegionOps callbacks are defined P J P
2020-07-16 17:33   ` Peter Maydell
2020-06-30 13:46 ` [PATCH v3 0/9] memory: assert and define MemoryRegionOps callbacks no-reply
2020-07-13 18:58 ` P J P
2020-07-13 19:38   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200630122710.1119158-3-ppandit@redhat.com \
    --to=ppandit@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=alex.williamson@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=liq3ea@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=pjp@fedoraproject.org \
    --cc=qemu-devel@nongnu.org \
    --cc=slei.casper@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).