From: P J P <ppandit@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Prasad J Pandit" <pjp@fedoraproject.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Li Qiang" <liq3ea@gmail.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Lei Sun" <slei.casper@gmail.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: [PATCH v3 5/9] nvram: add nrf51_soc flash read method
Date: Tue, 30 Jun 2020 17:57:06 +0530 [thread overview]
Message-ID: <20200630122710.1119158-6-ppandit@redhat.com> (raw)
In-Reply-To: <20200630122710.1119158-1-ppandit@redhat.com>
From: Prasad J Pandit <pjp@fedoraproject.org>
Add nrf51_soc mmio read method to avoid NULL pointer dereference
issue.
Reported-by: Lei Sun <slei.casper@gmail.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
hw/nvram/nrf51_nvm.c | 5 +++++
1 file changed, 5 insertions(+)
Update v3: use g_assert_not_reached()
-> https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg09560.html
diff --git a/hw/nvram/nrf51_nvm.c b/hw/nvram/nrf51_nvm.c
index f2283c1a8d..82e89d965b 100644
--- a/hw/nvram/nrf51_nvm.c
+++ b/hw/nvram/nrf51_nvm.c
@@ -273,6 +273,10 @@ static const MemoryRegionOps io_ops = {
.endianness = DEVICE_LITTLE_ENDIAN,
};
+static uint64_t flash_read(void *opaque, hwaddr offset, unsigned size)
+{
+ g_assert_not_reached();
+}
static void flash_write(void *opaque, hwaddr offset, uint64_t value,
unsigned int size)
@@ -300,6 +304,7 @@ static void flash_write(void *opaque, hwaddr offset, uint64_t value,
static const MemoryRegionOps flash_ops = {
+ .read = flash_read,
.write = flash_write,
.valid.min_access_size = 4,
.valid.max_access_size = 4,
--
2.26.2
next prev parent reply other threads:[~2020-06-30 12:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 12:27 [PATCH v3 0/9] memory: assert and define MemoryRegionOps callbacks P J P
2020-06-30 12:27 ` [PATCH v3 1/9] hw/pci-host: add pci-intack write method P J P
2020-07-16 17:34 ` Peter Maydell
2020-06-30 12:27 ` [PATCH v3 2/9] pci-host: add pcie-msi read method P J P
2020-07-16 16:54 ` Peter Maydell
2020-06-30 12:27 ` [PATCH v3 3/9] vfio: add quirk device write method P J P
2020-07-16 17:46 ` Peter Maydell
2020-07-17 15:53 ` Alex Williamson
2020-07-17 15:57 ` Peter Maydell
2020-07-17 16:23 ` Alex Williamson
2020-06-30 12:27 ` [PATCH v3 4/9] prep: add ppc-parity " P J P
2020-06-30 12:27 ` P J P [this message]
2020-07-16 16:29 ` [PATCH v3 5/9] nvram: add nrf51_soc flash read method Peter Maydell
2020-06-30 12:27 ` [PATCH v3 6/9] spapr_pci: add spapr msi " P J P
2020-07-16 16:38 ` Peter Maydell
2020-06-30 12:27 ` [PATCH v3 7/9] tz-ppc: add dummy read/write methods P J P
2020-06-30 12:34 ` Philippe Mathieu-Daudé
2020-07-01 1:23 ` Li Qiang
2020-07-16 16:09 ` Peter Maydell
2020-06-30 12:27 ` [PATCH v3 8/9] imx7-ccm: add digprog mmio write method P J P
2020-07-16 16:21 ` Peter Maydell
2020-07-16 16:55 ` P J P
2020-07-16 16:56 ` Peter Maydell
2020-06-30 12:27 ` [PATCH v3 9/9] memory: assert MemoryRegionOps callbacks are defined P J P
2020-07-16 17:33 ` Peter Maydell
2020-06-30 13:46 ` [PATCH v3 0/9] memory: assert and define MemoryRegionOps callbacks no-reply
2020-07-13 18:58 ` P J P
2020-07-13 19:38 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630122710.1119158-6-ppandit@redhat.com \
--to=ppandit@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=liq3ea@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=pjp@fedoraproject.org \
--cc=qemu-devel@nongnu.org \
--cc=slei.casper@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).