From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-block@nongnu.org
Subject: [PATCH v7 03/17] hw/sd/sdcard: Move some definitions to use them earlier
Date: Tue, 30 Jun 2020 15:38:57 +0200 [thread overview]
Message-ID: <20200630133912.9428-4-f4bug@amsat.org> (raw)
In-Reply-To: <20200630133912.9428-1-f4bug@amsat.org>
Move some definitions to use them earlier.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/sd/sd.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index cac8d7d828..4816b4a462 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -80,6 +80,12 @@ enum SDCardStates {
sd_disconnect_state,
};
+#define HWBLOCK_SHIFT 9 /* 512 bytes */
+#define SECTOR_SHIFT 5 /* 16 kilobytes */
+#define WPGROUP_SHIFT 7 /* 2 megs */
+#define CMULT_SHIFT 9 /* 512 times HWBLOCK_SIZE */
+#define WPGROUP_SIZE (1 << (HWBLOCK_SHIFT + SECTOR_SHIFT + WPGROUP_SHIFT))
+
struct SDState {
DeviceState parent_obj;
@@ -367,12 +373,6 @@ static void sd_set_cid(SDState *sd)
sd->cid[15] = (sd_crc7(sd->cid, 15) << 1) | 1;
}
-#define HWBLOCK_SHIFT 9 /* 512 bytes */
-#define SECTOR_SHIFT 5 /* 16 kilobytes */
-#define WPGROUP_SHIFT 7 /* 2 megs */
-#define CMULT_SHIFT 9 /* 512 times HWBLOCK_SIZE */
-#define WPGROUP_SIZE (1 << (HWBLOCK_SHIFT + SECTOR_SHIFT + WPGROUP_SHIFT))
-
static const uint8_t sd_csd_rw_mask[16] = {
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xfc, 0xfe,
--
2.21.3
next prev parent reply other threads:[~2020-06-30 13:43 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 13:38 [PATCH v7 00/17] hw/sd/sdcard: Fix CVE-2020-13253 & cleanups Philippe Mathieu-Daudé
2020-06-30 13:38 ` [PATCH v7 01/17] MAINTAINERS: Cc qemu-block mailing list Philippe Mathieu-Daudé
2020-07-03 13:29 ` Peter Maydell
2020-06-30 13:38 ` [PATCH v7 02/17] hw/sd/sdcard: Update coding style to make checkpatch.pl happy Philippe Mathieu-Daudé
2020-07-06 16:24 ` Alistair Francis
2020-06-30 13:38 ` Philippe Mathieu-Daudé [this message]
2020-07-03 13:08 ` [PATCH v7 03/17] hw/sd/sdcard: Move some definitions to use them earlier Peter Maydell
2020-06-30 13:38 ` [PATCH v7 04/17] hw/sd/sdcard: Use the HWBLOCK_SIZE definition Philippe Mathieu-Daudé
2020-07-03 13:11 ` Peter Maydell
2020-06-30 13:38 ` [PATCH v7 05/17] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid Philippe Mathieu-Daudé
2020-07-03 13:12 ` Peter Maydell
2020-07-06 16:26 ` Alistair Francis
2020-07-07 8:30 ` Philippe Mathieu-Daudé
2020-07-07 10:24 ` Philippe Mathieu-Daudé
2020-07-07 10:34 ` Philippe Mathieu-Daudé
2020-06-30 13:39 ` [PATCH v7 06/17] hw/sd/sdcard: Restrict Class 6 commands to SCSD cards Philippe Mathieu-Daudé
2020-07-06 16:27 ` Alistair Francis
2020-06-30 13:39 ` [PATCH v7 07/17] hw/sd/sdcard: Move sd->size initialization Philippe Mathieu-Daudé
2020-07-03 13:13 ` Peter Maydell
2020-06-30 13:39 ` [PATCH v7 08/17] hw/sd/sdcard: Call sd_addr_to_wpnum where it is used, consider zero size Philippe Mathieu-Daudé
2020-07-03 13:15 ` Peter Maydell
2020-06-30 13:39 ` [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error Philippe Mathieu-Daudé
2020-07-03 13:23 ` Peter Maydell
2020-07-03 15:16 ` Philippe Mathieu-Daudé
2020-07-03 23:42 ` Philippe Mathieu-Daudé
2020-07-04 22:10 ` Philippe Mathieu-Daudé
2020-07-04 22:18 ` Philippe Mathieu-Daudé
2020-07-04 22:26 ` Philippe Mathieu-Daudé
2020-07-05 17:33 ` Philippe Mathieu-Daudé
2020-07-06 5:52 ` Markus Armbruster
2020-07-06 9:15 ` Peter Maydell
2020-06-30 13:39 ` [PATCH v7 10/17] hw/sd/sdcard: Check address is in range Philippe Mathieu-Daudé
2020-07-03 13:23 ` Peter Maydell
2020-06-30 13:39 ` [PATCH v7 11/17] hw/sd/sdcard: Update the SDState documentation Philippe Mathieu-Daudé
2020-07-06 16:28 ` Alistair Francis
2020-06-30 13:39 ` [PATCH v7 12/17] hw/sd/sdcard: Simplify cmd_valid_while_locked() Philippe Mathieu-Daudé
2020-07-06 16:30 ` Alistair Francis
2020-06-30 13:39 ` [PATCH v7 13/17] hw/sd/sdcard: Constify sd_crc*()'s message argument Philippe Mathieu-Daudé
2020-07-03 13:24 ` Peter Maydell
2020-06-30 13:39 ` [PATCH v7 14/17] hw/sd/sdcard: Make iolen unsigned Philippe Mathieu-Daudé
2020-07-03 13:25 ` Peter Maydell
2020-07-06 16:32 ` Alistair Francis
2020-06-30 13:39 ` [PATCH v7 15/17] hw/sd/sdcard: Correctly display the command name in trace events Philippe Mathieu-Daudé
2020-07-03 13:28 ` Peter Maydell
2020-07-03 15:09 ` Philippe Mathieu-Daudé
2020-06-30 13:39 ` [PATCH v7 16/17] hw/sd/sdcard: Display offset in read/write_data() " Philippe Mathieu-Daudé
2020-07-06 16:33 ` Alistair Francis
2020-06-30 13:39 ` [PATCH v7 17/17] hw/sd/sdcard: Simplify realize() a bit Philippe Mathieu-Daudé
2020-07-06 16:34 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630133912.9428-4-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).