From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: "Stefan Weil" <sw@weilnetz.de>,
"Jason Wang" <jasowang@redhat.com>,
qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v2 0/2] net: tap: check file descriptor can be used
Date: Tue, 30 Jun 2020 16:12:35 +0100 [thread overview]
Message-ID: <20200630151235.GW1370404@redhat.com> (raw)
In-Reply-To: <20200630145737.232095-1-lvivier@redhat.com>
On Tue, Jun 30, 2020 at 04:57:35PM +0200, Laurent Vivier wrote:
> v2: Add patch from Daniel to check the fd can be used
>
> I have updated Daniel's patch not to check for EINVAL on TUNGETIFF
> as I think we can avoid this special case because TUNGETIFF
> is available since kernel v2.6.27 (October 2008)
> Moreover I think the code was wrong as it was checking with -EINVAL and
> not EINVAL.
Agreed, given our documented OS platform targets, we don't need to
care about such old kernels.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2020-06-30 15:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 14:57 [PATCH v2 0/2] net: tap: check file descriptor can be used Laurent Vivier
2020-06-30 14:57 ` [PATCH v2 1/2] net: tap: check if the file descriptor is valid before using it Laurent Vivier
2020-06-30 15:04 ` Philippe Mathieu-Daudé
2020-06-30 16:06 ` Greg Kurz
2020-06-30 16:46 ` Laurent Vivier
2020-07-01 5:50 ` Markus Armbruster
2020-07-01 9:31 ` Laurent Vivier
2020-06-30 14:57 ` [PATCH v2 2/2] net: detect errors from probing vnet hdr flag for TAP devices Laurent Vivier
2020-06-30 15:12 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630151235.GW1370404@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).