From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D114EC433E0 for ; Tue, 30 Jun 2020 15:14:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E43120720 for ; Tue, 30 Jun 2020 15:14:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KH3Q3JsP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E43120720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqHxS-0000q1-Tp for qemu-devel@archiver.kernel.org; Tue, 30 Jun 2020 11:14:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jqHwO-00080l-No for qemu-devel@nongnu.org; Tue, 30 Jun 2020 11:12:57 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:22083 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jqHwM-0006tJ-O9 for qemu-devel@nongnu.org; Tue, 30 Jun 2020 11:12:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593529974; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=W38OahiTSzKDxC1jGoXj7Qc8jPq4z8MGj1sB2lfES8s=; b=KH3Q3JsPkUOk/ONlDmCQxM/mXn/9F58x9OwBryeje9v8FcsyTpDNVIy6kMdgwjMasUppGA XdyBwLqVlVD6g5p2XlKecvmf0siEcJj0POt9nEz6enYksDxjjgmFgHeJo9SdP1myV8tLhY 8YyD1iX2nG+stunf9zd85f6kMQ+O8ww= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-134-fQgzudTrPfmloEwPYIZJXA-1; Tue, 30 Jun 2020 11:12:45 -0400 X-MC-Unique: fQgzudTrPfmloEwPYIZJXA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BF7801800D42; Tue, 30 Jun 2020 15:12:44 +0000 (UTC) Received: from redhat.com (unknown [10.36.110.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 58A5C7166E; Tue, 30 Jun 2020 15:12:39 +0000 (UTC) Date: Tue, 30 Jun 2020 16:12:35 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Laurent Vivier Subject: Re: [PATCH v2 0/2] net: tap: check file descriptor can be used Message-ID: <20200630151235.GW1370404@redhat.com> References: <20200630145737.232095-1-lvivier@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200630145737.232095-1-lvivier@redhat.com> User-Agent: Mutt/1.14.3 (2020-06-14) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.120; envelope-from=berrange@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/30 03:55:26 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Stefan Weil , Jason Wang , qemu-devel@nongnu.org, Markus Armbruster , Gerd Hoffmann , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jun 30, 2020 at 04:57:35PM +0200, Laurent Vivier wrote: > v2: Add patch from Daniel to check the fd can be used > > I have updated Daniel's patch not to check for EINVAL on TUNGETIFF > as I think we can avoid this special case because TUNGETIFF > is available since kernel v2.6.27 (October 2008) > Moreover I think the code was wrong as it was checking with -EINVAL and > not EINVAL. Agreed, given our documented OS platform targets, we don't need to care about such old kernels. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|