From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
Janosch Frank <frankja@linux.ibm.com>
Subject: Re: [PATCH] pc-bios/s390-ccw: Generate and include dependency files in the Makefile
Date: Wed, 1 Jul 2020 12:53:01 +0200 [thread overview]
Message-ID: <20200701125301.1498351f.cohuck@redhat.com> (raw)
In-Reply-To: <20200630142955.7662-1-thuth@redhat.com>
On Tue, 30 Jun 2020 16:29:55 +0200
Thomas Huth <thuth@redhat.com> wrote:
> The Makefile of the s390-ccw bios does not handle dependencies of the
> *.c files from the headers yet, so that you often have to run a "make
> clean" to get the build right when one of the headers has been changed.
> Let's make sure that we generate and include dependency files for all
> *.c files now to avoid this problem in the future.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> pc-bios/s390-ccw/Makefile | 3 +++
> pc-bios/s390-ccw/netboot.mak | 13 +++++++------
> 2 files changed, 10 insertions(+), 6 deletions(-)
My Makefile-fu is not that strong, but this looks sane to me.
Acked-by: Cornelia Huck <cohuck@redhat.com>
[I can also pick this directly, if you do not plan to send me a bios
pull req.]
prev parent reply other threads:[~2020-07-01 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 14:29 [PATCH] pc-bios/s390-ccw: Generate and include dependency files in the Makefile Thomas Huth
2020-07-01 10:53 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701125301.1498351f.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).