From: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
To: qemu-devel@nongnu.org
Cc: aleksandar.rikalo@syrmia.com,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Subject: [PATCH v3 1/2] target/mips: Remove identical if/else branches
Date: Wed, 1 Jul 2020 20:25:57 +0200 [thread overview]
Message-ID: <20200701182559.28841-2-aleksandar.qemu.devel@gmail.com> (raw)
In-Reply-To: <20200701182559.28841-1-aleksandar.qemu.devel@gmail.com>
Remove the segment:
if (other_tc == other->current_tc) {
tccause = other->CP0_Cause;
} else {
tccause = other->CP0_Cause;
}
Original contributor can't remember what was his intention.
Fixes: 5a25ce9487 ("mips: Hook in more reg accesses via mttr/mftr")
Buglink: https://bugs.launchpad.net/qemu/+bug/1885718
Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
---
target/mips/cp0_helper.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/target/mips/cp0_helper.c b/target/mips/cp0_helper.c
index bbf12e4a97..de64add038 100644
--- a/target/mips/cp0_helper.c
+++ b/target/mips/cp0_helper.c
@@ -375,16 +375,9 @@ target_ulong helper_mftc0_entryhi(CPUMIPSState *env)
target_ulong helper_mftc0_cause(CPUMIPSState *env)
{
int other_tc = env->CP0_VPEControl & (0xff << CP0VPECo_TargTC);
- int32_t tccause;
CPUMIPSState *other = mips_cpu_map_tc(env, &other_tc);
- if (other_tc == other->current_tc) {
- tccause = other->CP0_Cause;
- } else {
- tccause = other->CP0_Cause;
- }
-
- return tccause;
+ return other->CP0_Cause;
}
target_ulong helper_mftc0_status(CPUMIPSState *env)
--
2.20.1
next prev parent reply other threads:[~2020-07-01 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 18:25 [PATCH v3 0/2] target mips: Misc fixes and improvements Aleksandar Markovic
2020-07-01 18:25 ` Aleksandar Markovic [this message]
2020-07-01 18:25 ` [PATCH v3 2/2] MAINTAINERS: Adjust MIPS maintainership Aleksandar Markovic
2020-07-01 18:43 ` Paul Burton
2020-07-01 19:09 ` Aleksandar Markovic
2020-07-01 18:55 ` Aurelien Jarno
2020-07-01 19:13 ` Aleksandar Markovic
2020-07-02 5:09 ` Aurelien Jarno
2020-07-02 9:25 ` Paolo Bonzini
2020-07-02 12:39 ` [PATCH v3 0/2] target mips: Misc fixes and improvements Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701182559.28841-2-aleksandar.qemu.devel@gmail.com \
--to=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).