From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CD09C433E0 for ; Thu, 2 Jul 2020 13:14:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC5E2207CD for ; Thu, 2 Jul 2020 13:14:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M3qPhlg8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC5E2207CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqz2k-0005Z9-1a for qemu-devel@archiver.kernel.org; Thu, 02 Jul 2020 09:14:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jqz1K-0004Ir-Mz for qemu-devel@nongnu.org; Thu, 02 Jul 2020 09:12:54 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:23247 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jqz1I-0007NW-Tl for qemu-devel@nongnu.org; Thu, 02 Jul 2020 09:12:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593695571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wtoZB/DrdHCTwgcGC7eYMqB3u+s8DLGCkVcpAP9QXiU=; b=M3qPhlg8PfuKmcTo9QA5M/4iOyW6/LWhC+bcyjBlqMFwex8TfxQu4ztaTfUEb4xYLiM5Mv le+Gmzip9CqYFL1bDCiJcUkIDeBJcTTKg0rl1tZYdmkVacpJNWCmCUOS3MGk01r9ckGWhF ulEvOMXd+v4EcV1Pqdl0t3TZXMq2NzM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-439-LcMCOW_WMT6sIv_zLnKclA-1; Thu, 02 Jul 2020 09:12:49 -0400 X-MC-Unique: LcMCOW_WMT6sIv_zLnKclA-1 Received: by mail-wr1-f71.google.com with SMTP id h28so25670220wrc.18 for ; Thu, 02 Jul 2020 06:12:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wtoZB/DrdHCTwgcGC7eYMqB3u+s8DLGCkVcpAP9QXiU=; b=ZyEF+fSaUkOpYVGpQTpUwyTJEa620CRxb58aQrJhjV3NuLGpRH5mLzh6SXNcIYLN6e XnFt698OHhuwj3Xhe8mF4/D8DaNHg7/EjKSMJyQBVmI/lnEzy7xf0pDaJbFzsWqqZd6+ 6jl9cEtnLfjO+BT6gVoiVyEuznkplapth5itQNdipnWob2Yxx5KHhKIREM4mGILhlHKC q1ydFrLRzUNeIVEaR2Lt1sBccp2ApeGA+xUABV/MsfZvK82n78vBb1kkyCAkNkbxvWQW qe+vMsZnx27u4h2gv/N+NTtb0olp95aBIVaL16e5mQdSh6ALXW5Jbirjp1apgyzB8NfP jSoQ== X-Gm-Message-State: AOAM533/6pQJXJQD+ibVZ33MLw6OL09gLD09EwxToi/ce0sWWMzcTSbb Ngv6pyiFiWDfNHT3phXOFj5Pw71H1g6gjckFWZBtn1VyGmqYGV/BuS0gCMMhq/TfKjxGqT1rR4G ZhugZPZH8or0cDl4= X-Received: by 2002:a5d:40ca:: with SMTP id b10mr34077484wrq.56.1593695567920; Thu, 02 Jul 2020 06:12:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyi1Ao0kwBf67yAs3GDLxHd/S5DUvjOXuouTqyf1R8ICwfyIeV2LAFSAZMG0TxDpfUxFe+biA== X-Received: by 2002:a5d:40ca:: with SMTP id b10mr34077465wrq.56.1593695567699; Thu, 02 Jul 2020 06:12:47 -0700 (PDT) Received: from redhat.com (bzq-79-182-31-92.red.bezeqint.net. [79.182.31.92]) by smtp.gmail.com with ESMTPSA id x7sm10933520wrr.72.2020.07.02.06.12.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 06:12:46 -0700 (PDT) Date: Thu, 2 Jul 2020 09:12:43 -0400 From: "Michael S. Tsirkin" To: Auger Eric Subject: Re: [PATCH v7 0/5] VIRTIO-IOMMU probe request support and MSI bypass on ARM Message-ID: <20200702091222-mutt-send-email-mst@kernel.org> References: <20200629070404.10969-1-eric.auger@redhat.com> <20200702072655-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=mst@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/02 04:18:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, jean-philippe@linaro.org, armbru@redhat.com, peterx@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, pbonzini@redhat.com, bbhushan2@marvell.com, eric.auger.pro@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jul 02, 2020 at 02:01:46PM +0200, Auger Eric wrote: > Hi Michael, > > On 7/2/20 1:28 PM, Michael S. Tsirkin wrote: > > On Mon, Jun 29, 2020 at 09:03:59AM +0200, Eric Auger wrote: > >> By default the virtio-iommu translates MSI transactions. This > >> behavior is inherited from ARM SMMU. However the virt machine > >> code knows where the MSI doorbells are, so we can easily > >> declare those regions as VIRTIO_IOMMU_RESV_MEM_T_MSI. With that > >> setting the guest iommu subsystem will not need to map MSIs. > >> This setup will simplify the VFIO integration. > >> > >> In this series, the ITS or GICV2M doorbells are declared as > >> HW MSI regions to be bypassed by the VIRTIO-IOMMU. > >> > >> This also paves the way to the x86 integration where the MSI > >> region, [0xFEE00000,0xFEEFFFFF], will be exposed by the q35 > >> machine. However this will be handled in a separate series > >> when not-DT support gets resolved. > > > > > > virtio things: > > > > Reviewed-by: Michael S. Tsirkin > > > > > > ARM tree makes sense for this, right? > > Yes I think so. > > Thanks > > Eric Okay. Feel free to merge through ARM tree pls. Reviewed-by: Michael S. Tsirkin > > > > > >> Best Regards > >> > >> Eric > >> > >> This series can be found at: > >> https://github.com/eauger/qemu/tree/v5.0.0-virtio-iommu-msi-bypass-v7 > >> > >> History: > >> > >> v6 -> v7: > >> - fix the hint message > >> - put the assert again on probe request > >> > >> v5 -> v6: > >> - do not hardcode start/end addresses of doorbells > >> - check reserved region type on realize() > >> > >> v4 -> v5: > >> - Take into account some additional comments from Markus: > >> - reserved region type becomes an unsigned + some comment/desc > >> rewording > >> - assert if the type is not RESERVED or MSI > >> > >> v3 -> v4: > >> - collected Jean and markus's R-bs > >> - tool into account all Markus' comments in [1/5] (except removal of > >> goto) > >> - use ':' as delimitor instead of commas > >> - add example in 4/5 commit message as suggested by Markus > >> > >> v2 -> v3: > >> - Introduce VIRT_MSI_CTRL_NONE in VirtMSIControllerType > >> - do not fill the remainder of the probe buffer > >> > >> v1 -> v2: > >> - check which MSI controller is in use and advertise the > >> corresponding MSI doorbell > >> - managed for both ITS and GICv2M > >> - various fixes spotted by Peter and Jean-Philippe, see > >> individual logs > >> > >> v1: Most of those patches were respinned from > >> [PATCH for-5.0 v11 00/20] VIRTIO-IOMMU device > >> except the last one which is new > >> > >> > >> Eric Auger (5): > >> qdev: Introduce DEFINE_PROP_RESERVED_REGION > >> virtio-iommu: Implement RESV_MEM probe request > >> virtio-iommu: Handle reserved regions in the translation process > >> virtio-iommu-pci: Add array of Interval properties > >> hw/arm/virt: Let the virtio-iommu bypass MSIs > >> > >> include/exec/memory.h | 6 ++ > >> include/hw/arm/virt.h | 7 ++ > >> include/hw/qdev-properties.h | 3 + > >> include/hw/virtio/virtio-iommu.h | 2 + > >> include/qemu/typedefs.h | 1 + > >> hw/arm/virt.c | 30 ++++++++ > >> hw/core/qdev-properties.c | 89 ++++++++++++++++++++++++ > >> hw/virtio/virtio-iommu-pci.c | 11 +++ > >> hw/virtio/virtio-iommu.c | 114 +++++++++++++++++++++++++++++-- > >> hw/virtio/trace-events | 1 + > >> 10 files changed, 260 insertions(+), 4 deletions(-) > >> > >> -- > >> 2.20.1 > > > >