From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"P J P" <ppandit@redhat.com>, "Max Reitz" <mreitz@redhat.com>
Subject: [PATCH v2 0/3] block: improve error reporting for unsupported O_DIRECT
Date: Thu, 2 Jul 2020 13:56:09 +0100 [thread overview]
Message-ID: <20200702125612.2176194-1-berrange@redhat.com> (raw)
v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00269.html
See patch commit messages for rationale
Ideally we would convert other callers of qemu_open to use
qemu_open_err, and eventually remove qemu_open, renaming
qemu_open_err back to qemu_open. Given soft freeze is just
days away though, I'm hoping this series is simple enough
to get into this release, leaving bigger cleanup for later.
Improved in v2:
- Mention that qemu_open_err is preferred over qemu_open
- Get rid of obsolete error_report call
- Simplify O_DIRECT handling
- Fixup iotests for changed error message text
Daniel P. Berrangé (3):
util: validate whether O_DIRECT is supported after failure
util: support detailed error reporting for qemu_open
block: switch to use qemu_open_err for improved errors
block/file-posix.c | 10 ++---
include/qemu/osdep.h | 2 +
tests/qemu-iotests/051.out | 4 +-
tests/qemu-iotests/051.pc.out | 4 +-
tests/qemu-iotests/061.out | 2 +-
tests/qemu-iotests/069.out | 2 +-
tests/qemu-iotests/082.out | 4 +-
tests/qemu-iotests/111.out | 2 +-
tests/qemu-iotests/226.out | 6 +--
tests/qemu-iotests/232.out | 12 +++---
tests/qemu-iotests/244.out | 6 +--
util/osdep.c | 69 +++++++++++++++++++++++++++++------
12 files changed, 85 insertions(+), 38 deletions(-)
--
2.26.2
next reply other threads:[~2020-07-02 12:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 12:56 Daniel P. Berrangé [this message]
2020-07-02 12:56 ` [PATCH v2 1/3] util: validate whether O_DIRECT is supported after failure Daniel P. Berrangé
2020-07-02 15:29 ` Philippe Mathieu-Daudé
2020-07-08 6:45 ` Markus Armbruster
2020-07-02 12:56 ` [PATCH v2 2/3] util: support detailed error reporting for qemu_open Daniel P. Berrangé
2020-07-08 6:55 ` Markus Armbruster
2020-07-02 12:56 ` [PATCH v2 3/3] block: switch to use qemu_open_err for improved errors Daniel P. Berrangé
2020-07-08 6:57 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702125612.2176194-1-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=f4bug@amsat.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).