From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
libvir-list@redhat.com,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
qemu-ppc@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v5 14/20] softmmu: initialize spice and audio earlier
Date: Thu, 2 Jul 2020 15:25:19 +0200 [thread overview]
Message-ID: <20200702132525.6849-15-kraxel@redhat.com> (raw)
In-Reply-To: <20200702132525.6849-1-kraxel@redhat.com>
audiodev must be initialized before machine_set_property
so the machine can have audiodev property aliases.
spice must initialize before audiodev because the default
audiodev is spice only in case spice is actually enabled.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
softmmu/vl.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 3e15ee243572..8ee91219060a 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -4131,12 +4131,17 @@ void qemu_init(int argc, char **argv, char **envp)
fsdev_init_func, NULL, &error_fatal);
#endif
+ /* spice needs the timers to be initialized by this point */
+ /* spice must initialize before audio as it changes the default auiodev */
+ qemu_spice_init();
+
/*
- * Note: we need to create block backends before
+ * Note: we need to create audio and block backends before
* machine_set_property(), so machine properties can refer to
* them.
*/
configure_blockdev(&bdo_queue, machine_class, snapshot);
+ audio_init_audiodevs();
machine_opts = qemu_get_machine_opts();
qemu_opt_foreach(machine_opts, machine_set_property, current_machine,
@@ -4230,9 +4235,6 @@ void qemu_init(int argc, char **argv, char **envp)
semihosting_arg_fallback(kernel_filename, kernel_cmdline);
}
- /* spice needs the timers to be initialized by this point */
- qemu_spice_init();
-
cpu_ticks_init();
if (default_net) {
@@ -4342,8 +4344,6 @@ void qemu_init(int argc, char **argv, char **envp)
create_default_memdev(current_machine, mem_path);
}
- audio_init_audiodevs();
-
/* from here on runstate is RUN_STATE_PRELAUNCH */
machine_run_board_init(current_machine);
--
2.18.4
next prev parent reply other threads:[~2020-07-02 13:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 13:25 [PATCH v5 00/20] audio: deprecate -soundhw Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 01/20] stubs: add isa_create_simple Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 02/20] stubs: add pci_create_simple Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 03/20] audio: add deprecated_register_soundhw Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 04/20] audio: deprecate -soundhw ac97 Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 05/20] audio: deprecate -soundhw es1370 Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 06/20] audio: deprecate -soundhw adlib Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 07/20] audio: deprecate -soundhw cs4231a Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 08/20] audio: deprecate -soundhw gus Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 09/20] audio: deprecate -soundhw sb16 Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 10/20] audio: deprecate -soundhw hda Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 11/20] pc_basic_device_init: pass PCMachineState Gerd Hoffmann
2020-07-02 13:44 ` Philippe Mathieu-Daudé
2020-07-02 13:25 ` [PATCH v5 12/20] pc_basic_device_init: drop has_pit arg Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 13/20] pc_basic_device_init: drop no_vmport arg Gerd Hoffmann
2020-07-02 13:25 ` Gerd Hoffmann [this message]
2020-07-02 13:25 ` [PATCH v5 15/20] audio: rework pcspk_init() Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 16/20] audio: create pcspk device early Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 17/20] audio: deprecate -soundhw pcspk Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 18/20] audio: add soundhw deprecation notice Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 19/20] pcspk: update docs/system/target-i386-desc.rst.inc Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 20/20] audio: set default value for pcspk.iobase property Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702132525.6849-15-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=hpoussin@reactos.org \
--cc=libvir-list@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).