qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	libvir-list@redhat.com,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	qemu-ppc@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v5 16/20] audio: create pcspk device early
Date: Thu,  2 Jul 2020 15:25:21 +0200	[thread overview]
Message-ID: <20200702132525.6849-17-kraxel@redhat.com> (raw)
In-Reply-To: <20200702132525.6849-1-kraxel@redhat.com>

Create the pcspk device early, so it exists at
machine type initialization time.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 include/hw/i386/pc.h | 1 +
 hw/i386/pc.c         | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index d7690bf4290f..a802e699749a 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -33,6 +33,7 @@ struct PCMachineState {
     PCIBus *bus;
     I2CBus *smbus;
     PFlashCFI01 *flash[2];
+    ISADevice *pcspk;
 
     /* Configuration options: */
     uint64_t max_ram_below_4g;
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 4fc1b7048b28..88785f9dcc70 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1219,7 +1219,7 @@ void pc_basic_device_init(struct PCMachineState *pcms,
             /* connect PIT to output control line of the HPET */
             qdev_connect_gpio_out(hpet, 0, qdev_get_gpio_in(DEVICE(pit), 0));
         }
-        pcspk_init(isa_new(TYPE_PC_SPEAKER), isa_bus, pit);
+        pcspk_init(pcms->pcspk, isa_bus, pit);
     }
 
     i8257_dma_init(isa_bus, 0);
@@ -1891,6 +1891,7 @@ static void pc_machine_initfn(Object *obj)
     pcms->pit_enabled = true;
 
     pc_system_flash_create(pcms);
+    pcms->pcspk = isa_new(TYPE_PC_SPEAKER);
 }
 
 static void pc_machine_reset(MachineState *machine)
-- 
2.18.4



  parent reply	other threads:[~2020-07-02 13:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 13:25 [PATCH v5 00/20] audio: deprecate -soundhw Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 01/20] stubs: add isa_create_simple Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 02/20] stubs: add pci_create_simple Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 03/20] audio: add deprecated_register_soundhw Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 04/20] audio: deprecate -soundhw ac97 Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 05/20] audio: deprecate -soundhw es1370 Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 06/20] audio: deprecate -soundhw adlib Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 07/20] audio: deprecate -soundhw cs4231a Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 08/20] audio: deprecate -soundhw gus Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 09/20] audio: deprecate -soundhw sb16 Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 10/20] audio: deprecate -soundhw hda Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 11/20] pc_basic_device_init: pass PCMachineState Gerd Hoffmann
2020-07-02 13:44   ` Philippe Mathieu-Daudé
2020-07-02 13:25 ` [PATCH v5 12/20] pc_basic_device_init: drop has_pit arg Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 13/20] pc_basic_device_init: drop no_vmport arg Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 14/20] softmmu: initialize spice and audio earlier Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 15/20] audio: rework pcspk_init() Gerd Hoffmann
2020-07-02 13:25 ` Gerd Hoffmann [this message]
2020-07-02 13:25 ` [PATCH v5 17/20] audio: deprecate -soundhw pcspk Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 18/20] audio: add soundhw deprecation notice Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 19/20] pcspk: update docs/system/target-i386-desc.rst.inc Gerd Hoffmann
2020-07-02 13:25 ` [PATCH v5 20/20] audio: set default value for pcspk.iobase property Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200702132525.6849-17-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=libvir-list@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).