From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Krempa" <pkrempa@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org, "Juan Quintela" <quintela@redhat.com>,
qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Max Reitz" <mreitz@redhat.com>
Subject: Re: [PATCH 1/6] migration: improve error reporting of block driver state name
Date: Thu, 2 Jul 2020 20:13:21 +0100 [thread overview]
Message-ID: <20200702191321.GH14863@work-vm> (raw)
In-Reply-To: <353f3015-ac0b-9332-ba7b-327e30ac0bd2@redhat.com>
* Eric Blake (eblake@redhat.com) wrote:
> On 7/2/20 12:57 PM, Daniel P. Berrangé wrote:
> > With blockdev, a BlockDriverState may not have an device name,
>
> s/an/a/
>
> > so using a node name is required as an alternative.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> > migration/savevm.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Why don't you send this one to trivial.
Dave
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3226
> Virtualization: qemu.org | libvirt.org
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-07-02 19:14 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 17:57 [PATCH 0/6] migration: bring savevm/loadvm/delvm over to QMP Daniel P. Berrangé
2020-07-02 17:57 ` [PATCH 1/6] migration: improve error reporting of block driver state name Daniel P. Berrangé
2020-07-02 18:36 ` Eric Blake
2020-07-02 19:13 ` Dr. David Alan Gilbert [this message]
2020-07-02 17:57 ` [PATCH 2/6] migration: introduce savevm, loadvm, delvm QMP commands Daniel P. Berrangé
2020-07-02 18:12 ` Eric Blake
2020-07-02 18:24 ` Daniel P. Berrangé
2020-07-03 15:49 ` Dr. David Alan Gilbert
2020-07-03 16:02 ` Daniel P. Berrangé
2020-07-03 16:10 ` Dr. David Alan Gilbert
2020-07-03 16:16 ` Daniel P. Berrangé
2020-07-03 16:22 ` Dr. David Alan Gilbert
2020-07-03 16:49 ` Daniel P. Berrangé
2020-07-03 17:00 ` Dr. David Alan Gilbert
2020-07-03 17:10 ` Daniel P. Berrangé
2020-07-03 17:26 ` Dr. David Alan Gilbert
2020-07-03 16:24 ` Peter Krempa
2020-07-03 16:26 ` Dr. David Alan Gilbert
2020-07-06 16:15 ` Kevin Wolf
2020-07-07 6:38 ` Peter Krempa
2020-07-07 10:33 ` Kevin Wolf
2020-07-07 10:41 ` Peter Krempa
2020-07-03 17:22 ` Denis V. Lunev
2020-07-02 17:57 ` [PATCH 3/6] block: add ability to filter out blockdevs during snapshot Daniel P. Berrangé
2020-07-02 17:57 ` [PATCH 4/6] block: allow specifying name of block device for vmstate storage Daniel P. Berrangé
2020-07-02 17:57 ` [PATCH 5/6] migration: support excluding block devs in QMP snapshot commands Daniel P. Berrangé
2020-07-06 15:57 ` Kevin Wolf
2020-07-07 9:14 ` Daniel P. Berrangé
2020-07-07 10:11 ` Kevin Wolf
2020-07-02 17:57 ` [PATCH 6/6] migration: support picking vmstate disk " Daniel P. Berrangé
2020-07-02 18:19 ` Eric Blake
2020-07-03 8:37 ` Daniel P. Berrangé
2020-07-02 18:53 ` [PATCH 0/6] migration: bring savevm/loadvm/delvm over to QMP no-reply
2020-07-02 19:07 ` no-reply
2020-07-03 17:15 ` Denis V. Lunev
2020-07-03 17:22 ` Daniel P. Berrangé
2020-07-03 17:29 ` Denis V. Lunev
2020-07-06 14:28 ` Daniel P. Berrangé
2020-07-06 16:07 ` Denis V. Lunev
2020-07-06 15:27 ` Kevin Wolf
2020-07-06 15:29 ` Daniel P. Berrangé
2020-07-06 15:50 ` Kevin Wolf
2020-07-06 16:03 ` Daniel P. Berrangé
2020-07-06 16:10 ` Denis V. Lunev
2020-07-06 16:15 ` Daniel P. Berrangé
2020-07-06 16:21 ` Kevin Wolf
2020-07-07 9:07 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702191321.GH14863@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).