* [PATCH] virtio-net: fix removal of failover device
@ 2020-07-03 11:48 Juan Quintela
2020-07-03 11:59 ` Michael S. Tsirkin
0 siblings, 1 reply; 3+ messages in thread
From: Juan Quintela @ 2020-07-03 11:48 UTC (permalink / raw)
To: qemu-devel; +Cc: Jason Wang, Juan Quintela, Michael S. Tsirkin
If you have a networking device and its virtio failover device, and
you remove them in this order:
- virtio device
- the real device
You get qemu crash.
See bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1820120
Bug exist on qemu 4.2 and 5.0.
But in 5.0 don't shows because commit
77b06bba62034a87cc61a9c8de1309ae3e527d97
somehow papers over it.
CC: Jason Wang <jasowang@redhat.com>
CC: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
hw/net/virtio-net.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 9bb5578e5d..8d84713df3 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -3398,6 +3398,7 @@ static void virtio_net_device_unrealize(DeviceState *dev)
g_free(n->vlans);
if (n->failover) {
+ device_listener_unregister(&n->primary_listener);
g_free(n->primary_device_id);
g_free(n->standby_id);
qobject_unref(n->primary_device_dict);
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] virtio-net: fix removal of failover device
2020-07-03 11:48 [PATCH] virtio-net: fix removal of failover device Juan Quintela
@ 2020-07-03 11:59 ` Michael S. Tsirkin
2020-07-07 7:38 ` Jason Wang
0 siblings, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2020-07-03 11:59 UTC (permalink / raw)
To: Juan Quintela; +Cc: Jason Wang, qemu-devel
On Fri, Jul 03, 2020 at 01:48:13PM +0200, Juan Quintela wrote:
> If you have a networking device and its virtio failover device, and
> you remove them in this order:
> - virtio device
> - the real device
>
> You get qemu crash.
> See bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1820120
>
> Bug exist on qemu 4.2 and 5.0.
> But in 5.0 don't shows because commit
> 77b06bba62034a87cc61a9c8de1309ae3e527d97
>
> somehow papers over it.
>
> CC: Jason Wang <jasowang@redhat.com>
> CC: Michael S. Tsirkin <mst@redhat.com>
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Jason can you queue this pls?
> ---
> hw/net/virtio-net.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index 9bb5578e5d..8d84713df3 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -3398,6 +3398,7 @@ static void virtio_net_device_unrealize(DeviceState *dev)
> g_free(n->vlans);
>
> if (n->failover) {
> + device_listener_unregister(&n->primary_listener);
> g_free(n->primary_device_id);
> g_free(n->standby_id);
> qobject_unref(n->primary_device_dict);
> --
> 2.25.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] virtio-net: fix removal of failover device
2020-07-03 11:59 ` Michael S. Tsirkin
@ 2020-07-07 7:38 ` Jason Wang
0 siblings, 0 replies; 3+ messages in thread
From: Jason Wang @ 2020-07-07 7:38 UTC (permalink / raw)
To: Michael S. Tsirkin, Juan Quintela; +Cc: qemu-devel
On 2020/7/3 下午7:59, Michael S. Tsirkin wrote:
> On Fri, Jul 03, 2020 at 01:48:13PM +0200, Juan Quintela wrote:
>> If you have a networking device and its virtio failover device, and
>> you remove them in this order:
>> - virtio device
>> - the real device
>>
>> You get qemu crash.
>> See bugzilla:https://bugzilla.redhat.com/show_bug.cgi?id=1820120
>>
>> Bug exist on qemu 4.2 and 5.0.
>> But in 5.0 don't shows because commit
>> 77b06bba62034a87cc61a9c8de1309ae3e527d97
>>
>> somehow papers over it.
>>
>> CC: Jason Wang<jasowang@redhat.com>
>> CC: Michael S. Tsirkin<mst@redhat.com>
>>
>> Signed-off-by: Juan Quintela<quintela@redhat.com>
> Reviewed-by: Michael S. Tsirkin<mst@redhat.com>
>
>
> Jason can you queue this pls?
Queued.
Thanks
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-07 7:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-03 11:48 [PATCH] virtio-net: fix removal of failover device Juan Quintela
2020-07-03 11:59 ` Michael S. Tsirkin
2020-07-07 7:38 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).