* [PATCH] migration: postcopy take proper error return
@ 2020-07-01 9:35 Dr. David Alan Gilbert (git)
2020-07-01 9:38 ` Thomas Huth
2020-07-03 12:19 ` Dr. David Alan Gilbert
0 siblings, 2 replies; 3+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2020-07-01 9:35 UTC (permalink / raw)
To: qemu-devel, quintela, thuth
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
This function returns a boolean success and we're returning -1;
lets just use the 'out' error path.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Fixes: 58b7c17e226 ("Disable mlock around incoming postcopy")
Buglink: https://bugs.launchpad.net/qemu/+bug/1885720
---
migration/postcopy-ram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
index a36402722b..bef2a3afed 100644
--- a/migration/postcopy-ram.c
+++ b/migration/postcopy-ram.c
@@ -389,7 +389,7 @@ bool postcopy_ram_supported_by_host(MigrationIncomingState *mis)
*/
if (munlockall()) {
error_report("%s: munlockall: %s", __func__, strerror(errno));
- return -1;
+ goto out;
}
/*
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] migration: postcopy take proper error return
2020-07-01 9:35 [PATCH] migration: postcopy take proper error return Dr. David Alan Gilbert (git)
@ 2020-07-01 9:38 ` Thomas Huth
2020-07-03 12:19 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2020-07-01 9:38 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git), qemu-devel, quintela
On 01/07/2020 11.35, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> This function returns a boolean success and we're returning -1;
> lets just use the 'out' error path.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Fixes: 58b7c17e226 ("Disable mlock around incoming postcopy")
> Buglink: https://bugs.launchpad.net/qemu/+bug/1885720
> ---
> migration/postcopy-ram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
> index a36402722b..bef2a3afed 100644
> --- a/migration/postcopy-ram.c
> +++ b/migration/postcopy-ram.c
> @@ -389,7 +389,7 @@ bool postcopy_ram_supported_by_host(MigrationIncomingState *mis)
> */
> if (munlockall()) {
> error_report("%s: munlockall: %s", __func__, strerror(errno));
> - return -1;
> + goto out;
> }
Sounds like the right thing to do here.
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] migration: postcopy take proper error return
2020-07-01 9:35 [PATCH] migration: postcopy take proper error return Dr. David Alan Gilbert (git)
2020-07-01 9:38 ` Thomas Huth
@ 2020-07-03 12:19 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2020-07-03 12:19 UTC (permalink / raw)
To: qemu-devel, quintela, thuth
* Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> This function returns a boolean success and we're returning -1;
> lets just use the 'out' error path.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Fixes: 58b7c17e226 ("Disable mlock around incoming postcopy")
> Buglink: https://bugs.launchpad.net/qemu/+bug/1885720
queued
> ---
> migration/postcopy-ram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
> index a36402722b..bef2a3afed 100644
> --- a/migration/postcopy-ram.c
> +++ b/migration/postcopy-ram.c
> @@ -389,7 +389,7 @@ bool postcopy_ram_supported_by_host(MigrationIncomingState *mis)
> */
> if (munlockall()) {
> error_report("%s: munlockall: %s", __func__, strerror(errno));
> - return -1;
> + goto out;
> }
>
> /*
> --
> 2.26.2
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-03 12:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-01 9:35 [PATCH] migration: postcopy take proper error return Dr. David Alan Gilbert (git)
2020-07-01 9:38 ` Thomas Huth
2020-07-03 12:19 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).