From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D983C433E0 for ; Fri, 3 Jul 2020 15:50:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57D192088E for ; Fri, 3 Jul 2020 15:50:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VykdimSE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57D192088E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrNxQ-0002fn-Ky for qemu-devel@archiver.kernel.org; Fri, 03 Jul 2020 11:50:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrNwm-00023B-My for qemu-devel@nongnu.org; Fri, 03 Jul 2020 11:49:52 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:29626 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jrNwj-0003Rt-Eb for qemu-devel@nongnu.org; Fri, 03 Jul 2020 11:49:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593791388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mtg47ti0wJhKtJ+/TegSPrlXTEfiNp4Ef/upH4sEOE4=; b=VykdimSEi942f910Gd1ZvjVZmr2afOpKkP7Zc+g7YZUPapPu1oD6HOYYZ3hjFvMid+IZhh Ft7uRt4OeRygpQ4cZg8h5dMau2nZbL+pG26T2r5yGp8Wvwuk900CARJnvR7NAfTcifHHzn b8TiGecILAkQAP31ZJj8XkEg2DhtfkM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-238-DoVBwYaBMhSQC8I7tpzong-1; Fri, 03 Jul 2020 11:49:40 -0400 X-MC-Unique: DoVBwYaBMhSQC8I7tpzong-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F3B2ABFC0; Fri, 3 Jul 2020 15:49:37 +0000 (UTC) Received: from work-vm (ovpn-114-207.ams2.redhat.com [10.36.114.207]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 989AD778B0; Fri, 3 Jul 2020 15:49:35 +0000 (UTC) Date: Fri, 3 Jul 2020 16:49:33 +0100 From: "Dr. David Alan Gilbert" To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Subject: Re: [PATCH 2/6] migration: introduce savevm, loadvm, delvm QMP commands Message-ID: <20200703154933.GE6641@work-vm> References: <20200702175754.2211821-1-berrange@redhat.com> <20200702175754.2211821-3-berrange@redhat.com> <20200702182452.GP1888119@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200702182452.GP1888119@redhat.com> User-Agent: Mutt/1.14.5 (2020-06-23) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.120; envelope-from=dgilbert@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/03 03:38:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Krempa , qemu-block@nongnu.org, Juan Quintela , qemu-devel@nongnu.org, Markus Armbruster , Pavel Dovgalyuk , Paolo Bonzini , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Daniel P. Berrangé (berrange@redhat.com) wrote: > On Thu, Jul 02, 2020 at 01:12:52PM -0500, Eric Blake wrote: > > On 7/2/20 12:57 PM, Daniel P. Berrangé wrote: > > > savevm, loadvm and delvm are some of the few commands that have never > > > been converted to use QMP. The primary reason for this lack of > > > conversion is that they block execution of the thread for as long as > > > they run. > > > > > > Despite this downside, however, libvirt and applications using libvirt > > > has used these commands for as long as QMP has existed, via the > > > "human-monitor-command" passthrough command. IOW, while it is clearly > > > desirable to be able to fix the blocking problem, this is not an > > > immediate obstacle to real world usage. > > > > > > Meanwhile there is a need for other features which involve adding new > > > parameters to the commands. This is possible with HMP passthrough, but > > > it provides no reliable way for apps to introspect features, so using > > > QAPI modelling is highly desirable. > > > > > > This patch thus introduces trival savevm, loadvm, delvm commands > > > > trivial > > > > > to QMP that are functionally identical to the HMP counterpart, including > > > the blocking problem. > > > > Should we name them 'x-savevm', 'x-loadvm', 'x-delvm' to give ourselves room > > to change them when we DO solve the blocking issue? Or will the solution of > > the blocking issue introduce new QMP commands, at which point we can add QMP > > deprecation markers on these commands to eventually retire them? > > I was in two minds about this, so I'm open to arguments either way. > > The primary goal is for libvirt to consume the APIs as soon as possible, > and generally libvirt doesn't want todo this is they are declared experimental > via a "x-" prefix. So that pushes me away from "x-". > > If we don't have an "x-" prefix and want to make changes, we can add extra > parameters to trigger new behaviour in backwards compatible manner. Or we can > simply deprecate these commands, deleting them 2 releases later, while adding > completely new commands. > > If we think the prposed design will definitely need incompatible changes in > a very short time frame though, that would push towards "x-". > > So IMHO the right answer largely depends on whether there is a credible > strategy to implement the ideal non-blocking solution in a reasonable amount > of time. I can't justify spending much time on this myself, but I'm willing > to consider & try proposals for solving the blocking problem if they're not > too complex / invasive. Remind me, what was the problem with just making a block: migration channel, and then we can migrate to it? Dave > I just don't want to end up having a "x-savevm" command for another 10 years, > waiting for a perfect solution that never arrives because people always have > higher priority items, as apps are clearly able to accept the blocking problem > if the alternative is no snapshots at all. > > > > > + > > > +## > > > +# @savevm: > > > +# > > > +# Save a VM snapshot > > > +# > > > +# @tag: name of the snapshot to create. If it already > > > +# exists it will be replaced. > > > +# > > > +# Note that execution of the VM will be paused during the time > > > +# it takes to save the snapshot > > > +# > > > +# Returns: nothing > > > +# > > > +# Example: > > > +# > > > +# -> { "execute": "savevm", > > > +# "data": { > > > +# "tag": "my-snap" > > > +# } > > > +# } > > > +# <- { "return": { } } > > > +# > > > +# Since: 5.2 > > > > I guess you are NOT trying to make 5.1 soft freeze next week? > > Correct. It is unrealistic to consider this for soft freeze. > > I'd really love to have a solution in 5.2 though, even if it doesn't > solve all our problems. Something that can at least unblock apps that > want to use OVMF with internal snapshots today. > > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK