From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ABE6C433DF for ; Fri, 3 Jul 2020 17:12:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8C1B20870 for ; Fri, 3 Jul 2020 17:12:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Icbi79Pj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8C1B20870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrPEl-00013W-1k for qemu-devel@archiver.kernel.org; Fri, 03 Jul 2020 13:12:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrP9g-0000xb-Gt for qemu-devel@nongnu.org; Fri, 03 Jul 2020 13:07:16 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:42872 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jrP9e-0000pq-2M for qemu-devel@nongnu.org; Fri, 03 Jul 2020 13:07:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593796032; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DyNCfJuceFRPPQfMkbsHJVr1kL42rB+dKVwUzTNKksA=; b=Icbi79PjNcyKN6PV97YvaPCpsLXCuvPIu3vQQi5ygTL/7ZY9kd+HLpzACSnK9z+jOTeeSn ziSecYVQGZsCg3q/ZtBUwd4Tstb7cOUiEjSLc3UQ4YUC77GwSZguSvQwJOg4EI2xRMTSPo jB+epm9W3vNRHG5CuakJh+fS1jGK4Jk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-49-WLdp-gzRN5KurIvym17iww-1; Fri, 03 Jul 2020 13:07:10 -0400 X-MC-Unique: WLdp-gzRN5KurIvym17iww-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F35878014D7 for ; Fri, 3 Jul 2020 17:07:09 +0000 (UTC) Received: from redhat.com (unknown [10.36.110.57]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 89FE510013D4; Fri, 3 Jul 2020 17:07:02 +0000 (UTC) Date: Fri, 3 Jul 2020 18:06:59 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Laszlo Ersek Subject: Re: [RFC PATCH] MAINTAINERS: Cover the firmware JSON schema Message-ID: <20200703170659.GQ2213227@redhat.com> References: <20200703161453.8406-1-philmd@redhat.com> <20200703161858.GO2213227@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.14.3 (2020-06-14) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/03 01:34:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: "Michael S . Tsirkin" , Kashyap Chamarthy , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jul 03, 2020 at 06:58:45PM +0200, Laszlo Ersek wrote: > On 07/03/20 18:18, Daniel P. Berrangé wrote: > > On Fri, Jul 03, 2020 at 06:14:53PM +0200, Philippe Mathieu-Daudé wrote: > >> Add an entry to cover firmware.json (see commit 3a0adfc9bf: > >> schema that describes the different uses and properties of > >> virtual machine firmware). > >> Cc the libvirt maintainers if it ever changes. > >> > >> Cc: Laszlo Ersek > >> Cc: Daniel P. Berrange > >> Cc: Gerd Hoffmann > >> Cc: Kashyap Chamarthy > >> Cc: Michael S. Tsirkin > >> Suggested-by: Laszlo Ersek > >> Signed-off-by: Philippe Mathieu-Daudé > >> --- > >> Based on a comment from Laszlo: > >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg604925.html > >> > >> I don't think Laszlo should be the sole maintainer, not sure > >> who else should be listed. Gerd and Kashyap? :) > >> Can we add it 'maintained' without specific maintainer? > >> --- > >> MAINTAINERS | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index dec252f38b..57c90201df 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -2601,6 +2601,12 @@ F: include/hw/i2c/smbus_master.h > >> F: include/hw/i2c/smbus_slave.h > >> F: include/hw/i2c/smbus_eeprom.h > >> > >> +Firmware schema specifications > >> +M: Laszlo Ersek > >> +R: libvir-list@redhat.com > > > > FWIW, I don't think libvirt needs to review this. Our firmware handling > > code doesn't really care what specific files exist - it just follows the > > declared logic to pick amongst whatever exists. > > I request that > > - Phil be listed please as another maintainer (so there are two people > that can send pull requests, if a 3rd person needs to patch this file > for whatever reason), > > - Dan be listed please *at least* as an "R" person; the business logic > written up under the @Firmware element, and lots of the initial review > comments (in particular the suggestion to mention specific QEMU command > line switches in the schema), had come from him. > > If Dan is willing to be an "M", then we can collapse both of my above > requests into one, and Phil wouldn't have to be listed (Dan could both > review suggested changes and submit pull requests). However, I'm raising > this only as a technical possibility; what really matters to me is that > Dan be CC'd on suggested changes, and that someone other than me can > submit PRs if necessary. I'm fine with "R", but don't want to be "M" as I don't want to be responsible for queueing patches, etc on more parts of QEMU. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|