From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PATCH 1/2] hw/char/serial: Separate and document static properties
Date: Fri, 3 Jul 2020 20:58:08 +0200 [thread overview]
Message-ID: <20200703185809.5896-2-f4bug@amsat.org> (raw)
In-Reply-To: <20200703185809.5896-1-f4bug@amsat.org>
Add more descriptive comments to keep a clear separation
between static property vs runtime changeable.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
include/hw/char/serial.h | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/include/hw/char/serial.h b/include/hw/char/serial.h
index 535fa23a2b..d955963ef1 100644
--- a/include/hw/char/serial.h
+++ b/include/hw/char/serial.h
@@ -55,9 +55,7 @@ typedef struct SerialState {
it can be reset while reading iir */
int thr_ipending;
qemu_irq irq;
- CharBackend chr;
int last_break_enable;
- uint32_t baudbase;
uint32_t tsr_retry;
guint watch_tag;
uint32_t wakeup;
@@ -77,6 +75,10 @@ typedef struct SerialState {
QEMUTimer *modem_status_poll;
MemoryRegion io;
+
+ /* Properties */
+ CharBackend chr;
+ uint32_t baudbase;
} SerialState;
typedef struct SerialMM {
@@ -84,6 +86,7 @@ typedef struct SerialMM {
SerialState serial;
+ /* Properties */
uint8_t regshift;
uint8_t endianness;
} SerialMM;
--
2.21.3
next prev parent reply other threads:[~2020-07-03 18:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 18:58 [PATCH 0/2] hw/char/serial: Migrate I/O serial device Philippe Mathieu-Daudé
2020-07-03 18:58 ` Philippe Mathieu-Daudé [this message]
2020-07-10 8:23 ` [PATCH 1/2] hw/char/serial: Separate and document static properties Peter Maydell
2020-07-10 9:24 ` Juan Quintela
2020-07-03 18:58 ` [PATCH 2/2] hw/char/serial: Allow migration of the I/O serial device Philippe Mathieu-Daudé
2020-07-07 10:39 ` Paolo Bonzini
2020-07-10 8:34 ` Peter Maydell
2020-07-10 9:32 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703185809.5896-2-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).