* [PATCH] hw/arm/bcm2836: Remove unused 'cpu_type' field
@ 2020-07-03 20:04 Philippe Mathieu-Daudé
2020-07-05 3:02 ` Alistair Francis
2020-07-06 11:38 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-07-03 20:04 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Alistair Francis, Philippe Mathieu-Daudé,
Andrew Baumann, qemu-arm, Philippe Mathieu-Daudé
The 'cpu_type' has been moved from BCM283XState to BCM283XClass
in commit 210f47840d, but we forgot to remove the old variable.
Do it now.
Fixes: 210f47840d ("hw/arm/bcm2836: Hardcode correct CPU type")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
include/hw/arm/bcm2836.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/hw/arm/bcm2836.h b/include/hw/arm/bcm2836.h
index 024af8aae4..79dfff9d73 100644
--- a/include/hw/arm/bcm2836.h
+++ b/include/hw/arm/bcm2836.h
@@ -33,7 +33,6 @@ typedef struct BCM283XState {
DeviceState parent_obj;
/*< public >*/
- char *cpu_type;
uint32_t enabled_cpus;
struct {
--
2.21.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hw/arm/bcm2836: Remove unused 'cpu_type' field
2020-07-03 20:04 [PATCH] hw/arm/bcm2836: Remove unused 'cpu_type' field Philippe Mathieu-Daudé
@ 2020-07-05 3:02 ` Alistair Francis
2020-07-06 11:38 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Alistair Francis @ 2020-07-05 3:02 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Peter Maydell, Alistair Francis, qemu-devel@nongnu.org Developers,
Andrew Baumann, qemu-arm, Philippe Mathieu-Daudé
On Fri, Jul 3, 2020 at 1:05 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The 'cpu_type' has been moved from BCM283XState to BCM283XClass
> in commit 210f47840d, but we forgot to remove the old variable.
> Do it now.
>
> Fixes: 210f47840d ("hw/arm/bcm2836: Hardcode correct CPU type")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> include/hw/arm/bcm2836.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/arm/bcm2836.h b/include/hw/arm/bcm2836.h
> index 024af8aae4..79dfff9d73 100644
> --- a/include/hw/arm/bcm2836.h
> +++ b/include/hw/arm/bcm2836.h
> @@ -33,7 +33,6 @@ typedef struct BCM283XState {
> DeviceState parent_obj;
> /*< public >*/
>
> - char *cpu_type;
> uint32_t enabled_cpus;
>
> struct {
> --
> 2.21.3
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hw/arm/bcm2836: Remove unused 'cpu_type' field
2020-07-03 20:04 [PATCH] hw/arm/bcm2836: Remove unused 'cpu_type' field Philippe Mathieu-Daudé
2020-07-05 3:02 ` Alistair Francis
@ 2020-07-06 11:38 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2020-07-06 11:38 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-arm, Alistair Francis, Philippe Mathieu-Daudé,
QEMU Developers, Andrew Baumann
On Fri, 3 Jul 2020 at 21:05, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The 'cpu_type' has been moved from BCM283XState to BCM283XClass
> in commit 210f47840d, but we forgot to remove the old variable.
> Do it now.
>
> Fixes: 210f47840d ("hw/arm/bcm2836: Hardcode correct CPU type")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/hw/arm/bcm2836.h | 1 -
> 1 file changed, 1 deletion(-)
>
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-06 11:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-03 20:04 [PATCH] hw/arm/bcm2836: Remove unused 'cpu_type' field Philippe Mathieu-Daudé
2020-07-05 3:02 ` Alistair Francis
2020-07-06 11:38 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).