From: Klaus Jensen <its@irrelevant.dk>
To: qemu-block@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Dmitry Fomichev" <Dmitry.Fomichev@wdc.com>,
"Klaus Jensen" <k.jensen@samsung.com>,
qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
"Klaus Jensen" <its@irrelevant.dk>,
"Keith Busch" <kbusch@kernel.org>,
"Javier Gonzalez" <javier.gonz@samsung.com>,
"Maxim Levitsky" <mlevitsk@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v3 00/18] hw/block/nvme: bump to v1.3
Date: Mon, 6 Jul 2020 08:12:45 +0200 [thread overview]
Message-ID: <20200706061303.246057-1-its@irrelevant.dk> (raw)
From: Klaus Jensen <k.jensen@samsung.com>
This adds mandatory features of NVM Express v1.3 to the emulated NVMe
device.
v3:
* hw/block/nvme: additional tracing
- Reverse logic in nvme_cid(). (Philippe)
- Move nvme_cid() and nvme_sqid() to source file. (Philippe)
* hw/block/nvme: fix missing endian conversion
- Move this patch to very early in the series and fix the bug properly as
suggested by Philippe. Then let the change trickle down through
the series. (Philippe)
* hw/block/nvme: add remaining mandatory controller parameters
- Move the nvme_feature_{support,default} arrays to the source file.
(Philippe)
- Add a NVME_FID_MAX constant. (Philippe)
* hw/block/nvme: support the get/set features select and save fields
- Move the nvme_feature_cap array to the source file. (Philippe)
* hw/block/nvme: reject invalid nsid values in active namespace id list
- Rework the condition and add a comment and reference to the spec.
(Philippe)
* hw/block/nvme: provide the mandatory subnqn field
- Change to use strpadcpy(). (Philippe)
Had to clear some R-b's due to functional changes.
Missing review: 2, 3, 7, 12, 16, 17
v2:
* hw/block/nvme: bump spec data structures to v1.3
- Shorten some constants. (Dmitry)
* hw/block/nvme: add temperature threshold feature
- Remove unused temp_thresh member. (Dmitry)
* hw/block/nvme: add support for the get log page command
- Change the temperature field in the NvmeSmartLog struct to be an
uint16_t and handle wierd alignment by adding QEMU_PACKED to the
struct. (Dmitry)
* hw/block/nvme: add remaining mandatory controller parameters
- Fix spelling. (Dmitry)
* hw/block/nvme: support the get/set features select and save fields
- Fix bad logic causing temperature thresholds to always report
defaults. (Dmitry)
* hw/block/nvme: reject invalid nsid values in active namespace id list
- Added patch; reject the 0xfffffffe and 0xffffffff nsid values.
$ git-backport-diff -u for-master/bump-to-v1.3-v2 -r upstream/master... -S
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/18:[----] [--] 'hw/block/nvme: bump spec data structures to v1.3'
002/18:[0008] [FC] 'hw/block/nvme: fix missing endian conversion'
003/18:[0028] [FC] 'hw/block/nvme: additional tracing'
004/18:[----] [--] 'hw/block/nvme: add support for the abort command'
005/18:[0004] [FC] 'hw/block/nvme: add temperature threshold feature'
006/18:[----] [--] 'hw/block/nvme: mark fw slot 1 as read-only'
007/18:[----] [--] 'hw/block/nvme: add support for the get log page command'
008/18:[0002] [FC] 'hw/block/nvme: add support for the asynchronous event request command'
009/18:[----] [--] 'hw/block/nvme: move NvmeFeatureVal into hw/block/nvme.h'
010/18:[----] [--] 'hw/block/nvme: flush write cache when disabled'
011/18:[0044] [FC] 'hw/block/nvme: add remaining mandatory controller parameters'
012/18:[0024] [FC] 'hw/block/nvme: support the get/set features select and save fields'
013/18:[----] [--] 'hw/block/nvme: make sure ncqr and nsqr is valid'
014/18:[----] [--] 'hw/block/nvme: support identify namespace descriptor list'
015/18:[0008] [FC] 'hw/block/nvme: reject invalid nsid values in active namespace id list'
016/18:[----] [--] 'hw/block/nvme: enforce valid queue creation sequence'
017/18:[0006] [FC] 'hw/block/nvme: provide the mandatory subnqn field'
018/18:[----] [--] 'hw/block/nvme: bump supported version to v1.3'
Klaus Jensen (18):
hw/block/nvme: bump spec data structures to v1.3
hw/block/nvme: fix missing endian conversion
hw/block/nvme: additional tracing
hw/block/nvme: add support for the abort command
hw/block/nvme: add temperature threshold feature
hw/block/nvme: mark fw slot 1 as read-only
hw/block/nvme: add support for the get log page command
hw/block/nvme: add support for the asynchronous event request command
hw/block/nvme: move NvmeFeatureVal into hw/block/nvme.h
hw/block/nvme: flush write cache when disabled
hw/block/nvme: add remaining mandatory controller parameters
hw/block/nvme: support the get/set features select and save fields
hw/block/nvme: make sure ncqr and nsqr is valid
hw/block/nvme: support identify namespace descriptor list
hw/block/nvme: reject invalid nsid values in active namespace id list
hw/block/nvme: enforce valid queue creation sequence
hw/block/nvme: provide the mandatory subnqn field
hw/block/nvme: bump supported version to v1.3
block/nvme.c | 18 +-
hw/block/nvme.c | 676 ++++++++++++++++++++++++++++++++++++++++--
hw/block/nvme.h | 22 +-
hw/block/trace-events | 27 +-
include/block/nvme.h | 225 +++++++++++---
5 files changed, 892 insertions(+), 76 deletions(-)
--
2.27.0
next reply other threads:[~2020-07-06 6:14 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 6:12 Klaus Jensen [this message]
2020-07-06 6:12 ` [PATCH v3 01/18] hw/block/nvme: bump spec data structures to v1.3 Klaus Jensen
2020-07-08 19:19 ` Dmitry Fomichev
2020-07-08 21:24 ` Klaus Jensen
2020-07-08 21:47 ` Dmitry Fomichev
2020-07-09 6:17 ` Klaus Jensen
2020-07-06 6:12 ` [PATCH v3 02/18] hw/block/nvme: fix missing endian conversion Klaus Jensen
2020-07-06 9:50 ` Philippe Mathieu-Daudé
2020-07-08 19:20 ` Dmitry Fomichev
2020-07-29 8:49 ` Maxim Levitsky
2020-07-06 6:12 ` [PATCH v3 03/18] hw/block/nvme: additional tracing Klaus Jensen
2020-07-06 9:50 ` Philippe Mathieu-Daudé
2020-07-08 19:21 ` Dmitry Fomichev
2020-07-29 8:52 ` Maxim Levitsky
2020-07-06 6:12 ` [PATCH v3 04/18] hw/block/nvme: add support for the abort command Klaus Jensen
2020-07-06 6:12 ` [PATCH v3 05/18] hw/block/nvme: add temperature threshold feature Klaus Jensen
2020-07-08 19:24 ` Dmitry Fomichev
2020-07-06 6:12 ` [PATCH v3 06/18] hw/block/nvme: mark fw slot 1 as read-only Klaus Jensen
2020-07-29 9:14 ` Maxim Levitsky
2020-07-06 6:12 ` [PATCH v3 07/18] hw/block/nvme: add support for the get log page command Klaus Jensen
2020-07-08 19:22 ` Dmitry Fomichev
2020-07-29 10:24 ` Maxim Levitsky
2020-07-29 11:44 ` Klaus Jensen
2020-07-29 18:35 ` Maxim Levitsky
2020-09-29 13:11 ` Peter Maydell
2020-09-29 21:46 ` Klaus Jensen
2020-09-29 22:34 ` Keith Busch
2020-09-29 22:42 ` Klaus Jensen
2020-09-29 22:57 ` Keith Busch
2020-07-06 6:12 ` [PATCH v3 08/18] hw/block/nvme: add support for the asynchronous event request command Klaus Jensen
2020-07-29 10:43 ` Maxim Levitsky
2020-07-29 13:37 ` Klaus Jensen
2020-07-29 18:45 ` Maxim Levitsky
2020-07-29 20:08 ` Klaus Jensen
2020-07-30 8:50 ` Maxim Levitsky
2020-07-06 6:12 ` [PATCH v3 09/18] hw/block/nvme: move NvmeFeatureVal into hw/block/nvme.h Klaus Jensen
2020-07-29 10:46 ` Maxim Levitsky
2020-07-06 6:12 ` [PATCH v3 10/18] hw/block/nvme: flush write cache when disabled Klaus Jensen
2020-07-29 11:03 ` Maxim Levitsky
2020-07-06 6:12 ` [PATCH v3 11/18] hw/block/nvme: add remaining mandatory controller parameters Klaus Jensen
2020-07-29 11:31 ` Maxim Levitsky
2020-07-06 6:12 ` [PATCH v3 12/18] hw/block/nvme: support the get/set features select and save fields Klaus Jensen
2020-07-08 19:25 ` Dmitry Fomichev
2020-07-29 13:17 ` Maxim Levitsky
2020-07-29 13:48 ` Klaus Jensen
2020-07-29 18:47 ` Maxim Levitsky
2020-07-06 6:12 ` [PATCH v3 13/18] hw/block/nvme: make sure ncqr and nsqr is valid Klaus Jensen
2020-07-06 6:12 ` [PATCH v3 14/18] hw/block/nvme: support identify namespace descriptor list Klaus Jensen
2020-07-29 13:25 ` Maxim Levitsky
2020-07-06 6:13 ` [PATCH v3 15/18] hw/block/nvme: reject invalid nsid values in active namespace id list Klaus Jensen
2020-07-06 9:47 ` Philippe Mathieu-Daudé
2020-07-08 19:26 ` Dmitry Fomichev
2020-07-29 13:27 ` Maxim Levitsky
2020-07-06 6:13 ` [PATCH v3 16/18] hw/block/nvme: enforce valid queue creation sequence Klaus Jensen
2020-07-06 6:13 ` [PATCH v3 17/18] hw/block/nvme: provide the mandatory subnqn field Klaus Jensen
2020-07-06 9:47 ` Philippe Mathieu-Daudé
2020-07-08 19:26 ` Dmitry Fomichev
2020-07-29 13:34 ` Maxim Levitsky
2020-07-06 6:13 ` [PATCH v3 18/18] hw/block/nvme: bump supported version to v1.3 Klaus Jensen
2020-07-20 9:13 ` [PATCH v3 00/18] hw/block/nvme: bump " Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706061303.246057-1-its@irrelevant.dk \
--to=its@irrelevant.dk \
--cc=Dmitry.Fomichev@wdc.com \
--cc=javier.gonz@samsung.com \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).