* [PATCH] scripts: improve message when TAP based tests fail
@ 2020-07-06 12:50 Daniel P. Berrangé
2020-07-06 13:17 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Daniel P. Berrangé @ 2020-07-06 12:50 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Paolo Bonzini, Daniel P. Berrangé,
Peter Maydell
If one of the qtests fails, the TAP driver prints out a message like:
ERROR - too few tests run (expected 3, got 1)
which fails to tell you which test program failed. This is a critical
ommission when many tests are running in parallel as their output is
interleaved. The improved message is:
ERROR endianness-test - too few tests run (expected 3, got 1)
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
scripts/tap-driver.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/tap-driver.pl b/scripts/tap-driver.pl
index 6621a5cd67..b1d3880c50 100755
--- a/scripts/tap-driver.pl
+++ b/scripts/tap-driver.pl
@@ -217,7 +217,7 @@ sub report ($;$)
sub testsuite_error ($)
{
- report "ERROR", "- $_[0]";
+ report "ERROR", "$test_name - $_[0]";
}
sub handle_tap_result ($)
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] scripts: improve message when TAP based tests fail
2020-07-06 12:50 [PATCH] scripts: improve message when TAP based tests fail Daniel P. Berrangé
@ 2020-07-06 13:17 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2020-07-06 13:17 UTC (permalink / raw)
To: Daniel P. Berrangé, qemu-devel; +Cc: qemu-trivial, Peter Maydell
On 06/07/20 14:50, Daniel P. Berrangé wrote:
> If one of the qtests fails, the TAP driver prints out a message like:
>
> ERROR - too few tests run (expected 3, got 1)
>
> which fails to tell you which test program failed. This is a critical
> ommission when many tests are running in parallel as their output is
> interleaved. The improved message is:
>
> ERROR endianness-test - too few tests run (expected 3, got 1)
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> scripts/tap-driver.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/tap-driver.pl b/scripts/tap-driver.pl
> index 6621a5cd67..b1d3880c50 100755
> --- a/scripts/tap-driver.pl
> +++ b/scripts/tap-driver.pl
> @@ -217,7 +217,7 @@ sub report ($;$)
>
> sub testsuite_error ($)
> {
> - report "ERROR", "- $_[0]";
> + report "ERROR", "$test_name - $_[0]";
> }
>
> sub handle_tap_result ($)
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-06 13:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-06 12:50 [PATCH] scripts: improve message when TAP based tests fail Daniel P. Berrangé
2020-07-06 13:17 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).