qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	libvir-list@redhat.com,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	qemu-ppc@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [PULL 05/20] audio: deprecate -soundhw es1370
Date: Mon,  6 Jul 2020 21:29:06 +0200	[thread overview]
Message-ID: <20200706192921.1154-6-kraxel@redhat.com> (raw)
In-Reply-To: <20200706192921.1154-1-kraxel@redhat.com>

Switch to deprecated_register_soundhw().  Remove the now obsolete init
function.  Add an alias so both es1370 and ES1370 are working with
-device.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 20200702132525.6849-6-kraxel@redhat.com
---
 hw/audio/es1370.c | 9 ++-------
 qdev-monitor.c    | 1 +
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/hw/audio/es1370.c b/hw/audio/es1370.c
index 5f8a83ff5624..4255463a49ff 100644
--- a/hw/audio/es1370.c
+++ b/hw/audio/es1370.c
@@ -884,12 +884,6 @@ static void es1370_exit(PCIDevice *dev)
     AUD_remove_card(&s->card);
 }
 
-static int es1370_init (PCIBus *bus)
-{
-    pci_create_simple (bus, -1, TYPE_ES1370);
-    return 0;
-}
-
 static Property es1370_properties[] = {
     DEFINE_AUDIO_PROPERTIES(ES1370State, card),
     DEFINE_PROP_END_OF_LIST(),
@@ -928,7 +922,8 @@ static const TypeInfo es1370_info = {
 static void es1370_register_types (void)
 {
     type_register_static (&es1370_info);
-    pci_register_soundhw("es1370", "ENSONIQ AudioPCI ES1370", es1370_init);
+    deprecated_register_soundhw("es1370", "ENSONIQ AudioPCI ES1370",
+                                0, TYPE_ES1370);
 }
 
 type_init (es1370_register_types)
diff --git a/qdev-monitor.c b/qdev-monitor.c
index 105d9792ecdf..e3083fae394b 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -55,6 +55,7 @@ typedef struct QDevAlias
 static const QDevAlias qdev_alias_table[] = {
     { "AC97", "ac97" }, /* -soundhw name */
     { "e1000", "e1000-82540em" },
+    { "ES1370", "es1370" }, /* -soundhw name */
     { "ich9-ahci", "ahci" },
     { "lsi53c895a", "lsi" },
     { "virtio-9p-ccw", "virtio-9p", QEMU_ARCH_S390X },
-- 
2.18.4



  parent reply	other threads:[~2020-07-06 19:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06 19:29 [PULL 00/20] Audio 20200706 patches Gerd Hoffmann
2020-07-06 19:29 ` [PULL 01/20] stubs: add isa_create_simple Gerd Hoffmann
2020-07-06 19:29 ` [PULL 02/20] stubs: add pci_create_simple Gerd Hoffmann
2020-07-06 19:29 ` [PULL 03/20] audio: add deprecated_register_soundhw Gerd Hoffmann
2020-07-06 19:29 ` [PULL 04/20] audio: deprecate -soundhw ac97 Gerd Hoffmann
2020-07-06 19:29 ` Gerd Hoffmann [this message]
2020-07-06 19:29 ` [PULL 06/20] audio: deprecate -soundhw adlib Gerd Hoffmann
2020-07-06 19:29 ` [PULL 07/20] audio: deprecate -soundhw cs4231a Gerd Hoffmann
2020-07-06 19:29 ` [PULL 08/20] audio: deprecate -soundhw gus Gerd Hoffmann
2020-07-06 19:29 ` [PULL 09/20] audio: deprecate -soundhw sb16 Gerd Hoffmann
2020-07-06 19:29 ` [PULL 10/20] audio: deprecate -soundhw hda Gerd Hoffmann
2020-07-06 19:29 ` [PULL 11/20] pc_basic_device_init: pass PCMachineState Gerd Hoffmann
2020-07-06 19:29 ` [PULL 12/20] pc_basic_device_init: drop has_pit arg Gerd Hoffmann
2020-07-06 19:29 ` [PULL 13/20] pc_basic_device_init: drop no_vmport arg Gerd Hoffmann
2020-07-06 19:29 ` [PULL 14/20] softmmu: initialize spice and audio earlier Gerd Hoffmann
2020-07-06 19:29 ` [PULL 15/20] audio: rework pcspk_init() Gerd Hoffmann
2020-07-06 19:29 ` [PULL 16/20] audio: create pcspk device early Gerd Hoffmann
2020-07-06 19:29 ` [PULL 17/20] audio: deprecate -soundhw pcspk Gerd Hoffmann
2020-07-06 19:29 ` [PULL 18/20] audio: add soundhw deprecation notice Gerd Hoffmann
2020-07-06 19:29 ` [PULL 19/20] pcspk: update docs/system/target-i386-desc.rst.inc Gerd Hoffmann
2020-07-06 19:29 ` [PULL 20/20] audio: set default value for pcspk.iobase property Gerd Hoffmann
2020-07-08 20:38 ` [PULL 00/20] Audio 20200706 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200706192921.1154-6-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=libvir-list@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).