From: Peter Krempa <pkrempa@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <huth@tuxfamily.org>,
Alistair Francis <alistair@alistair23.me>,
qemu-devel@nongnu.org, libvir-list@redhat.com,
qemu-arm@nongnu.org
Subject: Re: [RFC PATCH 2/2] hw/sd/sdcard: Deprecate the SPI mode
Date: Tue, 7 Jul 2020 08:49:51 +0200 [thread overview]
Message-ID: <20200707064951.GC9048@angien.pipo.sk> (raw)
In-Reply-To: <20200705220731.28101-3-f4bug@amsat.org>
On Mon, Jul 06, 2020 at 00:07:31 +0200, Philippe Mathieu-Daudé wrote:
> SD cards be used with SPI, SD or MMC protocol.
>
> Unfortunately, maintaining the SPI protocol make improving the
> MMC mode very difficult. As of 2020 users are more interested
> in using cards with the MMC protocol.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> docs/system/deprecated.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index 5e67d7f3e0..01dca3d038 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -384,6 +384,11 @@ full SCSI support. Use virtio-scsi instead when SCSI passthrough is required.
> Note this also applies to ``-device virtio-blk-pci,scsi=on|off``, which is an
> alias.
>
> +``-device sd-card,spi=on`` (since 5.1)
> +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> +
> +The SPI mode of the 'sd-card' device is deprecated.
libvirt didn't implement this knob so it's okay to remove it without
replacement.
ACKed-by: Peter Krempa <pkrempa@redhat.com>
next prev parent reply other threads:[~2020-07-07 6:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 22:07 [RFC PATCH 0/2] hw/sd: Deprecate the SPI mode and the SPI to SD adapter Philippe Mathieu-Daudé
2020-07-05 22:07 ` [RFC PATCH 1/2] hw/sd/ssi-sd: Deprecate the SPI to SD card 'adapter' Philippe Mathieu-Daudé
2020-07-06 17:27 ` Eric Blake
2020-07-07 6:47 ` Peter Krempa
2020-07-05 22:07 ` [RFC PATCH 2/2] hw/sd/sdcard: Deprecate the SPI mode Philippe Mathieu-Daudé
2020-07-07 6:49 ` Peter Krempa [this message]
2020-07-06 16:41 ` [RFC PATCH 0/2] hw/sd: Deprecate the SPI mode and the SPI to SD adapter Alistair Francis
2020-07-06 17:37 ` Philippe Mathieu-Daudé
2020-07-10 9:27 ` Bin Meng
2020-07-10 10:08 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707064951.GC9048@angien.pipo.sk \
--to=pkrempa@redhat.com \
--cc=alistair@alistair23.me \
--cc=f4bug@amsat.org \
--cc=huth@tuxfamily.org \
--cc=libvir-list@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).