From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70E1CC433DF for ; Tue, 7 Jul 2020 09:30:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42389206CD for ; Tue, 7 Jul 2020 09:30:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42389206CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsjvP-0006ic-HK for qemu-devel@archiver.kernel.org; Tue, 07 Jul 2020 05:30:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsjui-0005pP-DG; Tue, 07 Jul 2020 05:29:20 -0400 Received: from charlie.dont.surf ([128.199.63.193]:60118) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsjuf-0002aW-UC; Tue, 07 Jul 2020 05:29:19 -0400 Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by charlie.dont.surf (Postfix) with ESMTPSA id CAAB8BF5EE; Tue, 7 Jul 2020 09:29:15 +0000 (UTC) Date: Tue, 7 Jul 2020 11:29:12 +0200 From: Klaus Jensen To: Maxim Levitsky Subject: Re: [PATCH 0/1] hw/block/nvme: fix assert on invalid irq vector Message-ID: <20200707092912.GA537376@apples.localdomain> References: <20200609094508.32412-1-its@irrelevant.dk> <20200609114633.yvwtt6swb47l27yd@apples.localdomain> <20200609141425.GC11003@linux.fritz.box> <48537ee1-ed77-ffe6-66ba-d61838083069@redhat.com> <20200609153243.GE11003@linux.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Received-SPF: pass client-ip=128.199.63.193; envelope-from=its@irrelevant.dk; helo=charlie.dont.surf X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/07 05:29:16 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Klaus Jensen , qemu-devel@nongnu.org, Max Reitz , Keith Busch , Javier Gonzalez , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Jul 7 12:10, Maxim Levitsky wrote: > On Tue, 2020-06-09 at 17:32 +0200, Kevin Wolf wrote: > > Am 09.06.2020 um 16:18 hat Philippe Mathieu-Daudé geschrieben: > > > On 6/9/20 4:14 PM, Kevin Wolf wrote: > > > > Am 09.06.2020 um 13:46 hat Klaus Jensen geschrieben: > > > > > On Jun 9 13:17, Philippe Mathieu-Daudé wrote: > > > > > > On 6/9/20 11:45 AM, Klaus Jensen wrote: > > > > > > > From: Klaus Jensen > > > > > > > > > > > > > > I goofed up with commit c09794fe40e3 ("hw/block/nvme: allow use of any > > > > > > > valid msix vector"). > > > > > > > > > > > > Kevin, since your queue isn't merged, can you directly squash the fix? > > > > > > > > > > The commit (c09794fe40e3) can just be dropped without conflicts, but it > > > > > leaves a use of n->params.num_queues in nvme_create_cq() which commit > > > > > cde74bfd4b87 ("hw/block/nvme: add max_ioqpairs device parameter") must > > > > > fix. > > > > > > > > Hm, so it seems this isn't easy to squash in without conflicts (and I > > > > would have to rewrite the whole commit message), so I think it's better > > > > to just apply the series on top. > > > > > > > > One problem with the commit message is that it references commit IDs > > > > which aren't stable yet. Maybe it's best if I apply these patches, > > > > manually fix up the commit ID references and then immediately do a pull > > > > request so that they become stable. > > > > > > This is the friendlier way. > > > > > > Less friendly way is to drop Klaus's patches and ask him to respin. > > > While this is a valid outcome, if we can avoid it it will save all of us > > > review time. > > > > If Klaus wants to do that, fine with me. I'm just trying to find the > > easiest solution for all of us. > > > > > > It would be good to have at least one review, though. > > > > > > Maxim catched this issue, I'd feel safer if he acks your pre-merge queue. > > > > Ok. Maxim, can you please review this series then? > > > > Kevin > I am slowly getting through the heap of the patches trying to understand the current state of things. > I will start reviewing all these patches today. > Hi Maxim, Yeah, I bombed it again; sorry! ;) "[PATCH v3 00/18] hw/block/nvme: bump to v1.3" is the series currently under review. I also posted: [PATCH 00/17] hw/block/nvme: AIO and address mapping refactoring, [PATCH 0/2] hw/block/nvme: handle transient dma errors [PATCH 0/3] hw/block/nvme: support scatter gather lists [PATCH 0/4] hw/block/nvme: support multiple namespaces [PATCH] hw/block/nvme: make lba data size configurable [PATCH] hw/block/nvme: add support for dulbe [PATCH 0/3] hw/block/nvme: bump to v1.4 [PATCH 00/10] hw/block/nvme: namespace types and zoned namespaces I really appreciate you reviewing! Your R-b's are on a lot of the patches already, thanks for that!