From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 611D1C433E0 for ; Tue, 7 Jul 2020 08:22:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36176206DF for ; Tue, 7 Jul 2020 08:22:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36176206DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tuxfamily.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsirv-0002SY-Gx for qemu-devel@archiver.kernel.org; Tue, 07 Jul 2020 04:22:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsirD-0001iO-Rp for qemu-devel@nongnu.org; Tue, 07 Jul 2020 04:21:39 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:45064) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsirA-0007Yd-Sy for qemu-devel@nongnu.org; Tue, 07 Jul 2020 04:21:39 -0400 Received: by mail-ed1-f65.google.com with SMTP id d16so30996571edz.12 for ; Tue, 07 Jul 2020 01:21:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m3PYqF8n5GoN2jqRnfjVJ/OPC4LHTtnjBVWtwlfV3dk=; b=EF6KX1PkSeW/z8OfWumPpL4A36V/XijUfe9GCEzMV0EYlyHSQoZQeiwcwE+KKUGWxg 8D/Qxa0j+DHPCLiRRFo1dPcLitB0WTW5/jCGIgLeCpuSW+PTYZOWgMCrdqyEi0Fin+v/ 3EoPfJXE2vk3r27dQ7AM9vH+z4nUITiENc/MjIead8z+WUg4waYPFQVcd4CAKdYRg0LB q9+hRyD1Kui/qVFXSNm643py0JifkFOqnXbAcx7Bh8m72aZsrCA6/MPvFykN/HD5qaY2 Qz2iWFr7RXPX6suCQ7nmie67WhBfra9uOpddZ+OU9y940CzWFgOioTIZ8mOIeaKN8ryr +EPQ== X-Gm-Message-State: AOAM5320LahUDeHga9Y6n1TMWAeAjENyNV4X4Kn+BpIdCqV88EldBa4K fxcVnc6/zALp5TSczdmOdw0= X-Google-Smtp-Source: ABdhPJz02nx8GYNxG269aweE9mI39FLROZG1OUNsLf8BRzXD2xwc/8I0P7MXBqubajZSgLe75tdNsA== X-Received: by 2002:a05:6402:203c:: with SMTP id ay28mr50929580edb.271.1594110094935; Tue, 07 Jul 2020 01:21:34 -0700 (PDT) Received: from thl530.multi.box (pd95758fa.dip0.t-ipconnect.de. [217.87.88.250]) by smtp.gmail.com with ESMTPSA id d22sm17693028ejc.90.2020.07.07.01.21.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 01:21:34 -0700 (PDT) Date: Tue, 7 Jul 2020 10:21:32 +0200 From: Thomas Huth To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH v2 1/4] target/avr/cpu: Drop tlb_flush() in avr_cpu_reset() Message-ID: <20200707102132.679ce497@thl530.multi.box> In-Reply-To: <20200707070021.10031-2-f4bug@amsat.org> References: <20200707070021.10031-1-f4bug@amsat.org> <20200707070021.10031-2-f4bug@amsat.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=209.85.208.65; envelope-from=th.huth@gmail.com; helo=mail-ed1-f65.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/07 04:21:35 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Joaquin de Andres , Michael Rolnik , qemu-devel@nongnu.org, Sarah Harris Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am Tue, 7 Jul 2020 09:00:18 +0200 schrieb Philippe Mathieu-Daud=C3=A9 : > Since commit 1f5c00cfdb tlb_flush() is called from cpu_common_reset(). >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > target/avr/cpu.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/target/avr/cpu.c b/target/avr/cpu.c > index 4e4dd4f6aa..50fb1c378b 100644 > --- a/target/avr/cpu.c > +++ b/target/avr/cpu.c > @@ -78,8 +78,6 @@ static void avr_cpu_reset(DeviceState *ds) > env->skip =3D 0; > =20 > memset(env->r, 0, sizeof(env->r)); > - > - tlb_flush(cs); > } > =20 > static void avr_cpu_disas_set_info(CPUState *cpu, disassemble_info > *info) Reviewed-by: Thomas Huth