From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Christophe de Dinechin <dinechin@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, "Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Max Reitz" <mreitz@redhat.com>, "Marek Vasut" <marex@denx.de>,
"Stefano Stabellini" <sstabellini@kernel.org>,
qemu-block@nongnu.org, qemu-trivial@nongnu.org,
"Paul Durrant" <paul@xen.org>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Riku Voipio" <riku.voipio@iki.fi>, "Peter Lieven" <pl@kamp.de>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Roman Bolshakov" <r.bolshakov@yadro.com>,
qemu-arm@nongnu.org, "Peter Chubb" <peter.chubb@nicta.com.au>,
"Ronnie Sahlberg" <ronniesahlberg@gmail.com>,
xen-devel@lists.xenproject.org,
"Alex Bennée" <alex.bennee@linaro.org>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Kevin Wolf" <kwolf@redhat.com>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Chris Wulff" <crwulff@gmail.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Jean-Christophe Dubois" <jcd@tribudubois.net>,
qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH] trivial: Remove trailing whitespaces
Date: Tue, 7 Jul 2020 11:25:10 +0100 [thread overview]
Message-ID: <20200707102510.GF2649462@redhat.com> (raw)
In-Reply-To: <20200706162300.1084753-1-dinechin@redhat.com>
On Mon, Jul 06, 2020 at 06:23:00PM +0200, Christophe de Dinechin wrote:
> There are a number of unnecessary trailing whitespaces that have
> accumulated over time in the source code. They cause stray changes
> in patches if you use tools that automatically remove them.
>
> Tested by doing a `git diff -w` after the change.
>
> This could probably be turned into a pre-commit hook.
scripts/checkpatch.pl ought to be made to check it.
>
> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
> ---
> block/iscsi.c | 2 +-
> disas/cris.c | 2 +-
> disas/microblaze.c | 80 +++---
> disas/nios2.c | 256 +++++++++---------
> hmp-commands.hx | 2 +-
> hw/alpha/typhoon.c | 6 +-
> hw/arm/gumstix.c | 6 +-
> hw/arm/omap1.c | 2 +-
> hw/arm/stellaris.c | 2 +-
> hw/char/etraxfs_ser.c | 2 +-
> hw/core/ptimer.c | 2 +-
> hw/cris/axis_dev88.c | 2 +-
> hw/cris/boot.c | 2 +-
> hw/display/qxl.c | 2 +-
> hw/dma/etraxfs_dma.c | 18 +-
> hw/dma/i82374.c | 2 +-
> hw/i2c/bitbang_i2c.c | 2 +-
> hw/input/tsc2005.c | 2 +-
> hw/input/tsc210x.c | 2 +-
> hw/intc/etraxfs_pic.c | 8 +-
> hw/intc/sh_intc.c | 10 +-
> hw/intc/xilinx_intc.c | 2 +-
> hw/misc/imx25_ccm.c | 6 +-
> hw/misc/imx31_ccm.c | 2 +-
> hw/net/vmxnet3.h | 2 +-
> hw/net/xilinx_ethlite.c | 2 +-
> hw/pci/pcie.c | 2 +-
> hw/sd/omap_mmc.c | 2 +-
> hw/sh4/shix.c | 2 +-
> hw/sparc64/sun4u.c | 2 +-
> hw/timer/etraxfs_timer.c | 2 +-
> hw/timer/xilinx_timer.c | 4 +-
> hw/usb/hcd-musb.c | 10 +-
> hw/usb/hcd-ohci.c | 6 +-
> hw/usb/hcd-uhci.c | 2 +-
> hw/virtio/virtio-pci.c | 2 +-
> include/hw/cris/etraxfs_dma.h | 4 +-
> include/hw/net/lance.h | 2 +-
> include/hw/ppc/spapr.h | 2 +-
> include/hw/xen/interface/io/ring.h | 34 +--
> include/qemu/log.h | 2 +-
> include/qom/object.h | 4 +-
> linux-user/cris/cpu_loop.c | 16 +-
> linux-user/microblaze/cpu_loop.c | 16 +-
> linux-user/mmap.c | 8 +-
> linux-user/sparc/signal.c | 4 +-
> linux-user/syscall.c | 24 +-
> linux-user/syscall_defs.h | 2 +-
> linux-user/uaccess.c | 2 +-
> os-posix.c | 2 +-
> qapi/qapi-util.c | 2 +-
> qemu-img.c | 2 +-
> qemu-options.hx | 26 +-
> qom/object.c | 2 +-
> target/cris/translate.c | 28 +-
> target/cris/translate_v10.inc.c | 6 +-
> target/i386/hvf/hvf.c | 4 +-
> target/i386/hvf/x86.c | 4 +-
> target/i386/hvf/x86_decode.c | 20 +-
> target/i386/hvf/x86_decode.h | 4 +-
> target/i386/hvf/x86_descr.c | 2 +-
> target/i386/hvf/x86_emu.c | 2 +-
> target/i386/hvf/x86_mmu.c | 6 +-
> target/i386/hvf/x86_task.c | 2 +-
> target/i386/hvf/x86hvf.c | 42 +--
> target/i386/translate.c | 8 +-
> target/microblaze/mmu.c | 2 +-
> target/microblaze/translate.c | 2 +-
> target/sh4/op_helper.c | 4 +-
> target/xtensa/core-de212/core-isa.h | 6 +-
> .../xtensa/core-sample_controller/core-isa.h | 6 +-
> target/xtensa/core-test_kc705_be/core-isa.h | 2 +-
> tcg/sparc/tcg-target.inc.c | 2 +-
> tcg/tcg.c | 32 +--
> tests/tcg/multiarch/test-mmap.c | 72 ++---
> ui/curses.c | 4 +-
> ui/curses_keys.h | 4 +-
> util/cutils.c | 2 +-
> 78 files changed, 440 insertions(+), 440 deletions(-)
The cleanup is a good idea, however, I think it is probably better to
split the patch approx into subsystems. That will make it much easier
to cherry-pick for people doing backports.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-07-07 10:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 16:23 [PATCH] trivial: Remove trailing whitespaces Christophe de Dinechin
2020-07-06 16:31 ` no-reply
2020-07-08 11:34 ` Daniel P. Berrangé
2020-07-07 8:22 ` David Gibson
2020-07-07 9:55 ` Laurent Vivier
2020-07-07 10:25 ` Daniel P. Berrangé [this message]
2020-07-08 4:57 ` Markus Armbruster
2020-07-08 11:16 ` Roman Bolshakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707102510.GF2649462@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alistair@alistair23.me \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=crwulff@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=dinechin@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=hpoussin@reactos.org \
--cc=jasowang@redhat.com \
--cc=jcd@tribudubois.net \
--cc=jcmvbkbc@gmail.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=magnus.damm@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=marex@denx.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=riku.voipio@iki.fi \
--cc=ronniesahlberg@gmail.com \
--cc=rth@twiddle.net \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).