From: Cornelia Huck <cohuck@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, Halil Pasic <pasic@linux.ibm.com>
Cc: Eric Auger <eric.auger@redhat.com>,
qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
qemu-devel@nongnu.org
Subject: [PATCH 0/2] virtio: non-legacy device handling
Date: Tue, 7 Jul 2020 12:54:44 +0200 [thread overview]
Message-ID: <20200707105446.677966-1-cohuck@redhat.com> (raw)
As discussed in "virtio-fs: force virtio 1.x usage", it seems like
a good idea to make sure that any new virtio device (which does not
support legacy virtio) is indeed a non-transitional device, just to
catch accidental misconfigurations. We can easily compile a list
of virtio devices with legacy support and have transports verify
in their plugged callbacks that legacy support is off for any device
not in that list.
Most new virtio devices force non-transitional already, so nothing
changes for them. vhost-user-fs-pci even does not allow to configure
a non-transitional device, so it is fine as well.
One problematic device, however, is virtio-iommu-pci. It currently
offers both the transitional and the non-transitional variety of the
device, and does not force anything. I'm unsure whether we should
consider transitional virtio-iommu unsupported, or if we should add
some compat handling. (The support for legacy or not generally may
change based upon the bus, IIUC, so I'm unsure how to come up with
something generic.)
Cornelia Huck (2):
virtio: list legacy-capable devices
virtio: verify that legacy support is not accidentally on
hw/s390x/virtio-ccw.c | 6 ++++++
hw/virtio/virtio-pci.c | 4 ++++
hw/virtio/virtio.c | 25 +++++++++++++++++++++++++
include/hw/virtio/virtio.h | 2 ++
4 files changed, 37 insertions(+)
--
2.25.4
next reply other threads:[~2020-07-07 11:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 10:54 Cornelia Huck [this message]
2020-07-07 10:54 ` [PATCH 1/2] virtio: list legacy-capable devices Cornelia Huck
2020-07-07 10:54 ` [PATCH 2/2] virtio: verify that legacy support is not accidentally on Cornelia Huck
2020-07-16 13:43 ` [PATCH 0/2] virtio: non-legacy device handling Cornelia Huck
2020-07-20 8:09 ` David Hildenbrand
2020-07-20 9:03 ` Michael S. Tsirkin
2020-07-20 9:07 ` David Hildenbrand
2020-07-23 6:33 ` Cornelia Huck
2020-07-23 11:57 ` David Hildenbrand
2020-07-23 12:15 ` Cornelia Huck
2020-07-23 12:54 ` Michael S. Tsirkin
2020-07-20 9:54 ` Halil Pasic
2020-07-23 6:35 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707105446.677966-1-cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).