From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97A4CC433DF for ; Tue, 7 Jul 2020 15:45:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D16E20578 for ; Tue, 7 Jul 2020 15:45:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TPo7tXxC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D16E20578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jspnC-0004Fd-IG for qemu-devel@archiver.kernel.org; Tue, 07 Jul 2020 11:45:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jspm8-0003DH-3K for qemu-devel@nongnu.org; Tue, 07 Jul 2020 11:44:52 -0400 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:39017) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jspm6-0002E5-JH for qemu-devel@nongnu.org; Tue, 07 Jul 2020 11:44:51 -0400 Received: by mail-pl1-x644.google.com with SMTP id s14so16896825plq.6 for ; Tue, 07 Jul 2020 08:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=jHHv9dVHF/nEIC7GBp1y71kO9G/RElLP1W9vDMx/89o=; b=TPo7tXxCtVe9kO37XCNnWa6omVWJSUJgCa+//4q2CAd89TtDaBES6HxRVOLpeeUN4U ubqnIhvEGzTv750IBgg1XdePR+1t8XVm8aThlUXAPbnFGSHjIMsyxBe5l8newE5rN0qj dSJg0cjNK7YlyXQpistjAwjO8dqa3UckpMYtYZEOPD+CeC1Ml8RkqEmhLuanrRDOaIMf A7UxkEvKgMXzUUT77LSSuDZFJcU2KyApA+TZFj3bDfEq2CKFRZxg15J4kmICOa+TKUb2 2yNfoZ/6rFkNMPMhM1EoNMqTRCMswAWsywQlPgtvg51SMZ36Pv8zN3lxNv3D2j13/LCa ASTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=jHHv9dVHF/nEIC7GBp1y71kO9G/RElLP1W9vDMx/89o=; b=MBJchVzBsk987g8qEdpQgwEKStva0Oo64tqvR/c1c5wTrlkdJPPwIvLQgW3HqqSBF+ +A3UUNRUMarJhJqLnKuraEUXjT5XgPefzAIc2XFReL5dlJ4QlqCrQorWW273NoR3ZCVq iEpHpYSYJRp1mRacEMGnYyvFF6H43qh4LzOrrJAlv1t3ZnVtb/8RESsCqVrs2gpcncjD TBc+n4Iw/qrEQ5rSvyrv5xTKZfwvyY+MyejZ0nTMovc+gdEQnHwSdt+Bnb5F8j+jx+uY uN+gklcBIEla4Yi2TcQp1NV0kSwzAtabC0HtvnSV86NX47TmCldUTkvcGSx8mDeX2RCo Vymw== X-Gm-Message-State: AOAM5319LEpvTLwcC6nPm9tnoHiY4tGv0CeFNnfBsm5giEqvNhkBs67g /uZOKVi0wnPgclTPieWpdAdUBp1s/jWFxA== X-Google-Smtp-Source: ABdhPJw2XBxR4K2cpHED21BWT/SO/Q9feSxLVLCnLM9v3NgrrfrY7+55dXUqm27+tLW6Yuvnn2Lv5A== X-Received: by 2002:a17:902:bb85:: with SMTP id m5mr47047486pls.267.1594136688819; Tue, 07 Jul 2020 08:44:48 -0700 (PDT) Received: from localhost.localdomain ([39.98.209.129]) by smtp.googlemail.com with ESMTPSA id k2sm1343841pgm.11.2020.07.07.08.44.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 08:44:48 -0700 (PDT) From: Wei Wu To: qemu-devel@nongnu.org Subject: [PATCH] disas/riscv: Fix incorrect disassembly for `imm20` operand. Date: Tue, 7 Jul 2020 23:43:36 +0800 Message-Id: <20200707154336.4963-1-lazyparser@gmail.com> X-Mailer: git-send-email 2.17.1 Received-SPF: pass client-ip=2607:f8b0:4864:20::644; envelope-from=lazyparser@gmail.com; helo=mail-pl1-x644.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair.Francis@wdc.com, palmer@dabbelt.com, Wei Wu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" `imm20` operand type is used in LUI/AUIPC and other instructions. The value should not be left shifted 12bits for disassembly output. Signed-off-by: Wei Wu --- disas/riscv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas/riscv.c b/disas/riscv.c index 278d9be924..a2b6472bd8 100644 --- a/disas/riscv.c +++ b/disas/riscv.c @@ -2083,7 +2083,7 @@ static int32_t operand_imm12(rv_inst inst) static int32_t operand_imm20(rv_inst inst) { - return (((int64_t)inst << 32) >> 44) << 12; + return ((int64_t)inst << 32) >> 44; } static int32_t operand_jimm20(rv_inst inst) -- 2.17.1