* hw/intc/xics.c:605: ics_realize: Assertion `ics->xics' failed
@ 2020-07-07 11:01 Thomas Huth
2020-07-07 14:11 ` Greg Kurz
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2020-07-07 11:01 UTC (permalink / raw)
To: Greg Kurz, QEMU Developers
Cc: qemu-ppc@nongnu.org, Cédric Le Goater, David Gibson
Hi Greg,
I just ran scripts/device-crash-test and it triggered the assert that
you've added in commit b015a9809427c8 ("xics: Link ICS_PROP_XICS
property to ICSState::xics pointer"):
$ qemu-system-ppc64 -S -M powernv9,accel=tcg -device pnv-psi-POWER8
qemu-system-ppc64: hw/intc/xics.c:605: ics_realize: Assertion
`ics->xics' failed.
Aborted (core dumped)
That's ugly. Could you please have a look how this could be done in a
nicer way? (Maybe set errp and return in that case?)
Thanks,
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: hw/intc/xics.c:605: ics_realize: Assertion `ics->xics' failed
2020-07-07 11:01 hw/intc/xics.c:605: ics_realize: Assertion `ics->xics' failed Thomas Huth
@ 2020-07-07 14:11 ` Greg Kurz
2020-07-07 15:31 ` Greg Kurz
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kurz @ 2020-07-07 14:11 UTC (permalink / raw)
To: Thomas Huth
Cc: David Gibson, qemu-ppc@nongnu.org, QEMU Developers,
Cédric Le Goater
On Tue, 7 Jul 2020 13:01:54 +0200
Thomas Huth <thuth@redhat.com> wrote:
>
> Hi Greg,
>
> I just ran scripts/device-crash-test and it triggered the assert that
> you've added in commit b015a9809427c8 ("xics: Link ICS_PROP_XICS
> property to ICSState::xics pointer"):
>
> $ qemu-system-ppc64 -S -M powernv9,accel=tcg -device pnv-psi-POWER8
> qemu-system-ppc64: hw/intc/xics.c:605: ics_realize: Assertion
> `ics->xics' failed.
> Aborted (core dumped)
>
> That's ugly. Could you please have a look how this could be done in a
> nicer way? (Maybe set errp and return in that case?)
>
> Thanks,
> Thomas
>
Hi Thomas,
I'll look at that right away. Thanks for the report.
Cheers,
--
Greg
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: hw/intc/xics.c:605: ics_realize: Assertion `ics->xics' failed
2020-07-07 14:11 ` Greg Kurz
@ 2020-07-07 15:31 ` Greg Kurz
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kurz @ 2020-07-07 15:31 UTC (permalink / raw)
To: Thomas Huth
Cc: David Gibson, qemu-ppc@nongnu.org, QEMU Developers,
Cédric Le Goater
On Tue, 7 Jul 2020 16:11:55 +0200
Greg Kurz <groug@kaod.org> wrote:
> On Tue, 7 Jul 2020 13:01:54 +0200
> Thomas Huth <thuth@redhat.com> wrote:
>
> >
> > Hi Greg,
> >
> > I just ran scripts/device-crash-test and it triggered the assert that
> > you've added in commit b015a9809427c8 ("xics: Link ICS_PROP_XICS
> > property to ICSState::xics pointer"):
> >
> > $ qemu-system-ppc64 -S -M powernv9,accel=tcg -device pnv-psi-POWER8
Ah I hadn't realized you had a PSI device on the command line...
> > qemu-system-ppc64: hw/intc/xics.c:605: ics_realize: Assertion
> > `ics->xics' failed.
> > Aborted (core dumped)
> >
> > That's ugly. Could you please have a look how this could be done in a
> > nicer way? (Maybe set errp and return in that case?)
> >
PSI devices are really internal to the chip, they shouldn't be
instantiated from the command line. I'll send a patch to make
them not user creatable.
> > Thanks,
> > Thomas
> >
>
> Hi Thomas,
>
> I'll look at that right away. Thanks for the report.
>
> Cheers,
>
> --
> Greg
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-07 15:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-07 11:01 hw/intc/xics.c:605: ics_realize: Assertion `ics->xics' failed Thomas Huth
2020-07-07 14:11 ` Greg Kurz
2020-07-07 15:31 ` Greg Kurz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).