From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEDA7C433E0 for ; Wed, 8 Jul 2020 21:25:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3071206DF for ; Wed, 8 Jul 2020 21:25:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3071206DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtHZC-0005Ar-VS for qemu-devel@archiver.kernel.org; Wed, 08 Jul 2020 17:25:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtHY8-0004GZ-75; Wed, 08 Jul 2020 17:24:16 -0400 Received: from charlie.dont.surf ([128.199.63.193]:34414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtHY5-0001U8-IX; Wed, 08 Jul 2020 17:24:15 -0400 Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by charlie.dont.surf (Postfix) with ESMTPSA id 5F51DBF56B; Wed, 8 Jul 2020 21:24:08 +0000 (UTC) Date: Wed, 8 Jul 2020 23:24:04 +0200 From: Klaus Jensen To: Dmitry Fomichev Subject: Re: [PATCH v3 01/18] hw/block/nvme: bump spec data structures to v1.3 Message-ID: <20200708212404.GA1018121@apples.localdomain> References: <20200706061303.246057-1-its@irrelevant.dk> <20200706061303.246057-2-its@irrelevant.dk> <222a814fdd8a6ca878e04b30d64015ed629bac68.camel@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <222a814fdd8a6ca878e04b30d64015ed629bac68.camel@wdc.com> Received-SPF: pass client-ip=128.199.63.193; envelope-from=its@irrelevant.dk; helo=charlie.dont.surf X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/08 17:24:09 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "fam@euphon.net" , "kwolf@redhat.com" , "qemu-block@nongnu.org" , "k.jensen@samsung.com" , "qemu-devel@nongnu.org" , "mreitz@redhat.com" , "kbusch@kernel.org" , "javier.gonz@samsung.com" , "mlevitsk@redhat.com" , "philmd@redhat.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Jul 8 19:19, Dmitry Fomichev wrote: > Looks good with a small nit (see below), > > Reviewed-by: Dmitry Fomichev > > > > On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote: > > +#define NVME_TEMP_TMPTH(temp) ((temp >> 0) & 0xffff) > > There is an extra space after temp >> > Good catch! I won't repost for this ;) - but I'll fix it and add it in the qemu-nvme tree.