From: Stefan Hajnoczi <stefanha@redhat.com>
To: Raphael Norwitz <raphael.s.norwitz@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
cohuck@redhat.com, QEMU <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>,
Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Raphael Norwitz <raphael.norwitz@nutanix.com>
Subject: Re: [PATCH v5 5/5] vhost-user-blk: default num_queues to -smp N
Date: Fri, 10 Jul 2020 13:53:34 +0100 [thread overview]
Message-ID: <20200710125334.GB8433@stefanha-x1.localdomain> (raw)
In-Reply-To: <CAFubqFsSTv_j_46sq=+Kz7uDnk8eYvB+moCLNeuV8nG9YKzb7A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 839 bytes --]
On Thu, Jul 09, 2020 at 11:02:24AM -0700, Raphael Norwitz wrote:
> On Mon, Jul 6, 2020 at 7:00 AM Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
> > index a00b854736..39aec42dae 100644
> > --- a/hw/block/vhost-user-blk.c
> > +++ b/hw/block/vhost-user-blk.c
> > @@ -420,6 +420,9 @@ static void vhost_user_blk_device_realize(DeviceState *dev, Error **errp)
> > return;
> > }
> >
> > + if (s->num_queues == VHOST_USER_BLK_AUTO_NUM_QUEUES) {
> > + s->num_queues = 1;
> > + }
>
> What is this check for? Is it just a backstop to ensure that
> num_queues is set to 1 if vhost-user-blk-pci doesn't update it?
For the non-PCI VIRTIO transports that do not handle num_queues ==
VHOST_USER_BLK_AUTO_NUM_QUEUES themselves.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-10 12:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 13:56 [PATCH v5 0/5] virtio-pci: enable blk and scsi multi-queue by default Stefan Hajnoczi
2020-07-06 13:56 ` [PATCH v5 1/5] virtio-pci: add virtio_pci_optimal_num_queues() helper Stefan Hajnoczi
2020-07-07 15:46 ` Cornelia Huck
2020-07-06 13:56 ` [PATCH v5 2/5] virtio-scsi: introduce a constant for fixed virtqueues Stefan Hajnoczi
2020-07-06 13:56 ` [PATCH v5 3/5] virtio-scsi: default num_queues to -smp N Stefan Hajnoczi
2020-07-07 15:44 ` Cornelia Huck
2020-07-08 13:05 ` Stefan Hajnoczi
2020-07-08 16:50 ` Cornelia Huck
2020-07-13 10:22 ` Stefan Hajnoczi
2020-07-08 13:08 ` Stefan Hajnoczi
2020-07-06 13:56 ` [PATCH v5 4/5] virtio-blk: " Stefan Hajnoczi
2020-07-06 13:56 ` [PATCH v5 5/5] vhost-user-blk: " Stefan Hajnoczi
2020-07-09 18:02 ` Raphael Norwitz
2020-07-10 12:53 ` Stefan Hajnoczi [this message]
2020-07-10 18:48 ` Raphael Norwitz
2020-07-08 10:59 ` [PATCH v5 0/5] virtio-pci: enable blk and scsi multi-queue by default Michael S. Tsirkin
2020-07-08 12:59 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710125334.GB8433@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=raphael.s.norwitz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).